ERR33-C: library can access stdin by reference

mbaluda · mbaluda · commit 13a5c61c1dcf · 2023-04-12T19:55:48.000+02:00
diff --git a/c/cert/src/rules/ERR33-C/DetectAndHandleStandardLibraryErrors.ql b/c/cert/src/rules/ERR33-C/DetectAndHandleStandardLibraryErrors.ql
@@ -441,7 +441,7 @@ ControlFlowNode ferrorNotchecked(FileWriteFunctionCall write) {
     not isShortCircuitedEdge(mid, result) and
     result = mid.getASuccessor() and
     //Stop recursion on call to ferror on the correct file
-    not accessSameTarget(result.(FerrorCall).getArgument(0), write.getFileExpr())
+    not sameFileSource(result.(FerrorCall), write)
   )
 }
 

Original file line number	Diff line number	Diff line change
`@@ -441,7 +441,7 @@ ControlFlowNode ferrorNotchecked(FileWriteFunctionCall write) {`
`441`	`441`	`not isShortCircuitedEdge(mid, result) and`
`442`	`442`	`result = mid.getASuccessor() and`
`443`	`443`	`//Stop recursion on call to ferror on the correct file`
`444`		`- not accessSameTarget(result.(FerrorCall).getArgument(0), write.getFileExpr())`
	`444`	`+ not sameFileSource(result.(FerrorCall), write)`
`445`	`445`	`)`
`446`	`446`	`}`
`447`	`447`