Skip to content

Commit b95f441

Browse files
Tim SchultzTim Schultz
andauthored
checking for value before accessing networkName to display connection… (#10597)
* checking for value before accessing networkName to display connection status and giving a more descriptive network error for matching claims * return token amount from matching endpoint and display on claim Co-authored-by: Tim Schultz <timschultz@Computer.local>
1 parent e3ecef1 commit b95f441

File tree

5 files changed

+12
-9
lines changed

5 files changed

+12
-9
lines changed

app/assets/v2/js/grants/matching_funds.js

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -145,9 +145,10 @@ Vue.mixin({
145145

146146
const chainId = Number(web3.eth.currentProvider.chainId);
147147

148-
if (chainId < 1 || chainId > 5) {
148+
// At this moment claims can only be completed on mainnet
149+
if (chainId !== 1) {
149150
waitingState(false);
150-
_alert('Please connect to a valid Ethereum network', 'danger');
151+
_alert('Please connect to Ethereum mainnet.', 'danger');
151152
return;
152153
}
153154

app/assets/v2/js/wallet.js

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -112,9 +112,11 @@ async function fetchAccountData(provider) {
112112
// Load chain information over an HTTP API
113113
// const chainData = await EvmChains.getChain(chainId);
114114

115-
document.querySelector('.network-name').textContent = networkName;
116-
document.querySelector('.wallet-network').classList.remove('rinkeby', 'mainnet');
117-
document.querySelector('.wallet-network').classList.add(networkName.split(' ').join('-'));
115+
if (networkName) {
116+
document.querySelector('.network-name').textContent = networkName;
117+
document.querySelector('.wallet-network').classList.remove('rinkeby', 'mainnet');
118+
document.querySelector('.wallet-network').classList.add(networkName.split(' ').join('-'));
119+
}
118120

119121
document.querySelector('#wallet-btn').innerText = 'Change Wallet';
120122

app/grants/serializers.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -53,7 +53,7 @@ class CLRMatchSerializer(FlexFieldsModelSerializer):
5353
class Meta:
5454
model = CLRMatch
5555
fields = (
56-
'pk', 'amount', 'round_number', 'claim_tx', 'grant_payout', 'ready_for_payout', 'merkle_claim'
56+
'pk', 'amount', 'token_amount', 'round_number', 'claim_tx', 'grant_payout', 'ready_for_payout', 'merkle_claim'
5757
)
5858

5959

@@ -65,7 +65,7 @@ class GrantSerializer(FlexFieldsModelSerializer):
6565
admin_profile = ProfileSerializer()
6666
team_members = ProfileSerializer(many=True)
6767
clr_matches = CLRMatchSerializer(
68-
fields=['pk', 'amount', 'round_number', 'claim_tx', 'grant_payout', 'ready_for_payout', 'merkle_claim'],
68+
fields=['pk', 'amount', 'token_amount', 'round_number', 'claim_tx', 'grant_payout', 'ready_for_payout', 'merkle_claim'],
6969
many=True
7070
)
7171

app/grants/templates/grants/components/historical_claim.html

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@
44
<span class="font-bigger-1 text-grey-500">[[ stringifyClrs(match.grant_payout.grant_clrs) ]] (GR[[ match.round_number ]])</span>
55
</b-col>
66
<b-col lg="2" sm="12" class="pt-2 pt-lg-0">
7-
<h4 class="d-lg-block d-none font-weight-bold font-bigger-1 gc-font-base">[[ match.amount | decimals | formatNumber ]] [[ payoutToken ]]</h4>
7+
<h4 class="d-lg-block d-none font-weight-bold font-bigger-1 gc-font-base">[[ match.token_amount | decimals | formatNumber ]] [[ payoutToken ]]</h4>
88
<span class="d-lg-none d-inline font-weight-bold font-subheader">[[ match.amount | decimals | formatNumber ]] [[ payoutToken ]]</span>
99
<span class="font-body text-grey-500 ml-2 ml-lg-0">$[[ match.amount | decimals | formatNumber ]]</span>
1010
</b-col>

app/grants/templates/grants/components/ready_claim.html

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@
44
<span class="font-bigger-1 text-grey-500" id="grant-clrs">[[ stringifyClrs(match.grant_payout.grant_clrs) ]] (GR[[ match.round_number ]])</span>
55
</b-col>
66
<b-col lg="2" sm="12" class="pt-2 pt-lg-0">
7-
<h4 class="d-lg-block d-none font-weight-bold font-bigger-1 gc-font-base">[[ match.amount | decimals | formatNumber ]] [[ match.grant_payout.token.symbol ]]</h4>
7+
<h4 class="d-lg-block d-none font-weight-bold font-bigger-1 gc-font-base">[[ match.token_amount | decimals | formatNumber ]] [[ match.grant_payout.token.symbol ]]</h4>
88
<span class="d-lg-none d-inline font-weight-bold font-subheader">[[ match.amount | decimals | formatNumber ]] [[ match.grant_payout.token.symbol ]]</span>
99
<span class="font-body text-grey-500 ml-2 ml-lg-0">$[[ match.amount | decimals | formatNumber ]]</span>
1010
<span v-if="match.grant_payout.status === 'pending'">(pending review)</span>

0 commit comments

Comments
 (0)