uppercase const name as recommended by pylint

Author: raphaelhuefner

gitcoin/validation.py

@@ -2,7 +2,7 @@
 
 # Valid parameter values as seen at
 # https://github.com/gitcoinco/web/blob/84babc30611c281c817582b4d677dda6366def83/app/dashboard/models.py#L119-L168
-options = {
+OPTIONS = {
     'experience_level': ['Beginner', 'Intermediate', 'Advanced', 'Unknown'],
     'project_length': ['Hours', 'Days', 'Weeks', 'Months', 'Unknown'],
     'bounty_type': ['Bug', 'Security', 'Feature', 'Unknown'],
@@ -25,34 +25,40 @@
     ]
 }
 
+
 def _validate_options(field_name, value):
     """Validate values for the given field name."""
-    if value in options[field_name]:
+    if value in OPTIONS[field_name]:
         return value
     msg = 'Unknown value "{val}" for field "{name}".'
     raise ValueError(msg.format(val=value, name=field_name))
 
+
 def experience_level(value):
     """Validate values for "experience_level"."""
     return _validate_options('experience_level', value)
 
+
 def project_length(value):
     """Validate values for "project_length"."""
     return _validate_options('project_length', value)
 
+
 def bounty_type(value):
     """Validate values for "bounty_type"."""
     return _validate_options('bounty_type', value)
 
+
 def idx_status(value):
     """Validate values for "idx_status"."""
     return _validate_options('idx_status', value)
 
+
 def order_by(direction):
     """Validate values for "order_by"."""
-    if direction in options['order_by']:
+    if direction in OPTIONS['order_by']:
         return direction
-    if direction[0:1] == '-' and direction[1:] in options['order_by']:
+    if direction[0:1] == '-' and direction[1:] in OPTIONS['order_by']:
         return direction
     msg = 'Unknown direction "{dir}" to order by.'
     raise ValueError(msg.format(dir=direction))

tests/test_live.py

@@ -59,7 +59,7 @@ def test_multiple_value_filters(self):
                 assert_is_list_of_bounties(result)
 
     def test_order_by(self):
-        sort_field_names = gitcoin.validation.options['order_by']
+        sort_field_names = gitcoin.validation.OPTIONS['order_by']
         api = Gitcoin()
         for field_name in sort_field_names:
             for direction in [field_name, ''.join(('-', field_name))]: