Merge pull request #43 from gitbito/release/1.6.6

Added support for linter feedback enable/disable and output path for …

Author: adhirpotdarbito

cra-scripts/bito-cra.properties

@@ -7,6 +7,7 @@ git.access_token=
 git.domain=
 static_analysis=True
 static_analysis_tool=fb_infer,astral_ruff,mypy
+linters_feedback=True
 review_scope=
 dependency_check=False
 code_context=True

cra-scripts/bito-cra.ps1

@@ -232,6 +232,7 @@ function Check-OutputDirectory {
         exit 1
     }
 
+    Write-Host "Output path: $output_path"
     #return valid cli directory
     return $output_path
 }
@@ -406,6 +407,7 @@ $optional_params_cli = @(
     "review_comments",
     "static_analysis",
     "static_analysis_tool",
+    "linters_feedback",
     "review_scope",
     "exclude_branches",
     "exclude_files",
@@ -441,6 +443,7 @@ $optional_params_server = @(
     "review_comments",
     "static_analysis",
     "static_analysis_tool",
+    "linters_feedback",
     "review_scope",
     "exclude_branches",
     "exclude_files",
@@ -460,6 +463,7 @@ $optional_params_server = @(
     "custom_rules.region_name"
     "custom_rules.bucket_name"
     "custom_rules.aes_key"
+    "output_path"
 )
 
 $bee_params = @(
@@ -528,7 +532,7 @@ foreach ($param in $required_params) {
 foreach ($param in $optional_params) {
     if ($param -eq "dependency_check.snyk_auth_token" -and $props["dependency_check"] -eq "True") {
         Ask-For-Param $param $false
-    } elseif ($param -ne "dependency_check.snyk_auth_token" -and $param -ne "env" -and $param -ne "cli_path" -and $param -ne "output_path" -and $param -ne "static_analysis_tool" -and $param -ne "git.domain" -and $param -ne "review_scope" -and $param -ne "exclude_branches" -and $param -ne "exclude_files" -and $param -ne "exclude_draft_pr" -and $param -ne "cr_event_type" -and $param -ne "posting_to_pr" -and $param -ne "custom_rules.configured_ws_ids"  -and  $param -ne "custom_rules.aws_access_key_id"  -and  $param -ne "custom_rules.aws_secret_access_key"  -and  $param -ne "custom_rules.region_name"  -and  $param -ne "custom_rules.bucket_name"  -and  $param -ne "custom_rules.aes_key") {
+    } elseif ($param -ne "dependency_check.snyk_auth_token" -and $param -ne "env" -and $param -ne "cli_path" -and $param -ne "output_path" -and $param -ne "static_analysis_tool" -and $param -ne "linters_feedback" -and $param -ne "git.domain" -and $param -ne "review_scope" -and $param -ne "exclude_branches" -and $param -ne "exclude_files" -and $param -ne "exclude_draft_pr" -and $param -ne "cr_event_type" -and $param -ne "posting_to_pr" -and $param -ne "custom_rules.configured_ws_ids"  -and  $param -ne "custom_rules.aws_access_key_id"  -and  $param -ne "custom_rules.aws_secret_access_key"  -and  $param -ne "custom_rules.region_name"  -and  $param -ne "custom_rules.bucket_name"  -and  $param -ne "custom_rules.aes_key"  -and  $param -ne "code_context_config.partial_timeout"  -and  $param -ne "code_context_config.max_depth"  -and  $param -ne "code_context_config.kill_timeout_sec") {
         Ask-For-Param $param $false
     }
 }
@@ -554,6 +558,9 @@ foreach ($param in $required_params + $bee_params + $optional_params) {
             $docker_cmd += " --static_analysis.fb_infer.enabled=$validated_boolean"
         } elseif ($param -eq "static_analysis_tool") {
             $docker_cmd += " --$param=$($props[$param])"
+        } elseif ($param -eq "linters_feedback") {
+            $validated_boolean = Validate-Boolean $props[$param]
+            $docker_cmd += " --$param=$validated_boolean"
         } elseif ($param -eq "review_scope") {
             $scopes = $($props[$param]) -replace ',\s*', ','
             $docker_cmd += " --$param='[$scopes]'"

cra-scripts/bito-cra.sh

@@ -220,7 +220,7 @@ check_output_directory() {
     echo "output path directory not found!"
     return 1
   else
-    echo $output_path
+    echo "Output Path: $output_path"
     return 0
   fi
 }
@@ -416,6 +416,7 @@ optional_params_cli=(
   "review_comments"
   "static_analysis"
   "static_analysis_tool"
+  "linters_feedback"
   "review_scope"
   "exclude_branches"
   "exclude_files"
@@ -452,6 +453,7 @@ optional_params_server=(
   "review_comments"
   "static_analysis"
   "static_analysis_tool"
+  "linters_feedback"
   "review_scope"
   "exclude_branches"
   "exclude_files"
@@ -472,6 +474,7 @@ optional_params_server=(
   "custom_rules.region_name"
   "custom_rules.bucket_name"
   "custom_rules.aes_key"
+  "output_path"
 )
 
 bee_params=(
@@ -537,7 +540,7 @@ done
 for param in "${optional_params[@]}"; do
   if [ "$param" == "dependency_check.snyk_auth_token" ] && [ "${props["dependency_check"]}" == "True" ]; then
       ask_for_param "$param" "False"
-  elif [ "$param" != "dependency_check.snyk_auth_token" ] && [ "$param" != "env" ] && [ "$param" != "cli_path" ] && [ "$param" != "output_path" ] && [ "$param" != "static_analysis_tool" ] && [ "$param" != "git.domain" ] && [ "$param" != "review_scope" ] && [ "$param" != "exclude_branches" ] && [ "$param" != "nexus_url" ] && [ "$param" != "exclude_files" ] && [ "$param" != "exclude_draft_pr" ] && [ "$param" != "cr_event_type" ] && [ "$param" != "posting_to_pr" ] && [ "$param" != "custom_rules.configured_ws_ids" ] && [ "$param" != "custom_rules.aws_access_key_id" ] && [ "$param" != "custom_rules.aws_secret_access_key" ] && [ "$param" != "custom_rules.region_name" ] && [ "$param" != "custom_rules.bucket_name" ] && [ "$param" != "custom_rules.aes_key" ]; then
+  elif [ "$param" != "dependency_check.snyk_auth_token" ] && [ "$param" != "env" ] && [ "$param" != "cli_path" ] && [ "$param" != "output_path" ] && [ "$param" != "static_analysis_tool" ]  && [ "$param" != "linters_feedback" ] && [ "$param" != "git.domain" ] && [ "$param" != "review_scope" ] && [ "$param" != "exclude_branches" ] && [ "$param" != "nexus_url" ] && [ "$param" != "exclude_files" ] && [ "$param" != "exclude_draft_pr" ] && [ "$param" != "cr_event_type" ] && [ "$param" != "posting_to_pr" ] && [ "$param" != "custom_rules.configured_ws_ids" ] && [ "$param" != "custom_rules.aws_access_key_id" ] && [ "$param" != "custom_rules.aws_secret_access_key" ] && [ "$param" != "custom_rules.region_name" ] && [ "$param" != "custom_rules.bucket_name" ] && [ "$param" != "custom_rules.aes_key" ] && [ "$param" != "code_context_config.partial_timeout" ] && [ "$param" != "code_context_config.max_depth" ] && [ "$param" != "code_context_config.kill_timeout_sec" ]; then
       ask_for_param "$param" "False"
   fi
 done
@@ -569,6 +572,9 @@ for param in "${required_params[@]}" "${bee_params[@]}" "${optional_params[@]}";
         docker_cmd+=" --static_analysis.fb_infer.enabled=${props[$param]}"
     elif [ "$param" == "static_analysis_tool" ]; then
         docker_cmd+=" --static_analysis_tool=${props[$param]}"
+    elif [ "$param" == "linters_feedback" ]; then
+        props[$param]=$(validate_boolean "${props[$param]}")
+        docker_cmd+=" --linters_feedback=${props[$param]}"
     elif [ "$param" == "review_scope" ]; then
         scopes=$(echo ${props[$param]} | sed 's/, */,/g')
         docker_cmd+=" --review_scope='[$scopes]'"