Final testing

Author: git-user-9

.github/workflows/deploy.yml

@@ -30,59 +30,88 @@ jobs:
     runs-on: ubuntu-latest
 
     steps:
-    # ✅ Checkout Repository
+    # Checkout Repository
     - name: Checkout repository
       uses: actions/checkout@v4
 
-    # ✅ Configure AWS Credentials
+    # Configure AWS Credentials
     - name: Configure AWS credentials
       uses: aws-actions/configure-aws-credentials@v2
       with:
         aws-access-key-id: ${{ secrets.AWS_ACCESS_KEY_ID }}
         aws-secret-access-key: ${{ secrets.AWS_SECRET_ACCESS_KEY }}
         aws-region: ${{ env.AWS_REGION }}
+        aws-output: json
 
-    # ✅ Install Terraform
+    # Install Terraform
     - name: Setup Terraform
       uses: hashicorp/setup-terraform@v3
 
-    # ✅ Terraform Init & Workspace
+    # Determin Stage - dev/prod/qa defaults to dev
+    # - name: Determine Stage
+    #   id: set_stage
+    #   run: |
+    #     if [[ "${GITHUB_REF}" == "refs/tags/deploy-dev" ]]; then
+    #       echo "STAGE=dev" >> $GITHUB_ENV
+    #     elif [[ "${GITHUB_REF}" == "refs/tags/deploy-qa" ]]; then
+    #       echo "STAGE=qa" >> $GITHUB_ENV
+    #     elif [[ "${GITHUB_REF}" == "refs/tags/deploy-prod" ]]; then
+    #       echo "STAGE=prod" >> $GITHUB_ENV
+    #     elif [[ "${GITHUB_EVENT_NAME}" == "workflow_dispatch" ]]; then
+    #       echo "STAGE=${{ github.event.inputs.stage }}" >> $GITHUB_ENV
+    #     else
+    #       echo "STAGE=dev" >> $GITHUB_ENV  # default fallback
+    #     fi
+
+    #     echo "🛠️ Deployment stage: $STAGE"
+
+    # Terraform Init & Workspace
     - name: Terraform Init & Workspace
       working-directory: ${{ env.TF_WORKING_DIR }}
       run: |
         terraform init
         terraform workspace select ${{ github.event.inputs.stage }} || terraform workspace new ${{ github.event.inputs.stage }}
 
-    # ✅ Terraform Apply
+    # Terraform Apply
     - name: Terraform Apply
       working-directory: ${{ env.TF_WORKING_DIR }}
       run: |
         terraform apply -var-file="${{ github.event.inputs.stage }}_config.tfvars" -auto-approve \
           -var "stage=${{ github.event.inputs.stage }}"
 
-    # ✅ Get EC2 IPs & S3 Bucket
+    # Output and inject EC2 IPs & S3 Bucket name to Github Env
     - name: Get EC2s Public IPs & S3 Bucket Name
       working-directory: ${{ env.TF_WORKING_DIR }}
       run: |
-        echo "INSTANCE_IP=$(terraform output -raw instance_public_ip)" >> $GITHUB_ENV
-        echo "VERIFIER_IP=$(terraform output -raw verifier_instance_public_ip)" >> $GITHUB_ENV
-        echo "S3_BUCKET=$(terraform output -raw s3_log_bucket)" >> $GITHUB_ENV
-
-        echo "📦 App IP: $INSTANCE_IP"
-        echo "🔑 Verifier IP: $VERIFIER_IP"
-        echo "🪣 S3 Bucket: $S3_BUCKET"
-        echo "📦 App IP: ${{ env.INSTANCE_IP }}"
-        echo "🔑 Verifier IP: ${{ env.VERIFIER_IP }}"
-        echo "🪣 S3 Bucket: ${{ env.S3_BUCKET }}"
-
-
-    # ✅ Wait for App Initialization
+        echo "Injecting terraform outputs to github environment"
+        # echo "INSTANCE_IP=$(terraform output -raw instance_public_ip)" >> $GITHUB_ENV
+        # echo "VERIFIER_IP=$(terraform output -raw verifier_instance_public_ip)" >> $GITHUB_ENV
+        # echo "S3_BUCKET=$(terraform output -raw s3_log_bucket)" >> $GITHUB_ENV
+        # Assign to local shell variables
+        INSTANCE_IP=$(terraform output -raw instance_public_ip)
+        VERIFIER_IP=$(terraform output -raw verifier_instance_public_ip)
+        S3_BUCKET=$(terraform output -raw s3_log_bucket)
+
+        # Write to GitHub Actions ENV for later steps
+        echo "INSTANCE_IP=$INSTANCE_IP" >> $GITHUB_ENV
+        echo "VERIFIER_IP=$VERIFIER_IP" >> $GITHUB_ENV
+        echo "S3_BUCKET=$S3_BUCKET" >> $GITHUB_ENV
+
+        # Echo both for current step & confirmation
+        echo "📦 App IP (Shell): $INSTANCE_IP"
+        echo "🔑 Verifier IP (Shell): $VERIFIER_IP"
+        echo "🪣 S3 Bucket (Shell): $S3_BUCKET"
+        echo "📦 App IP (Env): ${{ env.INSTANCE_IP }}"
+        echo "🔑 Verifier IP (Env): ${{ env.VERIFIER_IP }}"
+        echo "🪣 S3 Bucket (Env): ${{ env.S3_BUCKET }}"
+
+    # Wait for App Initialization
     - name: Wait for App Initialization
       run: |
         echo "⏳ Waiting 90 seconds for EC2 instances to initialize..."
         sleep 90
 
-    # ✅ Validate App Health
+    # Validate App Health
     - name: Validate App Health
       run: |
         echo "🌐 Checking app health at http://${{ env.INSTANCE_IP }}:80"
@@ -99,15 +128,15 @@ jobs:
         echo "❌ App failed health check"
         exit 1
 
-    # ✅ Verify Logs in S3
+    # Verify Logs in S3
     - name: Verify Logs in S3
       run: |
         echo "📦 Checking for logs in S3 bucket: $S3_BUCKET"
         aws s3 ls s3://$S3_BUCKET/system/cloud-init.log || { echo "❌ system logs missing"; exit 1; }
         aws s3 ls s3://$S3_BUCKET/app/my-app.log || { echo "❌ app logs missing"; exit 1; }
         echo "✅ Logs found in S3 bucket"
 
-    # ✅ Optional Destroy (disabled by default)
+    # Destroy (disabled by default)
     - name: Destroy infrastructure
       if: always() 
       working-directory: ${{ env.TF_WORKING_DIR }}
@@ -117,9 +146,9 @@ jobs:
         terraform destroy -var-file="${{ github.event.inputs.stage }}_config.tfvars" -auto-approve \
           -var "stage=${{ github.event.inputs.stage }}"
 
-    # ✅ Optional Cleanup Terraform Workspace
+    # Cleanup Terraform Workspace
     - name: Cleanup Terraform Workspace
-      if: always() # Enable if you want to cleanup workspace
+      if: always() 
       working-directory: ${{ env.TF_WORKING_DIR }}
       run: |
         terraform workspace select default