Skip to content

[BUG] scikit-learn dependency should be range #706

@abhinavnatarajan

Description

@abhinavnatarajan

Describe the bug
v0.6.2 of giotto-tda has a strict requirement on scikit-learn==1.3.2, which is around 6 months old as of today. This means that if a user has any newer version of scikit-learn, 'pip install giotto-tda' will try to build giotto-tda from source instead of installing the PyPI wheels. This leads to several problems while installing the package due to the build process being non-trivial.

The version specifier should be changed to 'scikit-learn>=1.3.2' or 'scikit-learn~=1.3' (the latter is roughly equivalent to 'scikit-learn>=1.3, scikit-learn==1.*' which would nominally ensure no breakage assuming that scikit-learn follows semver).

EDIT: This bug only affects Python>=3.12, since this bug is a regression from giotto-tda 0.6.1 which is compatible with Python<3.12 and has a more permissive dependency specifier.

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't working

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions