-
Notifications
You must be signed in to change notification settings - Fork 99
add yaml-cpp support for file config #1677
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, only few minor points
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
I wish there was a better library for YAML parsing, but I guess this will have to do. There are some issues with how yaml-cpp handles assignment and copies jbeder/yaml-cpp#1275. And to quote the developer:
Not blocking, just something to keep in mind in case we find a better library out there. |
Yes, I also faced the issue that it still accepts the invalid yaml file.
which should be invalid because <<: can only used from map not array. |
Co-authored-by: Marcel Koch <marcel.koch@kit.edu>
Co-authored-by: Tobias Ribizel <mail@ribizel.de>
This PR adds the yaml-cpp to support yaml format for file config which gives the alias feature to reuse config.
welcome any suggestion of yaml library.