Reusable permutation and transpose #1338
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ginkgo-bot
added
reg:build
fritzgoebel
approved these changes
Jun 27, 2023
|
Just a comment, but Csr now has 18 (!) function for permutation. IMO that is too much, at least the |
5 tasks
upsj
force-pushed
the
reusable_operations
branch
from
2f2e939 to
79aba5b
Compare
MarcelKoch
requested changes
Feb 14, 2025
There was a problem hiding this comment.
In general LGTM, I would like to discuss the difference between returning both the reuse info with the transposed/permuted matrix and just the reuse info.
If the use case for the reuse info is to be used only once or twice, the current approach makes sense.
If, however, it should be applied in a loop (or similar) then I think returning only the reuse info should lead to more uniform control flow.
upsj
force-pushed
the
reusable_operations
branch
from
6ed38e4 to
e7bfbe3
Compare
MarcelKoch
approved these changes
Feb 18, 2025
upsj
added
1:ST:ready-for-review
upsj
force-pushed
the
reusable_operations
branch
2 times, most recently
from
cccf80d to
c7989b1
Compare
upsj
force-pushed
the
reusable_operations
branch
from
c7989b1 to
85e0e76
Compare
upsj
force-pushed
the
reusable_operations
branch
from
85e0e76 to
e21e7ab
Compare
|
Error: PR already merged! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As a tool for implementing reusable factories, this adds reusable functionality for all Csr permutation and transpose functions.
It also takes a first step towards making
Permutationthe default representation of a reordering.Closes #1157