Zip is not compressed #527

Being-bear · 2024-08-29T07:29:52Z

Being-bear
Aug 29, 2024

Hi,

I try to implement to zip+store a Javascript-generated Json, using the example given in https://github.com/gildas-lormeau/zip.js

The downloaded file is not zipped. I do not get any errors.
I use pure Javascript, no frameworks.

Any hint would be highly appreciated 🙏

I have been a long time programmer in Java and am somewhat new to Javascript. So please forgive me if this is a beginners problem.

Juergen

PS: Loading a zipped Json file from the web and unzipping it into memory works fine.

<!doctype html>
<html lang="de">
<head>
    <meta charset="UTF-8" />
</head>

...
    <script type="text/javascript" src="lib/zip.min.js"></script>
...
<body>
...
<script>

   // download file to the user via the browser
   // this function is called from a download button
    async function downloadToBrowser(e) {

        const zipFileWriter = new zip.BlobWriter();
	// actually the content comes from here: txt = JSON.stringify(data)
	// but for demonstration purposes I multiply Hello world
        let txt = "Hello world!";
       for (let i = 0; i <= 10; i++) {
             txt += txt;
        }
        console.log("txt.length: " + txt.length);
        const helloWorldReader = new zip.TextReader(txt);
        const zipWriter = new zip.ZipWriter(zipFileWriter);
        await zipWriter.add("hello.txt", helloWorldReader);
        await zipWriter.close();
        const zipFileBlob = await zipFileWriter.getData();
        console.log("zipFileBlob.size: " + zipFileBlob.size);

        f = new File([zipFileBlob], "Hello.zip"); 
        downloadFile(f);
    }

    // from https://pqina.nl/blog/how-to-prompt-the-user-to-download-a-file-instead-of-navigating-to-it/
    // usage:
    // const myFile = new File([`${new Date()}: Meow!`], 'my-cat.txt');
    function downloadFile(file) {

        // Create a link and set the URL using `createObjectURL`
        const link = document.createElement('a');
        link.style.display = 'none';
        link.href = URL.createObjectURL(file);
        link.download = file.name;
    
        // It needs to be added to the DOM so it can be clicked
        document.body.appendChild(link);
        link.click();
    
        // To make this work on Firefox we need to wait
        // a little while before removing it.
        setTimeout(() => {
            URL.revokeObjectURL(link.href);
            link.parentNode.removeChild(link);
        }, 0);
    }
</script>
</body>
</html>

Being-bear · 2024-08-29T08:17:32Z

Being-bear
Aug 29, 2024
Author

Hi all, I upgraded to 2.7.52 and the problem is solved.

1 reply

gildas-lormeau Aug 29, 2024
Maintainer

What version were you using out of curiosity?

Being-bear · 2024-08-29T12:28:49Z

Being-bear
Aug 29, 2024
Author

Actually I am not shure ... I downloaded it at Aug 21, and the zip had the name of "zip.js-gh-pages.zip". Obviously I did not use the release nor the Code section. If you guide me where to look in the files for a version, I could do that. I attached what I downloaded:
20240821_zip.js-gh-pages.zip
Thanks for your support and this very helpful library!

0 replies

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Zip is not compressed #527

Uh oh!

{{title}}

Uh oh!

Replies: 2 comments 1 reply

Uh oh!

{{title}}

Uh oh!

Uh oh!

{{title}}

Uh oh!

Uh oh!

{{title}}

Uh oh!

Select a reply

Uh oh!

Zip is not compressed #527

Uh oh!

Being-bear Aug 29, 2024

Replies: 2 comments · 1 reply

Uh oh!

Being-bear Aug 29, 2024 Author

Uh oh!

gildas-lormeau Aug 29, 2024 Maintainer

Uh oh!

Being-bear Aug 29, 2024 Author

Being-bear
Aug 29, 2024

Replies: 2 comments 1 reply

Being-bear
Aug 29, 2024
Author

gildas-lormeau Aug 29, 2024
Maintainer

Being-bear
Aug 29, 2024
Author