Skip to content

Commit d2f5a90

Browse files
committed
fix: remove unused import, update paramter name
1 parent f1122d0 commit d2f5a90

File tree

2 files changed

+15
-20
lines changed

2 files changed

+15
-20
lines changed

openapi-generator/lib/src/openapi_generator_runner.dart

Lines changed: 2 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,6 @@ import 'dart:isolate';
66
import 'package:analyzer/dart/element/element.dart';
77
import 'package:build/build.dart';
88
import 'package:logging/logging.dart';
9-
import 'package:openapi_generator/src/determine_flutter_project_status.dart';
109
import 'package:openapi_generator/src/models/output_message.dart';
1110
import 'package:openapi_generator/src/utils.dart';
1211
import 'package:openapi_generator_annotations/openapi_generator_annotations.dart'
@@ -25,12 +24,8 @@ class OpenapiGenerator extends GeneratorForAnnotation<annots.Openapi> {
2524
OpenapiGenerator({
2625
this.testMode = false,
2726
this.runner = const CommandRunner(),
28-
Logger? log,
29-
}) : _log = log ?? Logger('OpenApiGenerator') {
30-
_log.onRecord.listen((event) {
31-
print(event.toString());
32-
});
33-
}
27+
Logger? logger,
28+
}) : _log = logger ?? Logger('OpenApiGenerator');
3429

3530
@override
3631
FutureOr<String> generateForAnnotatedElement(

openapi-generator/test/generator_test.dart

Lines changed: 13 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -46,7 +46,7 @@ void main() {
4646
final logs = <LogRecord>[];
4747
logger.onRecord.listen(logs.add);
4848
try {
49-
await OpenapiGenerator(log: logger).generateForAnnotatedElement(
49+
await OpenapiGenerator(logger: logger).generateForAnnotatedElement(
5050
MockMethodElement(), defaultAnnotations, MockBuildStep());
5151
fail('Should throw when not ClassElement');
5252
} catch (_, __) {
@@ -108,7 +108,7 @@ void main() {
108108
providedPubspecPath: anyNamed('providedPubspecPath')))
109109
.thenAnswer((_) async => false);
110110

111-
await OpenapiGenerator(log: logger, runner: mockRunner)
111+
await OpenapiGenerator(logger: logger, runner: mockRunner)
112112
.generateForAnnotatedElement(
113113
MockClassElement(), defaultAnnotations, MockBuildStep());
114114

@@ -136,7 +136,7 @@ void main() {
136136
providedPubspecPath: anyNamed('providedPubspecPath')))
137137
.thenAnswer((_) async => true);
138138

139-
await OpenapiGenerator(log: logger, runner: mockRunner)
139+
await OpenapiGenerator(logger: logger, runner: mockRunner)
140140
.generateForAnnotatedElement(
141141
MockClassElement(), annotations, MockBuildStep());
142142

@@ -164,7 +164,7 @@ void main() {
164164
providedPubspecPath: anyNamed('providedPubspecPath')))
165165
.thenAnswer((_) async => true);
166166

167-
await OpenapiGenerator(log: logger, runner: mockRunner)
167+
await OpenapiGenerator(logger: logger, runner: mockRunner)
168168
.generateForAnnotatedElement(
169169
MockClassElement(), annotations, MockBuildStep());
170170

@@ -193,7 +193,7 @@ void main() {
193193
),
194194
).thenAnswer((_) async => true);
195195

196-
await OpenapiGenerator(log: logger, runner: mockRunner)
196+
await OpenapiGenerator(logger: logger, runner: mockRunner)
197197
.generateForAnnotatedElement(
198198
MockClassElement(), annotations, MockBuildStep());
199199

@@ -206,7 +206,7 @@ void main() {
206206
late OpenapiGenerator generator;
207207
setUpAll(() {
208208
resetMockitoState();
209-
generator = OpenapiGenerator(log: logger, runner: mockRunner);
209+
generator = OpenapiGenerator(logger: logger, runner: mockRunner);
210210
when(mockRunner.runCommand(
211211
command: anyNamed('command'),
212212
workingDirectory: anyNamed('workingDirectory')))
@@ -289,7 +289,7 @@ void main() {
289289
late OpenapiGenerator generator;
290290
setUpAll(() {
291291
resetMockitoState();
292-
generator = OpenapiGenerator(log: logger, runner: mockRunner);
292+
generator = OpenapiGenerator(logger: logger, runner: mockRunner);
293293
});
294294
test('warning when using remote spec', () async {
295295
final logs = <LogRecord>[];
@@ -632,7 +632,7 @@ void main() {
632632
logger.onRecord.listen(logs.add);
633633
when(mockedArgs.shouldFetchDependencies).thenReturn(false);
634634

635-
await OpenapiGenerator(log: logger)
635+
await OpenapiGenerator(logger: logger)
636636
.fetchDependencies(baseCommand: 'cmd', args: mockedArgs);
637637

638638
expect(logs.length, 1);
@@ -651,7 +651,7 @@ void main() {
651651
.thenAnswer(
652652
(_) => Future.value(ProcessResult(999, 0, 'yes', '')));
653653

654-
await OpenapiGenerator(log: logger, runner: mockRunner)
654+
await OpenapiGenerator(logger: logger, runner: mockRunner)
655655
.fetchDependencies(baseCommand: 'dart', args: mockedArgs);
656656

657657
expect(logs.length, 2);
@@ -676,7 +676,7 @@ void main() {
676676
.thenAnswer(
677677
(_) => Future.value(ProcessResult(999, 0, 'yes', '')));
678678

679-
await OpenapiGenerator(log: logger, runner: mockRunner)
679+
await OpenapiGenerator(logger: logger, runner: mockRunner)
680680
.fetchDependencies(baseCommand: 'dart', args: mockedArgs);
681681

682682
expect(logs.length, 2);
@@ -875,7 +875,7 @@ void main() {
875875
workingDirectory: anyNamed('workingDirectory')))
876876
.thenAnswer((_) => Future.value(ProcessResult(999, 0, '', '')));
877877
try {
878-
await OpenapiGenerator(runner: mockRunner, log: logger)
878+
await OpenapiGenerator(runner: mockRunner, logger: logger)
879879
.formatCode(args: mockedArgs);
880880
expect(logs.length, 1);
881881
expect(logs[0].message, 'Successfully formatted code.');
@@ -926,7 +926,7 @@ void main() {
926926
when(mockedArgs.jarArgs)
927927
.thenAnswer((realInvocation) => realArguments.jarArgs);
928928
when(mockedArgs.isDebug).thenReturn(false);
929-
await OpenapiGenerator(runner: mockRunner, log: logger)
929+
await OpenapiGenerator(runner: mockRunner, logger: logger)
930930
.runOpenApiJar(arguments: mockedArgs);
931931
expect(logs.length, 2);
932932
expect(
@@ -960,7 +960,7 @@ void main() {
960960
when(mockedArgs.jarArgs)
961961
.thenAnswer((realInvocation) => realArguments.jarArgs);
962962
when(mockedArgs.isDebug).thenReturn(true);
963-
await OpenapiGenerator(runner: mockRunner, log: logger)
963+
await OpenapiGenerator(runner: mockRunner, logger: logger)
964964
.runOpenApiJar(arguments: mockedArgs);
965965
expect(logs.length, 2);
966966
expect(

0 commit comments

Comments
 (0)