Skip to content

Commit 396089f

Browse files
committed
whisper : revert mel-related changes (#0)
too much extra logic and complexity for small benefit
1 parent 9419124 commit 396089f

File tree

8 files changed

+134
-667
lines changed

8 files changed

+134
-667
lines changed

.gitignore

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -9,6 +9,7 @@
99
.DS_Store
1010
.vimspector.json
1111
/CMakeSettings.json
12+
/talk-llama.dSYM/
1213

1314
build/
1415
build-*/

Makefile

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -512,9 +512,6 @@ ifdef GGML_CUDA
512512
OBJ_GGML += ggml/src/ggml-cuda.o
513513
OBJ_GGML += $(patsubst %.cu,%.o,$(wildcard ggml/src/ggml-cuda/*.cu))
514514
OBJ_GGML += $(OBJ_CUDA_TMPL)
515-
516-
#OBJ_WHISPER += src/whisper-mel-cuda.o
517-
518515
ifdef WHISPER_FATAL_WARNINGS
519516
MK_NVCCFLAGS += -Werror all-warnings
520517
endif # WHISPER_FATAL_WARNINGS
@@ -623,10 +620,6 @@ ggml/src/ggml-cuda.o: \
623620
ggml/src/ggml-common.h \
624621
$(wildcard ggml/src/ggml-cuda/*.cuh)
625622
$(NVCC_COMPILE)
626-
627-
#src/whisper-mel-cuda.o: src/whisper-mel-cuda.cu src/whisper-mel-cuda.hpp
628-
# $(NVCC) $(NVCCFLAGS) $(CPPFLAGS) -Xcompiler "$(CUDA_CXXFLAGS)" -c $< -o $@
629-
630623
endif # GGML_CUDA
631624

632625
ifdef GGML_VULKAN
@@ -955,7 +948,6 @@ $(LIB_GGML_S): \
955948

956949
src/whisper.o: \
957950
src/whisper.cpp \
958-
src/whisper-mel.hpp \
959951
include/whisper.h \
960952
ggml/include/ggml.h \
961953
ggml/include/ggml-alloc.h \

bindings/ruby/ext/extconf.rb

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,6 @@
11
require 'mkmf'
22
system("cp #{File.join(File.dirname(__FILE__),'..','..','..','whisper.cpp')} .")
33
system("cp #{File.join(File.dirname(__FILE__),'..','..','..','whisper.h')} .")
4-
system("cp #{File.join(File.dirname(__FILE__),'..','..','..','whisper-mel.hpp')} .")
54
system("cp #{File.join(File.dirname(__FILE__),'..','..','..','ggml.h')} .")
65
system("cp #{File.join(File.dirname(__FILE__),'..','..','..','ggml.c')} .")
76
system("cp #{File.join(File.dirname(__FILE__),'..','..','..','ggml-impl.h')} .")

src/CMakeLists.txt

Lines changed: 0 additions & 30 deletions
Original file line numberDiff line numberDiff line change
@@ -78,43 +78,13 @@ if (WHISPER_OPENVINO)
7878
set_target_properties(${TARGET} PROPERTIES FOLDER "libs")
7979
endif()
8080

81-
#if (GGML_CUDA)
82-
# cmake_minimum_required(VERSION 3.18) # for CMAKE_CUDA_ARCHITECTURES
83-
#
84-
# find_package(CUDAToolkit)
85-
# if (CUDAToolkit_FOUND)
86-
# message(STATUS "CUDA found")
87-
#
88-
# if (NOT DEFINED CMAKE_CUDA_ARCHITECTURES)
89-
# # 52 == lowest CUDA 12 standard
90-
# # 60 == f16 CUDA intrinsics
91-
# # 61 == integer CUDA intrinsics
92-
# # 70 == compute capability at which unrolling a loop in mul_mat_q kernels is faster
93-
# set(CMAKE_CUDA_ARCHITECTURES "52;61;70") # lowest CUDA 12 standard + lowest for integer intrinsics
94-
# endif()
95-
# message(STATUS "Using CUDA architectures: ${CMAKE_CUDA_ARCHITECTURES}")
96-
#
97-
# enable_language(CUDA)
98-
# else()
99-
# message(WARNING "CUDA not found")
100-
# endif()
101-
#endif()
102-
10381
# whisper
10482

10583
add_library(whisper
10684
../include/whisper.h
10785
whisper.cpp
108-
whisper-mel.hpp
10986
)
11087

111-
# TODO: disabled because it relies on ggml internals that are no longer accessible (ggml-backend-impl.h, ggml-cuda/common.cuh, ..)
112-
#if (GGML_CUDA)
113-
# target_sources(whisper PRIVATE whisper-mel-cuda.cu)
114-
#
115-
# target_link_libraries(whisper PRIVATE CUDA::cufft)
116-
#endif()
117-
11888
# Set the version numbers
11989
set_target_properties(whisper PROPERTIES
12090
VERSION ${PROJECT_VERSION}

0 commit comments

Comments
 (0)