-
Notifications
You must be signed in to change notification settings - Fork 12.4k
convert-hf : support bfloat16 conversion #7158
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 5 commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
6f8d280
convert-hf : support bfloat16 conversion
compilade 59f5a27
gguf-py : flake8 fixes
compilade 3801db1
convert-hf : add missing space after comma
compilade 95930da
convert-hf : get bit-exact same output as ./quantize
compilade 58b515c
convert-hf : add --outtype auto-f16
compilade d3d32a6
convert-hf : remove a semicolon because flake8 doesn't like it
compilade e0af2df
convert-hf : support outtype templating in outfile name
compilade File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Everything looks good. This is the only line that bugs me. Not sure about the
(64 << 16)
for logical OR. I'm knee deep in a dataset, so my mental state is not 100% there right now. Could be nothing.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's doing the equivalent of these lines in
ggml-impl.h
:https://github.com/ggerganov/llama.cpp/blob/befddd0f15de6efb15d7e7f5b527dfb671f4196f/ggml-impl.h#L82-L85
(64 << 16)
came from adapting this while postponing the right shift until after rounding.(n & 0xffff0000)
is to avoid rounding up the NANs by setting the low bits to zero.