-
Notifications
You must be signed in to change notification settings - Fork 12.4k
model : jina-embeddings-v3 support #13693
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
CISC
wants to merge
15
commits into
master
Choose a base branch
from
cisc/jina-embeddings-v3
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+245
−24
Open
Changes from 13 commits
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
6303ea2
initial jina-embeddings-v3 support
CISC ba51f89
initial jina-embeddings-v3 support
CISC 4ac1380
initial jina-embeddings-v3 support
CISC 1274c8c
fix vocab parsing with only tokenizer.json
CISC 65a37fa
set mask token lstrip attribute
CISC f2d876a
additional unk_token_id fallback just in case [no ci]
CISC b17e981
revert vocab_size() change [no ci]
CISC 4046701
Merge branch 'master' into cisc/jina-embeddings-v3
CISC f5d0305
merge tensor loading into general bert
CISC 3862d95
rope
CISC 8ab8d36
Merge branch 'master' into cisc/jina-embeddings-v3
CISC 9a39ccb
add lora embedding and loading (non-functional)
CISC 966d0e0
export separate lora ggufs instead
CISC bea6d06
add adapter metadata api
CISC 9b67ea2
use std::string
CISC File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I cannot comment about these changes, it seems a bit hacky in some parts.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not too hacky I think, but necessary to get the job done as supporting this in
convert_lora_to_gguf.py
would get hackier.@compilade Maybe you have some input on this?
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@CISC I agree that making multiple LoRAs out of a single model might be hackier with
convert_lora_to_gguf.py
.But if there are standalone LoRAs for that model (in separate repositories) though, that would be in scope of
convert_lora_to_gguf.py
. The fieldlora_adaptations
will be read from the base model when converting a standalone LoRA, and so it will probably still produce the extra LoRAs (which will be broken becauseself.set_type
andself.set_gguf_parameters
are overridden byLoraModel
). It's likely possible to avoid breaking this use-case, but I'm not quite sure how right now.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good point, though I'm reasonably sure there are no standalone LoRAs of this model.