Skip to content

Commit b197797

Browse files
committed
server : be explicit about the pooling type in the tests
ggml-ci
1 parent 9a648a6 commit b197797

File tree

2 files changed

+9
-3
lines changed

2 files changed

+9
-3
lines changed

examples/server/tests/unit/test_embedding.py

Lines changed: 8 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,6 +14,7 @@ def create_server():
1414

1515
def test_embedding_single():
1616
global server
17+
server.pooling = 'last'
1718
server.start()
1819
res = server.make_request("POST", "/embeddings", data={
1920
"input": "I believe the meaning of life is",
@@ -29,6 +30,7 @@ def test_embedding_single():
2930

3031
def test_embedding_multiple():
3132
global server
33+
server.pooling = 'last'
3234
server.start()
3335
res = server.make_request("POST", "/embeddings", data={
3436
"input": [
@@ -46,7 +48,8 @@ def test_embedding_multiple():
4648

4749

4850
def test_embedding_pooling_none():
49-
server = ServerPreset.bert_bge_small(pooling = 'none')
51+
global server
52+
server.pooling = 'none'
5053
server.start()
5154
res = server.make_request("POST", "/embeddings", data={
5255
"input": "hello hello hello",
@@ -59,6 +62,7 @@ def test_embedding_pooling_none():
5962

6063
def test_embedding_openai_library_single():
6164
global server
65+
server.pooling = 'last'
6266
server.start()
6367
client = OpenAI(api_key="dummy", base_url=f"http://{server.server_host}:{server.server_port}")
6468
res = client.embeddings.create(model="text-embedding-3-small", input="I believe the meaning of life is")
@@ -68,6 +72,7 @@ def test_embedding_openai_library_single():
6872

6973
def test_embedding_openai_library_multiple():
7074
global server
75+
server.pooling = 'last'
7176
server.start()
7277
client = OpenAI(api_key="dummy", base_url=f"http://{server.server_host}:{server.server_port}")
7378
res = client.embeddings.create(model="text-embedding-3-small", input=[
@@ -83,6 +88,7 @@ def test_embedding_openai_library_multiple():
8388

8489
def test_embedding_error_prompt_too_long():
8590
global server
91+
server.pooling = 'last'
8692
server.start()
8793
res = server.make_request("POST", "/embeddings", data={
8894
"input": "This is a test " * 512,
@@ -92,6 +98,7 @@ def test_embedding_error_prompt_too_long():
9298

9399

94100
def test_same_prompt_give_same_result():
101+
server.pooling = 'last'
95102
server.start()
96103
res = server.make_request("POST", "/embeddings", data={
97104
"input": [

examples/server/tests/utils.py

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -275,7 +275,7 @@ def tinyllama2() -> ServerProcess:
275275
return server
276276

277277
@staticmethod
278-
def bert_bge_small(pooling = 'last') -> ServerProcess:
278+
def bert_bge_small() -> ServerProcess:
279279
server = ServerProcess()
280280
server.model_hf_repo = "ggml-org/models"
281281
server.model_hf_file = "bert-bge-small/ggml-model-f16.gguf"
@@ -286,7 +286,6 @@ def bert_bge_small(pooling = 'last') -> ServerProcess:
286286
server.n_slots = 2
287287
server.seed = 42
288288
server.server_embeddings = True
289-
server.pooling = pooling
290289
return server
291290

292291
@staticmethod

0 commit comments

Comments
 (0)