Skip to content

Commit 8cd7b3a

Browse files
committed
ggml : ggml_set_rows update comment + better index name
1 parent 2c8719b commit 8cd7b3a

File tree

2 files changed

+6
-4
lines changed

2 files changed

+6
-4
lines changed

ggml/include/ggml.h

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1383,6 +1383,8 @@ extern "C" {
13831383
// b TS [n_embd, n_rows, ne02, ne03] | ne02 == ne2, ne03 == ne3
13841384
// c I64 [n_rows, ne11, ne12, 1] | c[i] in [0, ne1)
13851385
//
1386+
// undefined behavior if destination rows overlap
1387+
//
13861388
// broadcast:
13871389
// ne2 % ne11 == 0
13881390
// ne3 % ne12 == 0

ggml/src/ggml-cpu/ops.cpp

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -4558,13 +4558,13 @@ static void ggml_compute_forward_set_rows_f32(
45584558
const int64_t i11 = i02%ne11;
45594559
const int64_t i10 = i;
45604560

4561-
const int64_t i01 = *(int64_t *) ((char *) src1->data + i10*nb10 + i11*nb11 + i12*nb12);
4561+
const int64_t i1 = *(int64_t *) ((char *) src1->data + i10*nb10 + i11*nb11 + i12*nb12);
45624562

4563-
GGML_ASSERT(i01 >= 0 && i01 < ne1);
4563+
GGML_ASSERT(i1 >= 0 && i1 < ne1);
45644564

45654565
from_float(
4566-
(const float *) ((char *) src0->data + i*nb01 + i02*nb02 + i03*nb03),
4567-
((char *) dst->data + i01*nb1 + i02*nb2 + i03*nb3), nc);
4566+
(const float *) ((char *) src0->data + i*nb01 + i02*nb02 + i03*nb03),
4567+
((char *) dst->data + i1*nb1 + i02*nb2 + i03*nb3), nc);
45684568
}
45694569
}
45704570
}

0 commit comments

Comments
 (0)