Skip to content

Commit 458f2a5

Browse files
committed
model : better llama_model::create_model() signature
ggml-ci
1 parent f584750 commit 458f2a5

File tree

3 files changed

+3
-3
lines changed

3 files changed

+3
-3
lines changed

src/llama-context.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -181,7 +181,7 @@ llama_context::llama_context(
181181
/*.type_v =*/ params.type_v,
182182
};
183183

184-
memory.reset(model.create_memory(cparams, params_mem));
184+
memory.reset(model.create_memory(params_mem, cparams));
185185
}
186186

187187
// init backends

src/llama-model.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12815,7 +12815,7 @@ struct llm_build_bailingmoe : public llm_graph_context {
1281512815
}
1281612816
};
1281712817

12818-
llama_memory_i * llama_model::create_memory(llama_cparams & cparams, const llama_memory_params & params) const {
12818+
llama_memory_i * llama_model::create_memory(const llama_memory_params & params, llama_cparams & cparams) const {
1281912819
llama_memory_i * res;
1282012820

1282112821
const bool offload = cparams.offload_kqv;

src/llama-model.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -397,7 +397,7 @@ struct llama_model {
397397

398398
// note: can mutate `cparams`
399399
// TODO: move this to new llm_arch_model_i interface
400-
llama_memory_i * create_memory(llama_cparams & cparams, const llama_memory_params & params) const;
400+
llama_memory_i * create_memory(const llama_memory_params & params, llama_cparams & cparams) const;
401401

402402
// TODO: move this to new llm_arch_model_i interface
403403
llm_graph_result_ptr build_graph(

0 commit comments

Comments
 (0)