Skip to content

Commit 3e1cb14

Browse files
committed
nix: clarify the meaning of "broken" and "badPlatforms"
1 parent 657d09f commit 3e1cb14

File tree

1 file changed

+11
-2
lines changed

1 file changed

+11
-2
lines changed

.devops/nix/package.nix

Lines changed: 11 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -178,7 +178,15 @@ effectiveStdenv.mkDerivation (
178178
};
179179

180180
meta = {
181-
broken = (useCuda && effectiveStdenv.isDarwin) || (useMetalKit && !effectiveStdenv.isDarwin);
181+
# Configurations we don't want even the CI to evaluate. Results in the
182+
# "unsupported platform" messages. This is mostly a no-op, because
183+
# cudaPackages would've refused to evaluate anyway.
184+
badPlatforms = optionals (useCuda || useOpenCL) lib.platforms.darwin;
185+
186+
# Configurations that are known to result in build failures. Can be
187+
# overridden by importing Nixpkgs with `allowBroken = true`.
188+
broken = (useMetalKit && !effectiveStdenv.isDarwin);
189+
182190
description = "Inference of LLaMA model in pure C/C++${descriptionSuffix}";
183191
homepage = "https://github.com/ggerganov/llama.cpp/";
184192
license = lib.licenses.mit;
@@ -201,7 +209,8 @@ effectiveStdenv.mkDerivation (
201209
SomeoneSerge
202210
];
203211

204-
platforms = lib.platforms.unix;
212+
# Extend `badPlatforms` instead
213+
platforms = lib.platforms.all;
205214
};
206215
}
207216
)

0 commit comments

Comments
 (0)