metal: add the missing msg_send![view, retain] call within from_view (#2976)

jinleili · web-flow · commit a08ea2a255f4 · 2022-08-20T07:14:57.000-07:00
* metal: add the missing `msg_send![view, retain]` call within `from_view`

* Update CHANGELOG
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -68,6 +68,9 @@ the same every time it is rendered, we now warn if it is missing.
 - Fix compilation errors when using wgpu-core in isolation while targetting `wasm32-unknown-unknown` by @Seamooo in [#2922](https://github.com/gfx-rs/wgpu/pull/2922)
 - Fixed opening of RenderDoc library by @abuffseagull in [#2930](https://github.com/gfx-rs/wgpu/pull/2930)
 
+#### Metal
+- Add the missing `msg_send![view, retain]` call within `from_view` by @jinleili in [#2976](https://github.com/gfx-rs/wgpu/pull/2976)
+
 ### Changes
 
 #### General
diff --git a/wgpu-hal/src/metal/surface.rs b/wgpu-hal/src/metal/surface.rs
@@ -86,6 +86,7 @@ impl super::Surface {
         let render_layer =
             mem::transmute::<_, &mtl::MetalLayerRef>(Self::get_metal_layer(view, delegate))
                 .to_owned();
+        let _: *mut c_void = msg_send![view, retain];
         Self::new(NonNull::new(view), render_layer)
     }
 

Original file line number	Diff line number	Diff line change
`@@ -86,6 +86,7 @@ impl super::Surface {`
`86`	`86`	`let render_layer =`
`87`	`87`	`mem::transmute::<_, &mtl::MetalLayerRef>(Self::get_metal_layer(view, delegate))`
`88`	`88`	`.to_owned();`
	`89`	`+ let _: *mut c_void = msg_send![view, retain];`
`89`	`90`	`Self::new(NonNull::new(view), render_layer)`
`90`	`91`	`}`
`91`	`92`