Skip to content

Commit 8981058

Browse files
jimblandycwfitzgerald
authored andcommitted
[core] In LifetimeTrackers triage code, use more specific names.
Rename `LifetimeTracker::triage_resources`'s `resources_map` argument to `suspected_resources`, since this always points to a field of `LifetimeTracker::suspected_resources`. In the various `triage_suspected_foo` functions, name the map `suspected_foos`.
1 parent 8d73e5a commit 8981058

File tree

1 file changed

+26
-26
lines changed

1 file changed

+26
-26
lines changed

wgpu-core/src/device/life.rs

Lines changed: 26 additions & 26 deletions
Original file line numberDiff line numberDiff line change
@@ -468,11 +468,11 @@ impl<A: HalApi> LifetimeTracker<A> {
468468
}
469469

470470
impl<A: HalApi> LifetimeTracker<A> {
471-
/// Remove abandoned resources from `resources_map` and return them.
471+
/// Remove abandoned resources from `suspected_resources` and return them.
472472
///
473-
/// Consult `trackers` to see which resources in `resources_map` are
474-
/// abandoned (that is, referenced only by `resources_map` and `trackers`
475-
/// itself) and remove them from `resources_map`.
473+
/// Consult `trackers` to see which resources in `suspected_resources` are
474+
/// abandoned (that is, referenced only by `suspected_resources` and
475+
/// `trackers` itself) and remove them from `suspected_resources`.
476476
///
477477
/// If the abandoned resources are in use by a command submission still in
478478
/// flight, as listed in `active`, add them to that submission's
@@ -483,7 +483,7 @@ impl<A: HalApi> LifetimeTracker<A> {
483483
///
484484
/// Return a vector of all the abandoned resources that were removed.
485485
fn triage_resources<R>(
486-
resources_map: &mut FastHashMap<TrackerIndex, Arc<R>>,
486+
suspected_resources: &mut FastHashMap<TrackerIndex, Arc<R>>,
487487
active: &mut [ActiveSubmission<A>],
488488
trackers: &mut impl ResourceTracker,
489489
get_resource_map: impl Fn(&mut ResourceMaps<A>) -> &mut FastHashMap<TrackerIndex, Arc<R>>,
@@ -492,7 +492,7 @@ impl<A: HalApi> LifetimeTracker<A> {
492492
R: Resource,
493493
{
494494
let mut removed_resources = Vec::new();
495-
resources_map.retain(|&index, resource| {
495+
suspected_resources.retain(|&index, resource| {
496496
if !trackers.remove_abandoned(index) {
497497
return true;
498498
}
@@ -516,9 +516,9 @@ impl<A: HalApi> LifetimeTracker<A> {
516516

517517
fn triage_suspected_render_bundles(&mut self, trackers: &Mutex<Tracker<A>>) -> &mut Self {
518518
let mut trackers = trackers.lock();
519-
let resource_map = &mut self.suspected_resources.render_bundles;
519+
let suspected_render_bundles = &mut self.suspected_resources.render_bundles;
520520
let mut removed_resources = Self::triage_resources(
521-
resource_map,
521+
suspected_render_bundles,
522522
self.active.as_mut_slice(),
523523
&mut trackers.bundles,
524524
|maps| &mut maps.render_bundles,
@@ -555,14 +555,14 @@ impl<A: HalApi> LifetimeTracker<A> {
555555

556556
fn triage_suspected_bind_groups(&mut self, trackers: &Mutex<Tracker<A>>) -> &mut Self {
557557
let mut trackers = trackers.lock();
558-
let resource_map = &mut self.suspected_resources.bind_groups;
559-
let mut removed_resource = Self::triage_resources(
560-
resource_map,
558+
let suspected_bind_groups = &mut self.suspected_resources.bind_groups;
559+
let mut removed_resources = Self::triage_resources(
560+
suspected_bind_groups,
561561
self.active.as_mut_slice(),
562562
&mut trackers.bind_groups,
563563
|maps| &mut maps.bind_groups,
564564
);
565-
removed_resource.drain(..).for_each(|bind_group| {
565+
removed_resources.drain(..).for_each(|bind_group| {
566566
for v in bind_group.used.buffers.drain_resources() {
567567
self.suspected_resources
568568
.buffers
@@ -594,9 +594,9 @@ impl<A: HalApi> LifetimeTracker<A> {
594594

595595
fn triage_suspected_texture_views(&mut self, trackers: &Mutex<Tracker<A>>) -> &mut Self {
596596
let mut trackers = trackers.lock();
597-
let resource_map = &mut self.suspected_resources.texture_views;
597+
let suspected_texture_views = &mut self.suspected_resources.texture_views;
598598
Self::triage_resources(
599-
resource_map,
599+
suspected_texture_views,
600600
self.active.as_mut_slice(),
601601
&mut trackers.views,
602602
|maps| &mut maps.texture_views,
@@ -612,9 +612,9 @@ impl<A: HalApi> LifetimeTracker<A> {
612612

613613
fn triage_suspected_textures(&mut self, trackers: &Mutex<Tracker<A>>) -> &mut Self {
614614
let mut trackers = trackers.lock();
615-
let resource_map = &mut self.suspected_resources.textures;
615+
let suspected_textures = &mut self.suspected_resources.textures;
616616
Self::triage_resources(
617-
resource_map,
617+
suspected_textures,
618618
self.active.as_mut_slice(),
619619
&mut trackers.textures,
620620
|maps| &mut maps.textures,
@@ -636,9 +636,9 @@ impl<A: HalApi> LifetimeTracker<A> {
636636

637637
fn triage_suspected_samplers(&mut self, trackers: &Mutex<Tracker<A>>) -> &mut Self {
638638
let mut trackers = trackers.lock();
639-
let resource_map = &mut self.suspected_resources.samplers;
639+
let suspected_samplers = &mut self.suspected_resources.samplers;
640640
Self::triage_resources(
641-
resource_map,
641+
suspected_samplers,
642642
self.active.as_mut_slice(),
643643
&mut trackers.samplers,
644644
|maps| &mut maps.samplers,
@@ -648,9 +648,9 @@ impl<A: HalApi> LifetimeTracker<A> {
648648

649649
fn triage_suspected_buffers(&mut self, trackers: &Mutex<Tracker<A>>) -> &mut Self {
650650
let mut trackers = trackers.lock();
651-
let resource_map = &mut self.suspected_resources.buffers;
651+
let suspected_buffers = &mut self.suspected_resources.buffers;
652652
Self::triage_resources(
653-
resource_map,
653+
suspected_buffers,
654654
self.active.as_mut_slice(),
655655
&mut trackers.buffers,
656656
|maps| &mut maps.buffers,
@@ -692,9 +692,9 @@ impl<A: HalApi> LifetimeTracker<A> {
692692

693693
fn triage_suspected_compute_pipelines(&mut self, trackers: &Mutex<Tracker<A>>) -> &mut Self {
694694
let mut trackers = trackers.lock();
695-
let resource_map = &mut self.suspected_resources.compute_pipelines;
695+
let suspected_compute_pipelines = &mut self.suspected_resources.compute_pipelines;
696696
let mut removed_resources = Self::triage_resources(
697-
resource_map,
697+
suspected_compute_pipelines,
698698
self.active.as_mut_slice(),
699699
&mut trackers.compute_pipelines,
700700
|maps| &mut maps.compute_pipelines,
@@ -710,9 +710,9 @@ impl<A: HalApi> LifetimeTracker<A> {
710710

711711
fn triage_suspected_render_pipelines(&mut self, trackers: &Mutex<Tracker<A>>) -> &mut Self {
712712
let mut trackers = trackers.lock();
713-
let resource_map = &mut self.suspected_resources.render_pipelines;
713+
let suspected_render_pipelines = &mut self.suspected_resources.render_pipelines;
714714
let mut removed_resources = Self::triage_resources(
715-
resource_map,
715+
suspected_render_pipelines,
716716
self.active.as_mut_slice(),
717717
&mut trackers.render_pipelines,
718718
|maps| &mut maps.render_pipelines,
@@ -755,9 +755,9 @@ impl<A: HalApi> LifetimeTracker<A> {
755755

756756
fn triage_suspected_query_sets(&mut self, trackers: &Mutex<Tracker<A>>) -> &mut Self {
757757
let mut trackers = trackers.lock();
758-
let resource_map = &mut self.suspected_resources.query_sets;
758+
let suspected_query_sets = &mut self.suspected_resources.query_sets;
759759
Self::triage_resources(
760-
resource_map,
760+
suspected_query_sets,
761761
self.active.as_mut_slice(),
762762
&mut trackers.query_sets,
763763
|maps| &mut maps.query_sets,

0 commit comments

Comments
 (0)