From a478472ec904fa4d63f82bd1f3d4f9e8b628d663 Mon Sep 17 00:00:00 2001 From: Ryan Albrecht Date: Sat, 12 Jul 2025 14:24:29 -0700 Subject: [PATCH] chore: Remove unneeded references to DeprecatedAsyncComponent --- static/app/components/externalIssues/externalIssueForm.tsx | 1 - static/app/components/externalIssues/ticketRuleModal.tsx | 4 ++-- static/app/views/admin/installWizard/index.tsx | 2 +- static/app/views/app/index.tsx | 6 +----- 4 files changed, 4 insertions(+), 9 deletions(-) diff --git a/static/app/components/externalIssues/externalIssueForm.tsx b/static/app/components/externalIssues/externalIssueForm.tsx index 21618edfc55988..55e15acb4d3720 100644 --- a/static/app/components/externalIssues/externalIssueForm.tsx +++ b/static/app/components/externalIssues/externalIssueForm.tsx @@ -157,7 +157,6 @@ export default function ExternalIssueForm({ setIsDynamicallyRefetching(false); }, error: (err: any) => { - // This behavior comes from the DeprecatedAsyncComponent if (err?.responseText) { Sentry.addBreadcrumb({ message: err.responseText, diff --git a/static/app/components/externalIssues/ticketRuleModal.tsx b/static/app/components/externalIssues/ticketRuleModal.tsx index 33af6eaff291bc..f175c151eb3a93 100644 --- a/static/app/components/externalIssues/ticketRuleModal.tsx +++ b/static/app/components/externalIssues/ticketRuleModal.tsx @@ -183,12 +183,12 @@ export default function TicketRuleModal({ integrationId: instance.integration, query: initialConfigQuery, }), - existingData => (data ? data : existingData) + (existingData: IntegrationIssueConfig | undefined) => + data ? data : existingData ); setIsDynamicallyRefetching(false); }, error: (err: any) => { - // This behavior comes from the DeprecatedAsyncComponent if (err?.responseText) { Sentry.addBreadcrumb({ message: err.responseText, diff --git a/static/app/views/admin/installWizard/index.tsx b/static/app/views/admin/installWizard/index.tsx index 4a072e7c88da9b..332c106a4319b2 100644 --- a/static/app/views/admin/installWizard/index.tsx +++ b/static/app/views/admin/installWizard/index.tsx @@ -14,7 +14,7 @@ import {useApiQuery} from 'sentry/utils/queryClient'; import type {Field} from 'sentry/views/admin/options'; import {getForm, getOptionDefault, getOptionField} from 'sentry/views/admin/options'; -export type InstallWizardProps = { +type InstallWizardProps = { onConfigured: () => void; }; diff --git a/static/app/views/app/index.tsx b/static/app/views/app/index.tsx index 051ee3ecb5a071..a5a33a0f77641c 100644 --- a/static/app/views/app/index.tsx +++ b/static/app/views/app/index.tsx @@ -34,7 +34,6 @@ import {GlobalFeedbackForm} from 'sentry/utils/useFeedbackForm'; import {useHotkeys} from 'sentry/utils/useHotkeys'; import {useLocation} from 'sentry/utils/useLocation'; import {useUser} from 'sentry/utils/useUser'; -import type {InstallWizardProps} from 'sentry/views/admin/installWizard'; import {AsyncSDKIntegrationContextProvider} from 'sentry/views/app/asyncSDKIntegrationProvider'; import LastKnownRouteContextProvider from 'sentry/views/lastKnownRouteContextProvider'; import {OrganizationContextProvider} from 'sentry/views/organizationContext'; @@ -44,10 +43,7 @@ type Props = { children: React.ReactNode; } & RouteComponentProps<{orgId?: string}>; -const InstallWizard = lazy( - () => import('sentry/views/admin/installWizard') - // TODO(TS): DeprecatedAsyncComponent prop types are doing something weird -) as unknown as React.ComponentType; +const InstallWizard = lazy(() => import('sentry/views/admin/installWizard')); const NewsletterConsent = lazy(() => import('sentry/views/newsletterConsent')); const BeaconConsent = lazy(() => import('sentry/views/beaconConsent'));