feat(issues-trace-meta): Removing redundant /events-trace-meta/ requests (#94978)

...From issue details trace previews.

---------

Co-authored-by: Abdullah Khan <abdullahkhan@PG9Y57YDXQ.local>

Author: Abdkhan14

static/app/components/events/interfaces/performance/eventTraceView.tsx

@@ -20,7 +20,6 @@ import {IssuesTraceWaterfall} from 'sentry/views/performance/newTraceDetails/iss
 import {getTraceLinkForIssue} from 'sentry/views/performance/newTraceDetails/issuesTraceWaterfallOverlay';
 import {useIssuesTraceTree} from 'sentry/views/performance/newTraceDetails/traceApi/useIssuesTraceTree';
 import {useTrace} from 'sentry/views/performance/newTraceDetails/traceApi/useTrace';
-import {useTraceMeta} from 'sentry/views/performance/newTraceDetails/traceApi/useTraceMeta';
 import {useTraceRootEvent} from 'sentry/views/performance/newTraceDetails/traceApi/useTraceRootEvent';
 import {TraceViewSources} from 'sentry/views/performance/newTraceDetails/traceHeader/breadcrumbs';
 import {TraceHeaderComponents} from 'sentry/views/performance/newTraceDetails/traceHeader/styles';
@@ -71,8 +70,7 @@ function EventTraceViewInner({event, organization, traceId}: EventTraceViewInner
   const params = useTraceQueryParams({
     timestamp,
   });
-  const meta = useTraceMeta([{traceSlug: traceId, timestamp}]);
-  const tree = useIssuesTraceTree({trace, meta, replay: null});
+  const tree = useIssuesTraceTree({trace, replay: null});
 
   const rootEventResults = useTraceRootEvent({
     tree,
@@ -97,7 +95,6 @@ function EventTraceViewInner({event, organization, traceId}: EventTraceViewInner
         rootEventResults={rootEventResults}
         organization={organization}
         traceEventView={traceEventView}
-        meta={meta}
         source="issues"
         replay={null}
         event={event}

static/app/components/events/interfaces/performance/spanEvidenceTraceView.tsx

@@ -6,7 +6,6 @@ import type {Event} from 'sentry/types/event';
 import type {Organization} from 'sentry/types/organization';
 import {useIssuesTraceTree} from 'sentry/views/performance/newTraceDetails/traceApi/useIssuesTraceTree';
 import {useTrace} from 'sentry/views/performance/newTraceDetails/traceApi/useTrace';
-import {useTraceMeta} from 'sentry/views/performance/newTraceDetails/traceApi/useTraceMeta';
 import {useTraceRootEvent} from 'sentry/views/performance/newTraceDetails/traceApi/useTraceRootEvent';
 import {
   getInitialTracePreferences,
@@ -82,8 +81,7 @@ function SpanEvidenceTraceViewImpl({
     traceSlug: traceId,
     limit: 10000,
   });
-  const meta = useTraceMeta([{traceSlug: traceId, timestamp}]);
-  const tree = useIssuesTraceTree({trace, meta, replay: null});
+  const tree = useIssuesTraceTree({trace, replay: null});
 
   const rootEventResults = useTraceRootEvent({
     tree,
@@ -110,7 +108,6 @@ function SpanEvidenceTraceViewImpl({
           rootEventResults={rootEventResults}
           organization={organization}
           traceEventView={traceEventView}
-          meta={meta}
           source="issues"
           replay={null}
           event={event}

static/app/views/performance/newTraceDetails/issuesTraceWaterfall.tsx

@@ -52,7 +52,7 @@ import {useTraceTimelineChangeSync} from './useTraceTimelineChangeSync';
 const noopTraceSearch = () => {};
 
 interface IssuesTraceWaterfallProps
-  extends Omit<TraceWaterfallProps, 'tree' | 'traceWaterfallScrollHandlers'> {
+  extends Omit<TraceWaterfallProps, 'tree' | 'traceWaterfallScrollHandlers' | 'meta'> {
   event: Event;
   tree: IssuesTraceTree;
 }

static/app/views/performance/newTraceDetails/traceApi/useIssuesTraceTree.tsx

@@ -10,25 +10,20 @@ import type {TraceTree} from 'sentry/views/performance/newTraceDetails/traceMode
 import {useTraceState} from 'sentry/views/performance/newTraceDetails/traceState/traceStateProvider';
 import type {HydratedReplayRecord} from 'sentry/views/replays/types';
 
-import type {TraceMetaQueryResults} from './useTraceMeta';
 import {isEmptyTrace} from './utils';
 
 type UseTraceTreeParams = {
-  meta: TraceMetaQueryResults;
   replay: HydratedReplayRecord | null;
   trace: UseApiQueryResult<TraceTree.Trace | undefined, any>;
   traceSlug?: string;
 };
 
-function getTraceViewQueryStatus(
-  traceQueryStatus: QueryStatus,
-  traceMetaQueryStatus: QueryStatus
-): QueryStatus {
-  if (traceQueryStatus === 'error' || traceMetaQueryStatus === 'error') {
+function getTraceViewQueryStatus(traceQueryStatus: QueryStatus): QueryStatus {
+  if (traceQueryStatus === 'error') {
     return 'error';
   }
 
-  if (traceQueryStatus === 'pending' || traceMetaQueryStatus === 'pending') {
+  if (traceQueryStatus === 'pending') {
     return 'pending';
   }
 
@@ -37,7 +32,6 @@ function getTraceViewQueryStatus(
 
 export function useIssuesTraceTree({
   trace,
-  meta,
   replay,
   traceSlug,
 }: UseTraceTreeParams): IssuesTraceTree {
@@ -49,7 +43,7 @@ export function useIssuesTraceTree({
   const [tree, setTree] = useState<IssuesTraceTree>(IssuesTraceTree.Empty());
 
   useEffect(() => {
-    const status = getTraceViewQueryStatus(trace.status, meta.status);
+    const status = getTraceViewQueryStatus(trace.status);
 
     if (status === 'error') {
       setTree(t =>
@@ -82,9 +76,9 @@ export function useIssuesTraceTree({
       return;
     }
 
-    if (trace.data && meta.data) {
+    if (trace.data) {
       const newTree = IssuesTraceTree.FromTrace(trace.data, {
-        meta: meta.data,
+        meta: null,
         replay,
         preferences: traceState.preferences,
       });
@@ -95,17 +89,7 @@ export function useIssuesTraceTree({
     }
 
     // eslint-disable-next-line react-hooks/exhaustive-deps
-  }, [
-    api,
-    organization,
-    projects,
-    replay,
-    meta.status,
-    trace.status,
-    trace.data,
-    meta.data,
-    traceSlug,
-  ]);
+  }, [api, organization, projects, replay, trace.status, trace.data, traceSlug]);
 
   return tree;
 }