fix(detectors): Fix type error in report_metrics_for_detectors (#95386)

roggenkemper · web-flow · commit f13f8c7c1cba · 2025-07-14T11:29:30.000-07:00
Fixes SENTRY-FOR-SENTRY-600M
diff --git a/src/sentry/performance_issues/performance_detection.py b/src/sentry/performance_issues/performance_detection.py
@@ -532,7 +532,8 @@ def report_metrics_for_detectors(
 
     tags = event.get("tags", [])
     browser_name = next(
-        (tag[1] for tag in tags if tag[0] == "browser.name" and len(tag) == 2), None
+        (tag[1] for tag in tags if tag is not None and tag[0] == "browser.name" and len(tag) == 2),
+        None,
     )
     allowed_browser_name = "Other"
     if browser_name in [

Original file line number	Diff line number	Diff line change
`@@ -532,7 +532,8 @@ def report_metrics_for_detectors(`
`532`	`532`
`533`	`533`	`tags = event.get("tags", [])`
`534`	`534`	`browser_name = next(`
`535`		`- (tag[1] for tag in tags if tag[0] == "browser.name" and len(tag) == 2), None`
	`535`	`+ (tag[1] for tag in tags if tag is not None and tag[0] == "browser.name" and len(tag) == 2),`
	`536`	`+ None,`
`536`	`537`	`)`
`537`	`538`	`allowed_browser_name = "Other"`
`538`	`539`	`if browser_name in [`