fix(aci): Simplify metric detector snuba query types (#95606)

Author: scttcper

static/app/types/workflowEngine/detectors.tsx

@@ -125,7 +125,7 @@ type BaseDetector = Readonly<{
 export interface MetricDetector extends BaseDetector {
   readonly conditionGroup: DataConditionGroup | null;
   readonly config: MetricDetectorConfig;
-  readonly dataSources: SnubaQueryDataSource[];
+  readonly dataSources: [SnubaQueryDataSource];
   readonly type: 'metric_issue';
 }
 

static/app/views/detectors/components/details/metric/chart.tsx

@@ -10,10 +10,7 @@ interface MetricDetectorDetailsChartProps {
 
 export function MetricDetectorDetailsChart({detector}: MetricDetectorDetailsChartProps) {
   const dataSource = detector.dataSources[0];
-  const snubaQuery =
-    dataSource?.type === 'snuba_query_subscription'
-      ? dataSource.queryObj?.snubaQuery
-      : undefined;
+  const snubaQuery = dataSource.queryObj?.snubaQuery;
 
   if (!snubaQuery) {
     // Unlikely, helps narrow types

static/app/views/detectors/components/details/metric/detect.tsx

@@ -45,22 +45,7 @@ function SnubaQueryDetails({dataSource}: {dataSource: SnubaQueryDataSource}) {
 
 export function MetricDetectorDetailsDetect({detector}: MetricDetectorDetectProps) {
   const dataSource = detector.dataSources?.[0];
-  if (dataSource?.type === 'snuba_query_subscription') {
-    return <SnubaQueryDetails dataSource={dataSource} />;
-  }
-
-  return (
-    <Container>
-      <Flex direction="column" gap={space(0.5)}>
-        <Heading>{t('Query:')}</Heading>
-        <Query>
-          <Label>{t('visualize:')}</Label> <Value>placeholder</Value>
-          <Label>{t('where:')}</Label> <Value>placeholder</Value>
-        </Query>
-      </Flex>
-      <Heading>{t('Threshold:')}</Heading>
-    </Container>
-  );
+  return <SnubaQueryDetails dataSource={dataSource} />;
 }
 
 const Heading = styled('h4')`

static/app/views/detectors/components/forms/metric/metricDetectorChart.tsx

@@ -134,6 +134,8 @@ export function MetricDetectorChart({
           // Hide the maximum y-axis label to avoid showing arbitrary threshold values
           showMaxLabel: false,
         },
+        // Disable the y-axis grid lines
+        splitLine: {show: false},
       }}
       grid={{
         left: space(0.25),

static/app/views/detectors/components/forms/metric/metricFormData.tsx

@@ -440,33 +440,18 @@ export function metricSavedDetectorToFormData(
     throw new Error('Detector type mismatch');
   }
 
-  // Get the first data source (assuming metric detectors have one)
   const dataSource = detector.dataSources?.[0];
-
-  // Check if this is a snuba query data source
-  const snubaQuery =
-    dataSource?.type === 'snuba_query_subscription'
-      ? dataSource.queryObj?.snubaQuery
-      : undefined;
+  const snubaQuery = dataSource.queryObj?.snubaQuery;
 
   // Use the full aggregate string directly
   const aggregateFunction = snubaQuery?.aggregate || 'count()';
 
-  // Process conditions using the extracted function
   const conditionData = processDetectorConditions(detector);
 
   const dataset = snubaQuery?.dataset
     ? getDetectorDataset(snubaQuery.dataset, snubaQuery.eventTypes)
     : DetectorDataset.SPANS;
 
-  const metricDetectorConfig =
-    'detectionType' in detector.config
-      ? detector.config
-      : {
-          detectionType: 'static' as const,
-          thresholdPeriod: 1,
-        };
-
   return {
     // Core detector fields
     name: detector.name,
@@ -477,26 +462,26 @@ export function metricSavedDetectorToFormData(
     query: snubaQuery?.query || '',
     aggregateFunction,
     dataset,
-    interval: 60 * 60, // Default to 1 hour
+    interval: snubaQuery?.timeWindow ?? DEFAULT_THRESHOLD_METRIC_FORM_DATA.interval,
 
     // Priority level and condition fields from processed conditions
     ...conditionData,
-    kind: metricDetectorConfig.detectionType,
+    kind: detector.config.detectionType,
 
     // Condition fields - get comparison delta from detector config (already in seconds)
     conditionComparisonAgo:
-      (metricDetectorConfig.detectionType === 'percent'
-        ? metricDetectorConfig.comparisonDelta
+      (detector.config.detectionType === 'percent'
+        ? detector.config.comparisonDelta
         : null) || 3600,
 
     // Dynamic fields - extract from config for dynamic detectors
     sensitivity:
-      metricDetectorConfig.detectionType === 'dynamic'
-        ? metricDetectorConfig.sensitivity || AlertRuleSensitivity.LOW
+      detector.config.detectionType === 'dynamic'
+        ? detector.config.sensitivity || AlertRuleSensitivity.LOW
         : AlertRuleSensitivity.LOW,
     thresholdType:
-      metricDetectorConfig.detectionType === 'dynamic'
-        ? metricDetectorConfig.thresholdType || AlertRuleThresholdType.ABOVE
+      detector.config.detectionType === 'dynamic'
+        ? detector.config.thresholdType || AlertRuleThresholdType.ABOVE
         : AlertRuleThresholdType.ABOVE,
   };
 }