chore(aci): Remove MetricIssuePOC group type (#95685)

We're now creating groups with the real MetricIssue group type, so this
should be safe to remove. We may want to eventually remove the
registered group type but there are still issues in the db that
reference it, so we'll need to clean that up first.

---------

Co-authored-by: getsantry[bot] <66042841+getsantry[bot]@users.noreply.github.com>

Author: snigdhas

src/sentry/incidents/grouptype.py

@@ -8,7 +8,6 @@
 from sentry.incidents.metric_issue_detector import MetricIssueDetectorValidator
 from sentry.incidents.models.alert_rule import AlertRuleDetectionType, ComparisonDeltaChoices
 from sentry.incidents.utils.format_duration import format_duration_idiomatic
-from sentry.incidents.utils.metric_issue_poc import QUERY_AGGREGATION_DISPLAY
 from sentry.incidents.utils.types import QuerySubscriptionUpdate
 from sentry.integrations.metric_alerts import TEXT_COMPARISON_DELTA
 from sentry.issues.grouptype import GroupCategory, GroupType
@@ -28,6 +27,15 @@
 COMPARISON_DELTA_CHOICES: list[None | int] = [choice.value for choice in ComparisonDeltaChoices]
 COMPARISON_DELTA_CHOICES.append(None)
 
+QUERY_AGGREGATION_DISPLAY = {
+    "count()": "Number of events",
+    "count_unique(tags[sentry:user])": "Number of users affected",
+    "percentage(sessions_crashed, sessions)": "Crash free session rate",
+    "percentage(users_crashed, users)": "Crash free user rate",
+    "failure_rate()": "Failure rate",
+    "apdex()": "Apdex score",
+}
+
 
 @dataclass
 class MetricIssueEvidenceData(EvidenceData[float]):

src/sentry/incidents/subscription_processor.py

@@ -40,7 +40,6 @@
     TriggerStatus,
 )
 from sentry.incidents.tasks import handle_trigger_action
-from sentry.incidents.utils.metric_issue_poc import create_or_update_metric_issue
 from sentry.incidents.utils.process_update_helpers import (
     get_comparison_aggregation_value,
     get_crash_rate_alert_metrics_aggregation_value_helper,
@@ -779,12 +778,6 @@ def handle_trigger_actions(
                 metric_value=metric_value,
             )
 
-        if features.has("organizations:metric-issue-poc", self.alert_rule.organization):
-            create_or_update_metric_issue(
-                incident=incident,
-                metric_value=metric_value,
-            )
-
     def _schedule_trigger_action(
         self,
         action_id: int,

src/sentry/incidents/utils/metric_issue_poc.py

@@ -675,9 +675,10 @@ class FeedbackGroup(GroupType):
 
 @dataclass(frozen=True)
 class MetricIssuePOC(GroupType):
+    # DEPRECATED, use metric_issue (8001) instead
     type_id = 8002
     slug = "metric_issue_poc"
-    description = "Metric Issue POC"
+    description = "DEPRECATED Metric Issue POC"
     category = GroupCategory.METRIC_ALERT.value
     category_v2 = GroupCategory.METRIC.value
     default_priority = PriorityLevel.HIGH

src/sentry/issues/grouptype.py

@@ -1,4 +1,5 @@
 import logging
+from dataclasses import dataclass
 from datetime import datetime, timedelta
 from typing import Any
 
@@ -20,6 +21,24 @@
 logger = logging.getLogger(__name__)
 
 
+@dataclass
+class OpenPeriod:
+    start: datetime
+    end: datetime | None
+    duration: timedelta | None
+    is_open: bool
+    last_checked: datetime
+
+    def to_dict(self) -> dict[str, Any]:
+        return {
+            "start": self.start,
+            "end": self.end,
+            "duration": self.duration,
+            "isOpen": self.is_open,
+            "lastChecked": self.last_checked,
+        }
+
+
 class TsTzRange(models.Func):
     function = "TSTZRANGE"
     output_field = DateTimeRangeField()
@@ -99,12 +118,12 @@ def reopen_open_period(self) -> None:
 
 
 def get_last_checked_for_open_period(group: Group) -> datetime:
+    from sentry.incidents.grouptype import MetricIssue
     from sentry.incidents.models.alert_rule import AlertRule
-    from sentry.issues.grouptype import MetricIssuePOC
 
     event = group.get_latest_event()
     last_checked = group.last_seen
-    if event and group.type == MetricIssuePOC.type_id:
+    if event and group.type == MetricIssue.type_id:
         alert_rule_id = event.data.get("contexts", {}).get("metric_alert", {}).get("alert_rule_id")
         if alert_rule_id:
             try:
@@ -124,7 +143,6 @@ def get_open_periods_for_group(
     offset: int | None = None,
     limit: int | None = None,
 ) -> list[Any]:
-    from sentry.incidents.utils.metric_issue_poc import OpenPeriod
 
     if not features.has("organizations:issue-open-periods", group.organization):
         return []

src/sentry/models/groupopenperiod.py

@@ -119,14 +119,14 @@ def batch_features_override(
             results = {}
             for project in projects:
                 result_key = f"project:{project.id}"
-                proj_results = {**feature_results, **default_feature_results[result_key]}
+                proj_results = {**feature_results, **default_feature_results.get(result_key, {})}
                 results[result_key] = {
                     name: val for name, val in proj_results.items() if name.startswith("project")
                 }
             return results
         elif organization:
             result_key = f"organization:{organization.id}"
-            results_for_org = {**feature_results, **default_feature_results[result_key]}
+            results_for_org = {**feature_results, **default_feature_results.get(result_key, {})}
             results_for_org = {
                 name: resolve_feature_name_value_for_org(organization, val)
                 for name, val in results_for_org.items()