🔧 chore(aci): gate actions task so it doesn't fire for metric issues (#95738)

Author: iamrajjoshi

src/sentry/digests/notifications.py

@@ -5,6 +5,8 @@
 from collections.abc import Mapping, Sequence
 from typing import Any, NamedTuple, TypeAlias
 
+import sentry_sdk
+
 from sentry import features, tsdb
 from sentry.digests.types import IdentifierKey, Notification, Record, RecordWithRuleObjects
 from sentry.eventstore.models import Event
@@ -73,13 +75,16 @@ def event_to_record(
     if not rules:
         logger.warning("Creating record for %s that does not contain any rules!", event)
 
+    # TODO(iamrajjoshi): The typing on this function is wrong, the type should be GroupEvent
+    # TODO(iamrajjoshi): Creating a PR to fix this
+    assert event.group is not None
     rule_ids = []
     identifier_key = IdentifierKey.RULE
     if features.has("organizations:workflow-engine-ui-links", event.organization):
         identifier_key = IdentifierKey.WORKFLOW
         for rule in rules:
             rule_ids.append(int(get_key_from_rule_data(rule, "workflow_id")))
-    elif should_fire_workflow_actions(event.organization):
+    elif should_fire_workflow_actions(event.organization, event.group.type):
         for rule in rules:
             rule_ids.append(int(get_key_from_rule_data(rule, "legacy_rule_id")))
     else:
@@ -168,7 +173,6 @@ def _build_digest_impl(
 
 
 def get_rules_from_workflows(project: Project, workflow_ids: set[int]) -> dict[int, Rule]:
-    from sentry.notifications.notification_action.utils import should_fire_workflow_actions
 
     rules: dict[int, Rule] = {}
     if not workflow_ids:
@@ -223,15 +227,20 @@ def get_rules_from_workflows(project: Project, workflow_ids: set[int]) -> dict[i
 
             assert rule.project_id == project.id, "Rule must belong to Project"
 
-            if should_fire_workflow_actions(project.organization):
+            try:
                 rule.data["actions"][0]["legacy_rule_id"] = rule.id
+            except KeyError:
+                # This shouldn't happen, but isn't a deal breaker if it does
+                sentry_sdk.capture_exception(
+                    Exception(f"Rule {rule.id} does not have a legacy_rule_id"),
+                    level="warning",
+                )
 
             rules[workflow_id] = rule
     return rules
 
 
 def build_digest(project: Project, records: Sequence[Record]) -> DigestInfo:
-    from sentry.notifications.notification_action.utils import should_fire_workflow_actions
 
     if not records:
         return DigestInfo({}, {}, {})
@@ -259,9 +268,15 @@ def build_digest(project: Project, records: Sequence[Record]) -> DigestInfo:
     group_ids = list(groups)
     rules = Rule.objects.in_bulk(rule_ids)
 
-    if should_fire_workflow_actions(project.organization):
-        for rule in rules.values():
+    for rule in rules.values():
+        try:
             rule.data["actions"][0]["legacy_rule_id"] = rule.id
+        except KeyError:
+            # This shouldn't happen, but isn't a deal breaker if it does
+            sentry_sdk.capture_exception(
+                Exception(f"Rule {rule.id} does not have a legacy_rule_id"),
+                level="warning",
+            )
 
     rules.update(get_rules_from_workflows(project, workflow_ids))
 

src/sentry/incidents/action_handlers.py

@@ -25,6 +25,7 @@
     DetailedIncidentSerializerResponse,
     IncidentSerializer,
 )
+from sentry.incidents.grouptype import MetricIssue
 from sentry.incidents.models.alert_rule import (
     AlertRuleDetectionType,
     AlertRuleThresholdType,
@@ -581,7 +582,7 @@ def generate_incident_trigger_email_context(
             ),
             query=urlencode(alert_link_params),
         )
-    elif should_fire_workflow_actions(organization):
+    elif should_fire_workflow_actions(organization, MetricIssue.type_id):
         # lookup the incident_id from the open_period_identifier
         try:
             incident_group_open_period = IncidentGroupOpenPeriod.objects.get(

src/sentry/integrations/discord/message_builder/issues.py

@@ -61,7 +61,7 @@ def build(self, notification_uuid: str | None = None) -> dict[str, object]:
             rule_environment_id = self.rules[0].environment_id
             if features.has("organizations:workflow-engine-ui-links", self.group.organization):
                 rule_id = int(get_key_from_rule_data(self.rules[0], "workflow_id"))
-            elif should_fire_workflow_actions(self.group.organization):
+            elif should_fire_workflow_actions(self.group.organization, self.group.type):
                 rule_id = int(get_key_from_rule_data(self.rules[0], "legacy_rule_id"))
             else:
                 rule_id = self.rules[0].id

src/sentry/integrations/messaging/message_builder.py

@@ -107,10 +107,10 @@ def fetch_environment_name(rule_env: int) -> str | None:
 
 
 def get_rule_environment_param_from_rule(
-    rule_id: int, rule_environment_id: int | None, organization: Organization
+    rule_id: int, rule_environment_id: int | None, organization: Organization, type_id: int
 ) -> dict[str, str]:
     params = {}
-    if should_fire_workflow_actions(organization):
+    if should_fire_workflow_actions(organization, type_id):
         if (
             rule_environment_id is not None
             and (environment_name := fetch_environment_name(rule_environment_id)) is not None
@@ -147,7 +147,9 @@ def get_title_link(
     # add in rule id if we have it
     if rule_id:
         other_params.update(
-            get_rule_environment_param_from_rule(rule_id, rule_environment_id, group.organization)
+            get_rule_environment_param_from_rule(
+                rule_id, rule_environment_id, group.organization, group.type
+            )
         )
         # hard code for issue alerts
         other_params["alert_rule_id"] = str(rule_id)
@@ -270,7 +272,7 @@ def build_attachment_replay_link(
 def build_rule_url(rule: Any, group: Group, project: Project) -> str:
     org_slug = group.organization.slug
     project_slug = project.slug
-    if should_fire_workflow_actions(group.organization):
+    if should_fire_workflow_actions(group.organization, group.type):
         rule_id = get_key_from_rule_data(rule, "legacy_rule_id")
         rule_url = f"/organizations/{org_slug}/alerts/rules/{project_slug}/{rule_id}/details/"
     else:

src/sentry/integrations/metric_alerts.py

@@ -222,7 +222,10 @@ def incident_attachment_info(
     if notification_uuid:
         title_link_params["notification_uuid"] = notification_uuid
 
-    if should_fire_workflow_actions(organization):
+    from sentry.incidents.grouptype import MetricIssue
+
+    # TODO(iamrajjoshi): This will need to be updated once we plan out Metric Alerts rollout
+    if should_fire_workflow_actions(organization, MetricIssue.type_id):
         try:
             alert_rule_id = AlertRuleDetector.objects.values_list("alert_rule_id", flat=True).get(
                 detector_id=alert_context.action_identifier_id

src/sentry/integrations/opsgenie/client.py

@@ -59,7 +59,7 @@ def _get_rule_urls(self, group, rules):
         rule_urls = []
         for rule in rules:
             rule_id = rule.id
-            if should_fire_workflow_actions(organization):
+            if should_fire_workflow_actions(organization, group.type):
                 rule_id = get_key_from_rule_data(rule, "legacy_rule_id")
 
             path = f"/organizations/{organization.slug}/alerts/rules/{group.project.slug}/{rule_id}/details/"

src/sentry/integrations/slack/actions/notification.py

@@ -479,7 +479,7 @@ def send_notification_noa(event: GroupEvent, futures: Sequence[RuleFuture]) -> N
             },
             skip_internal=False,
         )
-        if should_fire_workflow_actions(self.project.organization):
+        if should_fire_workflow_actions(self.project.organization, event.group.type):
             yield self.future(send_notification_noa, key=key)
         else:
             yield self.future(send_notification, key=key)

src/sentry/integrations/slack/message_builder/issues.py

@@ -616,7 +616,7 @@ def build(self, notification_uuid: str | None = None) -> SlackBlock:
         if self.rules:
             if features.has("organizations:workflow-engine-ui-links", self.group.organization):
                 rule_id = int(get_key_from_rule_data(self.rules[0], "workflow_id"))
-            elif should_fire_workflow_actions(self.group.organization):
+            elif should_fire_workflow_actions(self.group.organization, self.group.type):
                 rule_id = int(get_key_from_rule_data(self.rules[0], "legacy_rule_id"))
             else:
                 rule_id = self.rules[0].id

src/sentry/integrations/slack/service.py

@@ -248,7 +248,9 @@ def _notify_all_threads_for_activity(
             parent_notifications: Generator[
                 NotificationActionNotificationMessage | IssueAlertNotificationMessage
             ]
-            will_fire_workflow_actions = should_fire_workflow_actions(group.organization)
+            will_fire_workflow_actions = should_fire_workflow_actions(
+                group.organization, group.type
+            )
             if group.issue_category == GroupCategory.UPTIME:
                 use_open_period_start = True
                 open_period_start = open_period_start_for_group(group)

src/sentry/integrations/slack/utils/notifications.py

@@ -15,6 +15,7 @@
 from sentry.incidents.charts import build_metric_alert_chart
 from sentry.incidents.endpoints.serializers.alert_rule import AlertRuleSerializerResponse
 from sentry.incidents.endpoints.serializers.incident import DetailedIncidentSerializerResponse
+from sentry.incidents.grouptype import MetricIssue
 from sentry.incidents.models.incident import IncidentStatus
 from sentry.incidents.typings.metric_detector import (
     AlertContext,
@@ -436,7 +437,8 @@ def send_incident_alert_notification(
         notification_uuid=notification_uuid,
     )
 
-    if should_fire_workflow_actions(organization):
+    # TODO(iamrajjoshi): This will need to be updated once we plan out Metric Alerts rollout
+    if should_fire_workflow_actions(organization, MetricIssue.type_id):
         return _handle_workflow_engine_notification(
             organization=organization,
             notification_context=notification_context,