fix(aci): Automation triggers can be null (#94234)

Author: malwilley

static/app/types/workflowEngine/automations.tsx

@@ -6,7 +6,7 @@ export interface NewAutomation {
   detectorIds: string[];
   environment: string | null;
   name: string;
-  triggers: DataConditionGroup;
+  triggers: DataConditionGroup | null;
   disabled?: boolean;
 }
 

static/app/views/automations/components/conditionsPanel.tsx

@@ -21,24 +21,26 @@ import {useAvailableActionsQuery} from 'sentry/views/automations/hooks';
 
 type ConditionsPanelProps = {
   actionFilters: DataConditionGroup[];
-  triggers: DataConditionGroup;
+  triggers: DataConditionGroup | null;
 };
 
 function ConditionsPanel({triggers, actionFilters}: ConditionsPanelProps) {
   return (
     <Panel>
-      <ConditionGroupWrapper>
-        <ConditionGroupHeader>
-          {tct('[when:When] any of the following occur', {
-            when: <ConditionBadge />,
-          })}
-        </ConditionGroupHeader>
-        {triggers.conditions.map((trigger, index) => (
-          <div key={index}>
-            <DataConditionDetails condition={trigger} />
-          </div>
-        ))}
-      </ConditionGroupWrapper>
+      {triggers && (
+        <ConditionGroupWrapper>
+          <ConditionGroupHeader>
+            {tct('[when:When] any of the following occur', {
+              when: <ConditionBadge />,
+            })}
+          </ConditionGroupHeader>
+          {triggers.conditions.map((trigger, index) => (
+            <div key={index}>
+              <DataConditionDetails condition={trigger} />
+            </div>
+          ))}
+        </ConditionGroupWrapper>
+      )}
       {actionFilters.map((actionFilter, index) => (
         <div key={index}>
           <ActionFilter actionFilter={actionFilter} totalFilters={actionFilters.length} />

static/app/views/automations/detail.tsx

@@ -5,6 +5,7 @@ import {Button} from 'sentry/components/core/button';
 import {LinkButton} from 'sentry/components/core/button/linkButton';
 import {Flex} from 'sentry/components/core/layout';
 import {DateTime} from 'sentry/components/dateTime';
+import ErrorBoundary from 'sentry/components/errorBoundary';
 import {KeyValueTable, KeyValueTableRow} from 'sentry/components/keyValueTable';
 import LoadingError from 'sentry/components/loadingError';
 import LoadingIndicator from 'sentry/components/loadingIndicator';
@@ -69,10 +70,14 @@ export default function AutomationDetail() {
           <DetailLayout>
             <DetailLayout.Main>
               <Section title={t('History')}>
-                <AutomationHistoryList history={[]} />
+                <ErrorBoundary mini>
+                  <AutomationHistoryList history={[]} />
+                </ErrorBoundary>
               </Section>
               <Section title={t('Connected Monitors')}>
-                <ConnectedMonitorsList monitors={detectors} />
+                <ErrorBoundary mini>
+                  <ConnectedMonitorsList monitors={detectors} />
+                </ErrorBoundary>
               </Section>
             </DetailLayout.Main>
             <DetailLayout.Sidebar>
@@ -97,26 +102,30 @@ export default function AutomationDetail() {
                 })}
               </Section>
               <Section title={t('Conditions')}>
-                <ConditionsPanel
-                  triggers={automation.triggers}
-                  actionFilters={automation.actionFilters}
-                />
+                <ErrorBoundary mini>
+                  <ConditionsPanel
+                    triggers={automation.triggers}
+                    actionFilters={automation.actionFilters}
+                  />
+                </ErrorBoundary>
               </Section>
               <Section title={t('Details')}>
-                <KeyValueTable>
-                  <KeyValueTableRow
-                    keyName={t('Date created')}
-                    value={<DateTime date={automation.dateCreated} dateOnly year />}
-                  />
-                  <KeyValueTableRow
-                    keyName={t('Created by')}
-                    value={createdByUser?.name || createdByUser?.email || t('Unknown')}
-                  />
-                  <KeyValueTableRow
-                    keyName={t('Last modified')}
-                    value={<TimeSince date={automation.dateUpdated} />}
-                  />
-                </KeyValueTable>
+                <ErrorBoundary mini>
+                  <KeyValueTable>
+                    <KeyValueTableRow
+                      keyName={t('Date created')}
+                      value={<DateTime date={automation.dateCreated} dateOnly year />}
+                    />
+                    <KeyValueTableRow
+                      keyName={t('Created by')}
+                      value={createdByUser?.name || createdByUser?.email || t('Unknown')}
+                    />
+                    <KeyValueTableRow
+                      keyName={t('Last modified')}
+                      value={<TimeSince date={automation.dateUpdated} />}
+                    />
+                  </KeyValueTable>
+                </ErrorBoundary>
               </Section>
             </DetailLayout.Sidebar>
           </DetailLayout>