fix(migrations): Fix data integrity error in 0925 (#94264)

Fixes getsentry/self-hosted#3571

The `0925_backfill_open_periods.py` migration was updated to robustly
handle data inconsistencies.

* `DataError` was imported from `django.db` and added to the exception
handling in the `_backfill_group_open_periods` function.
* The `except` block for `GroupOpenPeriod.objects.bulk_create` now
catches both `IntegrityError` and `DataError`. This prevents migration
failures caused by invalid date ranges (e.g., start date after end date)
that trigger `DataError` in PostgreSQL.
* Previously, only `IntegrityError` was caught, leading to migration
failures for users with such data.
* A new test case was introduced in
`tests/sentry/migrations/test_0925_backfill_open_periods.py` to
specifically validate the handling of groups with invalid date ranges
that would trigger a `DataError`, confirming the migration's resilience.

---------

Co-authored-by: Cursor Agent <cursoragent@cursor.com>

Author: BYK

src/sentry/migrations/0925_backfill_open_periods.py

@@ -7,7 +7,7 @@
 from typing import Any
 
 from django.conf import settings
-from django.db import IntegrityError, migrations, router, transaction
+from django.db import DataError, IntegrityError, migrations, router, transaction
 from django.db.backends.base.schema import BaseDatabaseSchemaEditor
 from django.db.migrations.state import StateApps
 
@@ -170,7 +170,7 @@ def _backfill_group_open_periods(
     with transaction.atomic(router.db_for_write(GroupOpenPeriod)):
         try:
             GroupOpenPeriod.objects.bulk_create(open_periods)
-        except IntegrityError as e:
+        except (IntegrityError, DataError) as e:
             logger.exception(
                 "Error creating open period",
                 extra={"group_ids": group_ids, "error": e},

tests/sentry/migrations/test_0925_backfill_open_periods.py

@@ -331,6 +331,31 @@ def setup_before_migration(self, app):
             )
         )
 
+        # Create a group with invalid date range that would cause DataError
+        # This tests the DataError exception handling
+        group_with_invalid_dates = Group.objects.create(
+            project=self.project,
+            status=GroupStatus.RESOLVED,
+            substatus=None,
+            first_seen=self.now - timedelta(days=1),  # Start after the resolution
+        )
+        Activity.objects.create(
+            group=group_with_invalid_dates,
+            project=self.project,
+            type=ActivityType.SET_RESOLVED.value,
+            datetime=self.now - timedelta(days=2),  # Resolution before first_seen
+        )
+        # This group should be skipped due to invalid date range
+        self.test_cases.append(
+            (
+                "group_with_invalid_date_range",
+                group_with_invalid_dates,
+                [],  # No open periods expected due to invalid dates
+                [],
+                [],
+            )
+        )
+
     def test(self):
         for description, group, starts, ends, activities in self.test_cases:
             group.refresh_from_db()