Skip to content

Commit da215a6

Browse files
armenzgcursoragent
andauthored
fix(detectors): TypeError (#95356)
Fixes `TypeError: 'NoneType' object is not subscriptable` in `SQLInjectionDetector`. This error occurred when `extract_request_data` encountered `None` or malformed entries in the request query parameters or body, leading to a crash when attempting to access `query_pair[1]`. The fix adds a defensive check to skip `None` or insufficiently sized `query_pair` entries, making the detector more robust against unexpected input data. [SENTRY-FOR-SENTRY-5ZQH](https://sentry.my.sentry.io/organizations/sentry/issues/2313274/) Co-authored-by: Cursor Agent <cursoragent@cursor.com>
1 parent 309a41f commit da215a6

File tree

1 file changed

+3
-0
lines changed

1 file changed

+3
-0
lines changed

src/sentry/performance_issues/detectors/sql_injection_detector.py

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -91,6 +91,9 @@ def extract_request_data(self, event: dict[str, Any]) -> None:
9191
request_data.extend(self.request_body.items())
9292

9393
for query_pair in request_data:
94+
# Skip None values or pairs that don't have at least 2 elements
95+
if not query_pair or len(query_pair) < 2:
96+
continue
9497
query_value = query_pair[1]
9598
query_key = query_pair[0]
9699

0 commit comments

Comments
 (0)