Skip to content

Commit d616e5b

Browse files
authored
chore(detectors): Clean up issue title / type (#95677)
removes old issue type/title that is no longer being used since we updated the group type in #94540
1 parent 32814e0 commit d616e5b

File tree

3 files changed

+1
-8
lines changed

3 files changed

+1
-8
lines changed

static/app/components/events/interfaces/performance/spanEvidenceKeyValueList.tsx

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -369,7 +369,6 @@ const PREVIEW_COMPONENTS: Partial<
369369
[IssueType.PROFILE_REGEX_MAIN_THREAD]: MainThreadFunctionEvidence,
370370
[IssueType.PROFILE_FRAME_DROP]: MainThreadFunctionEvidence,
371371
[IssueType.PROFILE_FUNCTION_REGRESSION]: RegressionEvidence,
372-
[IssueType.DB_QUERY_INJECTION_VULNERABILITY]: DBQueryInjectionVulnerabilityEvidence,
373372
[IssueType.QUERY_INJECTION_VULNERABILITY]: DBQueryInjectionVulnerabilityEvidence,
374373
};
375374

static/app/types/group.tsx

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -174,7 +174,6 @@ export enum IssueType {
174174
METRIC_ISSUE_POC = 'metric_issue_poc', // To be removed
175175

176176
// Detectors
177-
DB_QUERY_INJECTION_VULNERABILITY = 'db_query_injection_vulnerability',
178177
QUERY_INJECTION_VULNERABILITY = 'query_injection_vulnerability',
179178
}
180179

@@ -210,7 +209,6 @@ export enum IssueTitle {
210209
REPLAY_RAGE_CLICK = 'Rage Click Detected',
211210
REPLAY_HYDRATION_ERROR = 'Hydration Error Detected',
212211

213-
DB_QUERY_INJECTION_VULNERABILITY = 'Potential Database Query Injection Vulnerability',
214212
QUERY_INJECTION_VULNERABILITY = 'Potential Query Injection Vulnerability',
215213
}
216214

@@ -238,7 +236,6 @@ export const ISSUE_TYPE_TO_ISSUE_TITLE = {
238236
profile_frame_drop_experimental: IssueTitle.PROFILE_FRAME_DROP,
239237
profile_function_regression: IssueTitle.PROFILE_FUNCTION_REGRESSION,
240238

241-
db_query_injection_vulnerability: IssueTitle.DB_QUERY_INJECTION_VULNERABILITY,
242239
query_injection_vulnerability: IssueTitle.QUERY_INJECTION_VULNERABILITY,
243240

244241
replay_click_rage: IssueTitle.REPLAY_RAGE_CLICK,
@@ -268,7 +265,6 @@ const OCCURRENCE_TYPE_TO_ISSUE_TYPE = {
268265
1015: IssueType.PERFORMANCE_LARGE_HTTP_PAYLOAD,
269266
1016: IssueType.PERFORMANCE_HTTP_OVERHEAD,
270267
1018: IssueType.PERFORMANCE_ENDPOINT_REGRESSION,
271-
1020: IssueType.DB_QUERY_INJECTION_VULNERABILITY,
272268
1021: IssueType.QUERY_INJECTION_VULNERABILITY,
273269
2001: IssueType.PROFILE_FILE_IO_MAIN_THREAD,
274270
2002: IssueType.PROFILE_IMAGE_DECODE_MAIN_THREAD,

static/app/views/issueDetails/streamline/header/header.tsx

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -85,9 +85,7 @@ export default function StreamlinedGroupHeader({
8585
ReprocessingStatus.REPROCESSED_AND_HASNT_EVENT,
8686
].includes(groupReprocessingStatus);
8787

88-
const isQueryInjection =
89-
group.issueType === IssueType.DB_QUERY_INJECTION_VULNERABILITY ||
90-
group.issueType === IssueType.QUERY_INJECTION_VULNERABILITY;
88+
const isQueryInjection = group.issueType === IssueType.QUERY_INJECTION_VULNERABILITY;
9189
const openForm = useFeedbackForm();
9290
const feedbackButton = openForm ? (
9391
<Button

0 commit comments

Comments
 (0)