🔧 chore(aci): remove async trigger action flag (#95609)

Author: iamrajjoshi

src/sentry/features/temporary.py

@@ -519,10 +519,6 @@ def register_temporary_features(manager: FeatureManager):
     manager.add("organizations:workflow-engine-ui-links", OrganizationFeature, FeatureHandlerStrategy.FLAGPOLE, api_expose=False)
     # Use workflow engine serializers to return data for old rule / incident endpoints
     manager.add("organizations:workflow-engine-rule-serializers", OrganizationFeature, FeatureHandlerStrategy.FLAGPOLE, api_expose=False)
-    # Enable async processing of event workflows in a task rather than as part of post_process.
-    manager.add("organizations:workflow-engine-post-process-async", OrganizationFeature, FeatureHandlerStrategy.FLAGPOLE, api_expose=False)
-    # Enable async processing of actions in a task rather than as part of post_process.
-    manager.add("organizations:workflow-engine-action-trigger-async", OrganizationFeature, FeatureHandlerStrategy.FLAGPOLE, api_expose=False)
     # Enable EventUniqueUserFrequencyConditionWithConditions special alert condition
     manager.add("organizations:event-unique-user-frequency-condition-with-conditions", OrganizationFeature, FeatureHandlerStrategy.FLAGPOLE, api_expose=True)
     # Use spans instead of transactions for dynamic sampling calculations. This will become the new default.

src/sentry/workflow_engine/processors/delayed_workflow.py

@@ -12,7 +12,7 @@
 from django.utils import timezone
 from pydantic import BaseModel, validator
 
-from sentry import buffer, features, nodestore
+from sentry import buffer, nodestore
 from sentry.buffer.base import BufferField
 from sentry.db import models
 from sentry.eventstore.models import Event, GroupEvent
@@ -670,9 +670,6 @@ def fire_actions_for_groups(
 
     # Feature check caching to keep us within the trace budget.
     should_trigger_actions = should_fire_workflow_actions(organization)
-    should_trigger_actions_async = features.has(
-        "organizations:workflow-engine-action-trigger-async", organization
-    )
 
     total_actions = 0
     with track_batch_performance(
@@ -751,13 +748,10 @@ def fire_actions_for_groups(
 
                 if should_trigger_actions:
                     for action in filtered_actions:
-                        if should_trigger_actions_async:
-                            task_params = build_trigger_action_task_params(
-                                action, detector, workflow_event_data
-                            )
-                            trigger_action.delay(**task_params)
-                        else:
-                            action.trigger(workflow_event_data, detector)
+                        task_params = build_trigger_action_task_params(
+                            action, detector, workflow_event_data
+                        )
+                        trigger_action.delay(**task_params)
 
     logger.info(
         "workflow_engine.delayed_workflow.triggered_actions_summary",

src/sentry/workflow_engine/processors/workflow.py

@@ -439,14 +439,8 @@ def process_workflows(
     with sentry_sdk.start_span(op="workflow_engine.process_workflows.trigger_actions"):
         if should_trigger_actions:
             for action in actions:
-                if features.has(
-                    "organizations:workflow-engine-action-trigger-async",
-                    organization,
-                ):
-                    task_params = build_trigger_action_task_params(action, detector, event_data)
-                    trigger_action.delay(**task_params)
-                else:
-                    action.trigger(event_data, detector)
+                task_params = build_trigger_action_task_params(action, detector, event_data)
+                trigger_action.delay(**task_params)
         else:
             logger.info(
                 "workflow_engine.triggered_actions",

tests/sentry/incidents/test_metric_issue_post_process.py

@@ -19,7 +19,7 @@
 from tests.sentry.workflow_engine.test_base import BaseWorkflowTest
 
 
-@patch("sentry.workflow_engine.processors.workflow.Action.trigger")
+@patch("sentry.workflow_engine.tasks.actions.trigger_action.delay")
 class MetricIssueIntegrationTest(BaseWorkflowTest, BaseMetricIssueTest):
     def setUp(self):
         super().setUp()

tests/sentry/workflow_engine/test_integration.py

@@ -197,7 +197,6 @@ def test_workflow_engine__workflows__no_flag(self):
             mock_process_workflow.assert_not_called()
 
 
-@with_feature("organizations:workflow-engine-action-trigger-async")
 @mock.patch("sentry.workflow_engine.processors.workflow.trigger_action.delay")
 @mock_redis_buffer()
 class TestWorkflowEngineIntegrationFromErrorPostProcess(BaseWorkflowIntegrationTest):
@@ -224,6 +223,11 @@ def with_feature_flags(self):
         ):
             yield
 
+    @pytest.fixture(autouse=True)
+    def with_tasks(self):
+        with self.tasks():
+            yield
+
     def create_error_event(
         self,
         project=None,