feat(otlp): Use OTel-friendly default Explore fields (#93736)

If the OTel-friendly UI flag is on, change the default fields for
Explore to ID, Name, Duration, and Timestamp. We are moving away from OP
and Description. Is waiting for
#93725 to add backend support

I added field definitions to `FieldKeys`, since this `name` and `kind`
are `SpanV2` fields, that are EAP-specific an the most recent.

I also updated the type of span definitions to `Record<string,
FieldDefinition>` since span fields are set by the user, so we'll never
have a complete listing to definitions.

Author: gggritso

static/app/utils/fields/index.ts

@@ -1,7 +1,7 @@
 import {t} from 'sentry/locale';
 import type {TagCollection} from 'sentry/types/group';
 import {CONDITIONS_ARGUMENTS, WEB_VITALS_QUALITY} from 'sentry/utils/discover/types';
-import {SpanIndexedField} from 'sentry/views/insights/types';
+import {SpanFields, SpanIndexedField} from 'sentry/views/insights/types';
 // Don't forget to update https://docs.sentry.io/product/sentry-basics/search/searchable-properties/ for any changes made here
 
 export enum FieldKind {
@@ -1896,11 +1896,29 @@ const SPAN_HTTP_FIELD_DEFINITIONS: Record<SpanHttpField, FieldDefinition> = {
     valueType: FieldValueType.SIZE,
   },
 };
-
-const SPAN_FIELD_DEFINITIONS: Record<AllEventFieldKeys, FieldDefinition> = {
+const SPAN_FIELD_DEFINITIONS: Record<string, FieldDefinition> = {
   ...EVENT_FIELD_DEFINITIONS,
   ...SPAN_AGGREGATION_FIELDS,
   ...SPAN_HTTP_FIELD_DEFINITIONS,
+  [SpanFields.NAME]: {
+    desc: t(
+      'The span name. A short, human-readable identifier for the operation being performed by the span.'
+    ),
+    kind: FieldKind.FIELD,
+    valueType: FieldValueType.STRING,
+  },
+  [SpanFields.KIND]: {
+    desc: t(
+      'The kind of span. Indicates the type of span such as server, client, internal, producer, or consumer.'
+    ),
+    kind: FieldKind.FIELD,
+    valueType: FieldValueType.STRING,
+  },
+  [SpanFields.STATUS]: {
+    desc: t('Span status. Indicates whether the span operation was successful.'),
+    kind: FieldKind.FIELD,
+    valueType: FieldValueType.STRING,
+  },
 };
 
 const LOG_FIELD_DEFINITIONS: Record<string, FieldDefinition> = {};
@@ -2609,8 +2627,8 @@ export const getFieldDefinition = (
       }
       return null;
     case 'span':
-      if (SPAN_FIELD_DEFINITIONS[key as keyof typeof SPAN_FIELD_DEFINITIONS]) {
-        return SPAN_FIELD_DEFINITIONS[key as keyof typeof SPAN_FIELD_DEFINITIONS];
+      if (SPAN_FIELD_DEFINITIONS[key]) {
+        return SPAN_FIELD_DEFINITIONS[key];
       }
 
       // In EAP we have numeric tags that can be passed as parameters to

static/app/views/explore/contexts/pageParamsContext/fields.tsx

@@ -1,9 +1,20 @@
 import type {Location} from 'history';
 
+import type {Organization} from 'sentry/types/organization';
 import {defined} from 'sentry/utils';
 import {decodeList} from 'sentry/utils/queryString';
+import {SpanFields} from 'sentry/views/insights/types';
+
+export function defaultFields(organization?: Organization): string[] {
+  if (organization?.features.includes('performance-otel-friendly-ui')) {
+    return [
+      SpanFields.ID,
+      SpanFields.NAME,
+      SpanFields.SPAN_DURATION,
+      SpanFields.TIMESTAMP,
+    ];
+  }
 
-export function defaultFields(): string[] {
   return [
     'id',
     'span.op',
@@ -14,14 +25,17 @@ export function defaultFields(): string[] {
   ];
 }
 
-export function getFieldsFromLocation(location: Location): string[] {
+export function getFieldsFromLocation(
+  location: Location,
+  organization?: Organization
+): string[] {
   const fields = decodeList(location.query.field);
 
   if (fields.length) {
     return fields;
   }
 
-  return defaultFields();
+  return defaultFields(organization);
 }
 
 export function updateLocationWithFields(

static/app/views/explore/contexts/pageParamsContext/index.spec.tsx

@@ -1,3 +1,5 @@
+import {OrganizationFixture} from 'sentry-fixture/organization';
+
 import {act, render} from 'sentry-test/reactTestingLibrary';
 
 import {DiscoverDatasets} from 'sentry/utils/discover/types';
@@ -742,4 +744,23 @@ describe('PageParamsProvider', function () {
       })
     );
   });
+
+  it('uses OTel-friendly default fields in OTel-friendly mode', function () {
+    const organization = OrganizationFixture({
+      features: ['performance-otel-friendly-ui'],
+    });
+
+    render(
+      <PageParamsProvider>
+        <Component />
+      </PageParamsProvider>,
+      {organization}
+    );
+
+    expect(pageParams).toEqual(
+      expect.objectContaining({
+        fields: ['id', 'span.name', 'span.duration', 'timestamp'],
+      })
+    );
+  });
 });

static/app/views/explore/contexts/pageParamsContext/index.tsx

@@ -178,7 +178,7 @@ export function PageParamsProvider({children}: PageParamsProviderProps) {
   const pageParams: ReadablePageParams = useMemo(() => {
     const aggregateFields = getAggregateFieldsFromLocation(location, organization);
     const dataset = getDatasetFromLocation(location);
-    const fields = getFieldsFromLocation(location);
+    const fields = getFieldsFromLocation(location, organization);
     const mode = getModeFromLocation(location);
     const query = getQueryFromLocation(location);
     const groupBys = aggregateFields.filter(isGroupBy).map(groupBy => groupBy.groupBy);

static/app/views/insights/types.tsx

@@ -70,12 +70,14 @@ export enum SpanMetricsField {
   MOBILE_SLOW_FRAMES = 'mobile.slow_frames',
 }
 
-// TODO: This will be the final field type for eap spans
+// TODO: This will be the final field type for EAP spans
 export enum SpanFields {
   TRANSACTION = 'transaction',
   IS_TRANSACTION = 'is_transaction',
   CACHE_HIT = 'cache.hit',
   IS_STARRED_TRANSACTION = 'is_starred_transaction',
+  ID = 'id',
+  TIMESTAMP = 'timestamp',
   SPAN_DURATION = 'span.duration',
   USER = 'user',
   MOBILE_FROZEN_FRAMES = 'mobile.frozen_frames',
@@ -90,6 +92,9 @@ export enum SpanFields {
   SPAN_DESCRIPTION = 'span.description',
   SPAN_GROUP = 'span.group',
   SPAN_OP = 'span.op',
+  NAME = 'span.name',
+  KIND = 'span.kind',
+  STATUS = 'span.status',
   RELEASE = 'release',
   PROJECT_ID = 'project.id',
   RESPONSE_CODE = 'span.status_code',
@@ -140,7 +145,10 @@ type SpanNumberFields =
 type SpanStringFields =
   | SpanMetricsField.RESOURCE_RENDER_BLOCKING_STATUS
   | SpanFields.RAW_DOMAIN
-  | 'id'
+  | SpanFields.ID
+  | SpanFields.NAME
+  | SpanFields.KIND
+  | SpanFields.STATUS
   | 'span_id'
   | 'span.op'
   | 'span.description'