🔧 chore: use IntegrationProviderSlug.Discord instead of magic str (#94356)

Author: iamrajjoshi

src/sentry/identity/discord/provider.py

@@ -1,6 +1,7 @@
 from sentry.auth.provider import Provider
+from sentry.integrations.types import IntegrationProviderSlug
 
 
 class DiscordIdentityProvider(Provider):
-    key = "discord"
+    key = IntegrationProviderSlug.DISCORD.value
     name = "Discord"

src/sentry/integrations/discord/actions/issue_alert/notification.py

@@ -11,6 +11,7 @@
     MessagingInteractionEvent,
     MessagingInteractionType,
 )
+from sentry.integrations.types import IntegrationProviderSlug
 from sentry.rules.actions import IntegrationEventAction
 from sentry.rules.base import CallbackFuture
 from sentry.shared_integrations.exceptions import ApiError
@@ -22,7 +23,7 @@ class DiscordNotifyServiceAction(IntegrationEventAction):
     id = "sentry.integrations.discord.notify_action.DiscordNotifyServiceAction"
     label = "Send a notification to the {server} Discord server in the channel with ID or URL: {channel_id} and show tags {tags} in the notification."
     prompt = "Send a Discord notification"
-    provider = "discord"
+    provider = IntegrationProviderSlug.DISCORD.value
     integration_key = "server"
 
     def __init__(self, *args: Any, **kwargs: Any) -> None:

src/sentry/integrations/discord/client.py

@@ -12,6 +12,7 @@
 from sentry import options
 from sentry.integrations.client import ApiClient
 from sentry.integrations.discord.utils.consts import DISCORD_ERROR_CODES, DISCORD_USER_ERRORS
+from sentry.integrations.types import IntegrationProviderSlug
 from sentry.shared_integrations.exceptions import ApiError
 
 # to avoid a circular import
@@ -43,7 +44,7 @@
 
 
 class DiscordClient(ApiClient):
-    integration_name: str = "discord"
+    integration_name: str = IntegrationProviderSlug.DISCORD.value
     base_url: str = DISCORD_BASE_URL
     _METRICS_FAILURE_KEY: str = "sentry.integrations.discord.failure"
     _METRICS_SUCCESS_KEY: str = "sentry.integrations.discord.success"

src/sentry/integrations/discord/integration.py

@@ -86,7 +86,7 @@ def uninstall(self) -> None:
 
         installations = integration_service.get_organization_integrations(
             integration_id=self.model.id,
-            providers=["discord"],
+            providers=[IntegrationProviderSlug.DISCORD.value],
         )
 
         # Remove any installations pending deletion
@@ -164,7 +164,7 @@ def build_integration(self, state: Mapping[str, Any]) -> IntegrationData:
         except (ApiError, AttributeError):
             guild_name = guild_id
 
-        discord_config = state.get("discord", {})
+        discord_config = state.get(IntegrationProviderSlug.DISCORD.value, {})
         if isinstance(discord_config, dict):
             use_configure = discord_config.get("use_configure") == "1"
         else:
@@ -185,7 +185,7 @@ def build_integration(self, state: Mapping[str, Any]) -> IntegrationData:
             "name": guild_name,
             "external_id": guild_id,
             "user_identity": {
-                "type": "discord",
+                "type": IntegrationProviderSlug.DISCORD.value,
                 "external_id": discord_user_id,
                 "scopes": [],
                 "data": {},
@@ -289,7 +289,7 @@ def __init__(self, params):
 
     def dispatch(self, request: HttpRequest, pipeline: IntegrationPipelineT) -> HttpResponseBase:
         if "guild_id" not in request.GET or "code" not in request.GET:
-            state = pipeline.fetch_state(key="discord") or {}
+            state = pipeline.fetch_state(key=IntegrationProviderSlug.DISCORD.value) or {}
             redirect_uri = (
                 absolute_uri("extensions/discord/configure/")
                 if state.get("use_configure") == "1"

src/sentry/integrations/discord/requests/base.py

@@ -15,6 +15,7 @@
 from sentry.identity.services.identity.service import identity_service
 from sentry.integrations.discord.client import DISCORD_BASE_URL
 from sentry.integrations.services.integration import RpcIntegration, integration_service
+from sentry.integrations.types import IntegrationProviderSlug
 from sentry.users.services.user.model import RpcUser
 from sentry.users.services.user.service import user_service
 
@@ -136,7 +137,7 @@ def response_url(self) -> str | None:
 
     def _get_context(self):
         context = integration_service.get_integration_identity_context(
-            integration_provider="discord",
+            integration_provider=IntegrationProviderSlug.DISCORD.value,
             integration_external_id=self.guild_id,
             identity_external_id=self.user_id,
             identity_provider_external_id=self.guild_id,
@@ -197,7 +198,7 @@ def get_identity_user(self) -> RpcUser | None:
     def get_identity(self) -> RpcIdentity | None:
         if not self._provider:
             self._provider = identity_service.get_provider(
-                provider_type="discord", provider_ext_id=self.guild_id
+                provider_type=IntegrationProviderSlug.DISCORD.value, provider_ext_id=self.guild_id
             )
             if not self._provider:
                 self._info("discord.validate.identity.no.provider")
@@ -226,7 +227,9 @@ def get_identity_str(self) -> str | None:
     def validate_integration(self) -> None:
         if not self._integration:
             self._integration = integration_service.get_integration(
-                provider="discord", external_id=self.guild_id, status=ObjectStatus.ACTIVE
+                provider=IntegrationProviderSlug.DISCORD.value,
+                external_id=self.guild_id,
+                status=ObjectStatus.ACTIVE,
             )
         self._info("discord.validate.integration")
 

src/sentry/integrations/discord/spec.py

@@ -12,6 +12,7 @@
     MessagingIdentityLinkViewSet,
     MessagingIntegrationSpec,
 )
+from sentry.integrations.types import IntegrationProviderSlug
 from sentry.models.organization import Organization
 from sentry.notifications.models.notificationaction import ActionService
 from sentry.rules.actions import IntegrationEventAction
@@ -20,7 +21,7 @@
 class DiscordMessagingSpec(MessagingIntegrationSpec):
     @property
     def provider_slug(self) -> str:
-        return "discord"
+        return IntegrationProviderSlug.DISCORD.value
 
     @property
     def action_service(self) -> ActionService:

src/sentry/integrations/discord/webhooks/base.py

@@ -14,6 +14,7 @@
 from sentry.integrations.discord.requests.base import DiscordRequest, DiscordRequestError
 from sentry.integrations.discord.webhooks.command import DiscordCommandHandler
 from sentry.integrations.discord.webhooks.message_component import DiscordMessageComponentHandler
+from sentry.integrations.types import IntegrationProviderSlug
 from sentry.silo.base import SiloMode
 
 from .types import DiscordResponseTypes
@@ -36,7 +37,7 @@ class DiscordInteractionsEndpoint(Endpoint):
     authentication_classes = ()
     permission_classes = ()
     discord_request_class = DiscordRequest
-    provider = "discord"
+    provider = IntegrationProviderSlug.DISCORD.value
 
     def __init__(self) -> None:
         super().__init__()

src/sentry/integrations/web/discord_extension_configuration.py

@@ -1,9 +1,11 @@
+from sentry.integrations.types import IntegrationProviderSlug
+
 from .integration_extension_configuration import IntegrationExtensionConfigurationView
 
 
 class DiscordExtensionConfigurationView(IntegrationExtensionConfigurationView):
-    provider = "discord"
-    external_provider_key = "discord"
+    provider = IntegrationProviderSlug.DISCORD.value
+    external_provider_key = IntegrationProviderSlug.DISCORD.value
 
     def map_params_to_state(self, params):
         return {"use_configure": "1", **params}

src/sentry/middleware/integrations/tasks.py

@@ -10,6 +10,7 @@
 from requests import Response
 from rest_framework import status
 
+from sentry.integrations.types import IntegrationProviderSlug
 from sentry.silo.base import SiloMode
 from sentry.silo.client import RegionSiloClient
 from sentry.tasks.base import instrumented_task
@@ -138,7 +139,7 @@ def convert_to_async_slack_response(
 class _AsyncDiscordDispatcher(_AsyncRegionDispatcher):
     @property
     def log_code(self) -> str:
-        return "discord"
+        return IntegrationProviderSlug.DISCORD.value
 
     def unpack_payload(self, response: Response) -> Any:
         # Region will return a response assuming it's meant to go directly to Discord. Since we're

src/sentry/models/activity.py

@@ -23,6 +23,7 @@
 )
 from sentry.db.models.fields.hybrid_cloud_foreign_key import HybridCloudForeignKey
 from sentry.db.models.manager.base import BaseManager
+from sentry.integrations.types import IntegrationProviderSlug
 from sentry.issues.grouptype import get_group_type_by_type_id
 from sentry.tasks import activity
 from sentry.types.activity import CHOICES, STATUS_CHANGE_ACTIVITY_TYPES, ActivityType
@@ -215,7 +216,7 @@ class ActivityIntegration(Enum):
 
     CODEOWNERS = "codeowners"
     PROJECT_OWNERSHIP = "projectOwnership"
-    SLACK = "slack"
-    MSTEAMS = "msteams"
-    DISCORD = "discord"
+    SLACK = IntegrationProviderSlug.SLACK.value
+    MSTEAMS = IntegrationProviderSlug.MSTEAMS.value
+    DISCORD = IntegrationProviderSlug.DISCORD.value
     SUSPECT_COMMITTER = "suspectCommitter"