Skip to content

Commit 9a72930

Browse files
committed
Move userreport ingest file under feedback
1 parent ef511ea commit 9a72930

File tree

7 files changed

+17
-9
lines changed

7 files changed

+17
-9
lines changed

src/sentry/feedback/endpoints/project_user_reports.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@
1616
from sentry.api.paginator import DateTimePaginator
1717
from sentry.api.serializers import UserReportWithGroupSerializer, serialize
1818
from sentry.feedback.lib.utils import FeedbackCreationSource
19-
from sentry.ingest.userreport import Conflict, save_userreport
19+
from sentry.feedback.usecases.userreport import Conflict, save_userreport
2020
from sentry.models.environment import Environment
2121
from sentry.models.userreport import UserReport
2222
from sentry.utils.dates import epoch

src/sentry/feedback/usecases/save_event_feedback.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@
55

66
from sentry.feedback.lib.utils import FeedbackCreationSource
77
from sentry.feedback.usecases.create_feedback import create_feedback_issue
8-
from sentry.ingest.userreport import Conflict, save_userreport
8+
from sentry.feedback.usecases.userreport import Conflict, save_userreport
99
from sentry.models.environment import Environment
1010
from sentry.models.project import Project
1111
from sentry.utils import metrics

src/sentry/ingest/consumer/processors.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,8 +15,8 @@
1515
from sentry.event_manager import EventManager, save_attachment
1616
from sentry.eventstore.processing import event_processing_store, transaction_processing_store
1717
from sentry.feedback.lib.utils import FeedbackCreationSource, is_in_feedback_denylist
18+
from sentry.feedback.usecases.userreport import Conflict, save_userreport
1819
from sentry.ingest.types import ConsumerType
19-
from sentry.ingest.userreport import Conflict, save_userreport
2020
from sentry.killswitches import killswitch_matches_context
2121
from sentry.models.organization import Organization
2222
from sentry.models.project import Project

tests/sentry/feedback/test_organization_user_reports.py

Whitespace-only changes.

tests/sentry/feedback/test_project_user_reports.py

Whitespace-only changes.

tests/sentry/ingest/test_userreport.py renamed to tests/sentry/feedback/test_userreport.py

Lines changed: 14 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@
55

66
from sentry.feedback.lib.types import UserReportDict
77
from sentry.feedback.lib.utils import UNREAL_FEEDBACK_UNATTENDED_MESSAGE, FeedbackCreationSource
8-
from sentry.ingest.userreport import save_userreport, validate_user_report
8+
from sentry.feedback.usecases.userreport import save_userreport, validate_user_report
99
from sentry.models.userreport import UserReport
1010
from sentry.testutils.factories import Factories
1111
from sentry.testutils.pytest.fixtures import django_db_all
@@ -30,13 +30,15 @@ def mock_report_dict() -> UserReportDict:
3030

3131
@pytest.fixture
3232
def skip_denylist(monkeypatch):
33-
monkeypatch.setattr("sentry.ingest.userreport.is_in_feedback_denylist", lambda org: False)
33+
monkeypatch.setattr(
34+
"sentry.feedback.usecases.userreport.is_in_feedback_denylist", lambda org: False
35+
)
3436

3537

3638
@pytest.fixture
3739
def skip_filters(monkeypatch):
3840
monkeypatch.setattr(
39-
"sentry.ingest.userreport.validate_user_report",
41+
"sentry.feedback.usecases.userreport.validate_user_report",
4042
Mock(return_value=(False, None, None)),
4143
)
4244

@@ -219,7 +221,9 @@ def test_save_user_report_basic(
219221
def test_save_user_report_filters_denylist(
220222
default_project, monkeypatch, skip_filters, mock_report_dict
221223
):
222-
monkeypatch.setattr("sentry.ingest.userreport.is_in_feedback_denylist", lambda org: True)
224+
monkeypatch.setattr(
225+
"sentry.feedback.usecases.userreport.is_in_feedback_denylist", lambda org: True
226+
)
223227
result = save_userreport(
224228
default_project, mock_report_dict, FeedbackCreationSource.USER_REPORT_ENVELOPE
225229
)
@@ -286,7 +290,9 @@ def test_save_user_report_shims_if_event_found(
286290
)
287291

288292
mock_shim_to_feedback = Mock()
289-
monkeypatch.setattr("sentry.ingest.userreport.shim_to_feedback", mock_shim_to_feedback)
293+
monkeypatch.setattr(
294+
"sentry.feedback.usecases.userreport.shim_to_feedback", mock_shim_to_feedback
295+
)
290296

291297
mock_report_dict["event_id"] = event.event_id
292298

@@ -305,7 +311,9 @@ def test_save_user_report_does_not_shim_if_event_found_but_source_is_new_feedbac
305311
)
306312

307313
mock_shim_to_feedback = Mock()
308-
monkeypatch.setattr("sentry.ingest.userreport.shim_to_feedback", mock_shim_to_feedback)
314+
monkeypatch.setattr(
315+
"sentry.feedback.usecases.userreport.shim_to_feedback", mock_shim_to_feedback
316+
)
309317
# Source is new feedback, so no shim
310318
save_userreport(
311319
default_project,

0 commit comments

Comments
 (0)