chore(billing): Cleanup NextPlanInfo interface and related tests (#94716)

This PR cleans up some unused stuff in the nextPlanInfo interface and
updates the related tests.

Originally I had recreated a wrapper around the categoryCredits object
where the errorCredits stuff was, but realized that was already being
accounted for in `getAM3MigrationCredits` function. So I just wrote a
new test confirming that and marked the cohort as for test only. It can
be updated in the future

Closes
https://linear.app/getsentry/issue/BIL-963/clean-up-category-specific-fields-for-nextplaninfo


<!--

  Sentry employees and contractors can delete or ignore the following.

-->

### Legal Boilerplate

Look, I get it. The entity doing business as "Sentry" was incorporated
in the State of Delaware in 2015 as Functional Software, Inc. and is
gonna need some rights from me in order to utilize my contributions in
this here PR. So here's the deal: I retain all rights, title and
interest in and to my contributions, and by keeping this boilerplate
intact I confirm that Sentry can use, modify, copy, and redistribute my
contributions, under Sentry's choice of terms.

Author: ajay-sentry

static/gsApp/types/index.tsx

@@ -804,6 +804,7 @@ export enum CohortId {
   EIGHTH = 8,
   NINTH = 9,
   TENTH = 10,
+  TEST_ONE = 111,
 }
 
 /** @internal exported for tests only */
@@ -813,18 +814,13 @@ export type Cohort = {
   secondDiscount: number;
 };
 
-// TODO(data categories): BIL-963
 export type NextPlanInfo = {
   contractPeriod: string;
   discountAmount: number;
   discountMonths: number;
-  errorCredits: number;
-  errorCreditsMonths: number;
   id: string;
   name: string;
   reserved: Partial<Record<DataCategory, number>>;
-  reservedAttachments: number;
-  reservedErrors: number;
   totalPrice: number;
   categoryCredits?: Partial<
     Record<
@@ -835,7 +831,6 @@ export type NextPlanInfo = {
       }
     >
   >;
-  reservedTransactions?: number;
 };
 
 export type PlanMigration = {

static/gsApp/views/subscriptionPage/planMigrationActive/index.spec.tsx

@@ -869,3 +869,46 @@ describe('PlanMigrationActive cohort 10', function () {
     );
   });
 });
+
+describe('PlanMigrationActive cohort 111 -- TEST ONLY', function () {
+  const organization = OrganizationFixture();
+  const subscription = SubscriptionFixture({
+    plan: 'am3_business_auf',
+    organization,
+  });
+
+  const migrationDate = moment().add(1, 'days').format('ll');
+  const migration = PlanMigrationFixture({
+    cohortId: CohortId.TEST_ONE,
+    effectiveAt: migrationDate,
+  });
+
+  function renderSimple() {
+    render(<PlanMigrationActive migration={migration} subscription={subscription} />);
+  }
+
+  it('renders with active migration', function () {
+    renderSimple();
+  });
+
+  it('renders plan migration table', function () {
+    renderSimple();
+    expect(screen.getByRole('table')).toBeInTheDocument();
+    expect(screen.getAllByRole('row')).toHaveLength(8);
+  });
+
+  it('renders combined credit message', function () {
+    renderSimple();
+    expect(screen.getByTestId('recurring-credits')).toHaveTextContent(
+      /\*We'll provide an additional 100000 errors for the next 1 months, 100000 replays for the next 1 months, and 100000 spans for the next 1 months following the end of your current annual contract, at no charge./
+    );
+  });
+
+  it('renders monitor seats row', function () {
+    renderSimple();
+    expect(screen.getByTestId('current-monitorSeats')).toHaveTextContent(
+      /1 cron monitor/
+    );
+    expect(screen.getByTestId('new-monitorSeats')).toHaveTextContent(/1 cron monitor/);
+  });
+});

static/gsApp/views/subscriptionPage/planMigrationActive/planMigrationTable.tsx

@@ -13,7 +13,6 @@ import {
   type PlanMigration,
   type Subscription,
 } from 'getsentry/types';
-import {formatReservedWithUnits} from 'getsentry/utils/billing';
 import {displayPrice} from 'getsentry/views/amCheckout/utils';
 import {AlertStripedTable} from 'getsentry/views/subscriptionPage/styles';
 
@@ -41,7 +40,6 @@ function PlanMigrationTable({subscription, migration}: Props) {
   // Setting default to monthly to handle nextPlan if the endpoint update is not updated yet
   // Prior plan migrations are all monthly contracts
   const nextPlanTerm = nextPlan.contractPeriod ?? MONTHLY;
-  const hasErrorCredits = !!(nextPlan.errorCredits && nextPlan.errorCreditsMonths);
   // The nextPlan.discountAmount is handled differently for monthly & annual billing intervals. Using these checks to display correct info
   const hasMonthlyDiscount = !!(
     nextPlan.discountAmount &&
@@ -109,7 +107,7 @@ function PlanMigrationTable({subscription, migration}: Props) {
               DataCategoryExact.ERROR,
               subscription
             )}
-            hasCredits={hasErrorCredits}
+            hasCredits={!!nextPlan.categoryCredits?.[DataCategory.ERRORS]?.credits}
           />
           {/* TODO(data categories): BIL-955 */}
           {isAM3Migration
@@ -185,24 +183,6 @@ function PlanMigrationTable({subscription, migration}: Props) {
           )}
         </tbody>
       </AlertStripedTable>
-      {hasErrorCredits && (
-        <Credits data-test-id="error-credits">
-          *
-          {tct(
-            'We will provide an extra [errorCredits] errors for [errorCreditsMonths] months at no additional charge.',
-            {
-              errorCredits: formatReservedWithUnits(
-                nextPlan.errorCredits || 0,
-                DataCategory.ERRORS,
-                {
-                  isAbbreviated: true,
-                }
-              ),
-              errorCreditsMonths: nextPlan.errorCreditsMonths,
-            }
-          )}
-        </Credits>
-      )}
       {hasMonthlyDiscount && (
         <Credits data-test-id="dollar-credits">
           *

tests/js/getsentry-test/fixtures/planMigration.ts

@@ -7,15 +7,17 @@ const SecondCohort: Cohort = {
     id: 'am1_team',
     name: 'Team',
     totalPrice: 4400,
-    reservedErrors: 100000,
-    reservedTransactions: 100000,
-    reservedAttachments: 1,
+
     reserved: {errors: 100000, transactions: 100000, attachments: 1},
-    errorCredits: 0,
-    errorCreditsMonths: 0,
     discountAmount: 1500,
     discountMonths: 5,
     contractPeriod: 'monthly',
+    categoryCredits: {
+      errors: {
+        credits: 0,
+        months: 0,
+      },
+    },
   },
   secondDiscount: 0,
 };
@@ -26,12 +28,7 @@ const ThirdCohort: Cohort = {
     id: 'am2_team',
     name: 'Team',
     totalPrice: 4400,
-    reservedErrors: 100000,
-    reservedTransactions: 100000,
-    reservedAttachments: 1,
     reserved: {errors: 100000, transactions: 100000, attachments: 1},
-    errorCredits: 0,
-    errorCreditsMonths: 0,
     discountAmount: 1800,
     discountMonths: 5,
     contractPeriod: 'monthly',
@@ -45,12 +42,7 @@ const FourthCohort: Cohort = {
     id: 'am2_team',
     name: 'Team',
     totalPrice: 48000,
-    reservedErrors: 100000,
-    reservedTransactions: 100000,
-    reservedAttachments: 1,
     reserved: {errors: 100000, transactions: 100000, attachments: 1},
-    errorCredits: 0,
-    errorCreditsMonths: 0,
     discountAmount: 16800,
     discountMonths: 1,
     contractPeriod: 'annual',
@@ -64,12 +56,7 @@ const FifthCohort: Cohort = {
     id: 'am2_business',
     name: 'Business',
     totalPrice: 48400,
-    reservedErrors: 1_000_000,
-    reservedTransactions: 100000,
-    reservedAttachments: 1,
     reserved: {errors: 1_000_000, transactions: 100000, attachments: 1},
-    errorCredits: 0,
-    errorCreditsMonths: 0,
     discountAmount: 28500,
     discountMonths: 5,
     contractPeriod: 'monthly',
@@ -83,12 +70,7 @@ const SixthCohort: Cohort = {
     id: 'am2_team',
     name: 'Team',
     totalPrice: 4400,
-    reservedErrors: 100000,
-    reservedTransactions: 100000,
-    reservedAttachments: 1,
     reserved: {errors: 100000, transactions: 100000, attachments: 1},
-    errorCredits: 0,
-    errorCreditsMonths: 0,
     discountAmount: 1800,
     discountMonths: 5,
     contractPeriod: 'monthly',
@@ -102,12 +84,7 @@ const SeventhCohort: Cohort = {
     id: 'am2_business',
     name: 'Business',
     totalPrice: 523200,
-    reservedErrors: 1_000_000,
-    reservedTransactions: 100000,
-    reservedAttachments: 1,
     reserved: {errors: 1_000_000, transactions: 100000, attachments: 1},
-    errorCredits: 0,
-    errorCreditsMonths: 0,
     discountAmount: 308400,
     discountMonths: 1,
     contractPeriod: 'annual',
@@ -121,8 +98,6 @@ const EighthCohort: Cohort = {
     id: 'am3_business',
     name: 'Business',
     totalPrice: 89_00,
-    reservedErrors: 50_000,
-    reservedAttachments: 1,
     reserved: {
       errors: 50_000,
       replays: 50,
@@ -136,8 +111,6 @@ const EighthCohort: Cohort = {
         months: 2,
       },
     },
-    errorCredits: 0,
-    errorCreditsMonths: 0,
     discountAmount: 0,
     discountMonths: 1,
     contractPeriod: 'monthly',
@@ -151,8 +124,6 @@ const NinthCohort: Cohort = {
     id: 'am3_business',
     name: 'Business',
     totalPrice: 960_00,
-    reservedErrors: 50_000,
-    reservedAttachments: 1,
     reserved: {
       errors: 50_000,
       replays: 50,
@@ -166,8 +137,6 @@ const NinthCohort: Cohort = {
         months: 2,
       },
     },
-    errorCredits: 0,
-    errorCreditsMonths: 0,
     discountAmount: 0,
     discountMonths: 1,
     contractPeriod: 'annual',
@@ -181,17 +150,47 @@ const TenthCohort: Cohort = {
     id: 'am3_business',
     name: 'Business',
     totalPrice: 960_00,
-    reservedErrors: 50_000,
-    reservedAttachments: 1,
     reserved: {
       errors: 50_000,
       replays: 50,
       spans: 10_000_000,
       attachments: 1,
       monitorSeats: 1,
     },
-    errorCredits: 0,
-    errorCreditsMonths: 0,
+    discountAmount: 0,
+    discountMonths: 1,
+    contractPeriod: 'annual',
+  },
+  secondDiscount: 0,
+};
+
+const testOneCohort: Cohort = {
+  cohortId: CohortId.TEST_ONE,
+  nextPlan: {
+    id: 'am3_business',
+    name: 'Business',
+    totalPrice: 960_00,
+    reserved: {
+      errors: 50_000,
+      replays: 50,
+      spans: 10_000_000,
+      attachments: 1,
+      monitorSeats: 1,
+    },
+    categoryCredits: {
+      errors: {
+        credits: 100_000,
+        months: 1,
+      },
+      replays: {
+        credits: 100_000,
+        months: 1,
+      },
+      spans: {
+        credits: 100_000,
+        months: 1,
+      },
+    },
     discountAmount: 0,
     discountMonths: 1,
     contractPeriod: 'annual',
@@ -209,6 +208,7 @@ const CohortLookup: Record<CohortId, Cohort> = {
   [CohortId.EIGHTH]: EighthCohort,
   [CohortId.NINTH]: NinthCohort,
   [CohortId.TENTH]: TenthCohort,
+  [CohortId.TEST_ONE]: testOneCohort,
 };
 
 export function PlanMigrationFixture({