Skip to content

Commit 915a3cc

Browse files
DominikB2014andrewshie-sentry
authored andcommitted
fix(insights): avoid using the default transaction.op filter in the transaction summary (#95436)
In eap, blank transaction ops are set to `default` but in non-eap they are just empty strings. On the insights overview page, there was an issue where clicking on a transaction with op of `default` would yield no results on the transaction summary page. This is because we automatically applied a `transaction.op:default` filter, but the summary page is not eap yet. This PR remove the transaction.op filter when navigating to the summary page if the op is `default`. This is only done on backend and mobile overview pages because the frontend page does not group by op
1 parent e60ba42 commit 915a3cc

File tree

2 files changed

+10
-2
lines changed

2 files changed

+10
-2
lines changed

static/app/views/insights/pages/backend/backendTable.tsx

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -221,11 +221,15 @@ function renderBodyCell(
221221
}
222222

223223
if (column.key === 'transaction') {
224+
// In eap, blank transaction ops are set to `default` but not in non-eap.
225+
// The transaction summary is not eap yet, so we should exclude the `default` transaction.op filter
226+
const spanOp =
227+
row['span.op'].toLowerCase() === 'default' ? undefined : row['span.op'];
224228
return (
225229
<TransactionCell
226230
project={row.project}
227231
transaction={row.transaction}
228-
transactionMethod={row['span.op']}
232+
transactionMethod={spanOp}
229233
/>
230234
);
231235
}

static/app/views/insights/pages/mobile/mobileOverviewTable.tsx

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -203,11 +203,15 @@ function renderBodyCell(
203203
}
204204

205205
if (column.key === 'transaction') {
206+
// In eap, blank transaction ops are set to `default` but not in non-eap.
207+
// The transaction summary is not eap yet, so we should exclude the `default` transaction.op filter
208+
const spanOp =
209+
row['span.op'].toLowerCase() === 'default' ? undefined : row['span.op'];
206210
return (
207211
<TransactionCell
208212
project={row.project}
209213
transaction={row.transaction}
210-
transactionMethod={row['span.op']}
214+
transactionMethod={spanOp}
211215
/>
212216
);
213217
}

0 commit comments

Comments
 (0)