Skip to content

Commit 8aa950e

Browse files
fix: remove extra space for java in framework suggestion modal (#95323)
1 parent 3e892e8 commit 8aa950e

File tree

1 file changed

+13
-2
lines changed

1 file changed

+13
-2
lines changed

static/app/components/onboarding/frameworkSuggestionModal.tsx

Lines changed: 13 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -260,6 +260,17 @@ export function FrameworkSuggestionModal({
260260
...listEntries,
261261
];
262262

263+
useEffect(() => {
264+
const documentElement = document.querySelector('[role="dialog"] [role="document"]');
265+
if (
266+
!(documentElement instanceof HTMLElement) ||
267+
listEntriesWithVanilla.length <= COLLAPSE_COUNT
268+
) {
269+
return;
270+
}
271+
documentElement.style.minHeight = '631px';
272+
}, [listEntriesWithVanilla.length]);
273+
263274
return (
264275
<Fragment>
265276
<Header>
@@ -320,7 +331,7 @@ export function FrameworkSuggestionModal({
320331
);
321332
})}
322333
</PlatformList>
323-
{!isExpanded && (
334+
{showMoreButton && (
324335
<ShowMoreButtonWrapper>{showMoreButton}</ShowMoreButtonWrapper>
325336
)}
326337
</Fragment>
@@ -483,7 +494,7 @@ export const modalCss = css`
483494
display: flex;
484495
flex-direction: column;
485496
max-height: 80vh;
486-
min-height: 631px;
497+
min-height: 550px;
487498
}
488499
section {
489500
display: flex;

0 commit comments

Comments
 (0)