fix(replay): safer access to event payload fields in summary endpoint (#95055)

fixes SENTRY-467N

Author: michellewzhang

src/sentry/replays/endpoints/project_replay_summarize_breadcrumbs.py

@@ -324,7 +324,7 @@ def gen_request_data(
             # Yield the current event's log message
             event_type = which(event)
             if event_type == EventType.FEEDBACK:
-                feedback_id = event["data"]["payload"].get("data", {}).get("feedbackId", None)
+                feedback_id = event["data"]["payload"].get("data", {}).get("feedbackId")
                 feedback = fetch_feedback_details(feedback_id, project_id)
                 if feedback:
                     yield generate_feedback_log_message(feedback)
@@ -374,74 +374,87 @@ def as_log_message(event: dict[str, Any]) -> str | None:
     event_type = which(event)
     timestamp = event.get("timestamp", 0.0)
 
-    match event_type:
-        case EventType.CLICK:
-            return f"User clicked on {event["data"]["payload"]["message"]} at {timestamp}"
-        case EventType.DEAD_CLICK:
-            return f"User clicked on {event["data"]["payload"]["message"]} but the triggered action was slow to complete at {timestamp}"
-        case EventType.RAGE_CLICK:
-            return f"User rage clicked on {event["data"]["payload"]["message"]} but the triggered action was slow to complete at {timestamp}"
-        case EventType.NAVIGATION:
-            return f"User navigated to: {event["data"]["payload"]["data"]["to"]} at {timestamp}"
-        case EventType.CONSOLE:
-            return f"Logged: {event["data"]["payload"]["message"]} at {timestamp}"
-        case EventType.UI_BLUR:
-            timestamp_ms = timestamp * 1000
-            return f"User looked away from the tab at {timestamp_ms}"
-        case EventType.UI_FOCUS:
-            timestamp_ms = timestamp * 1000
-            return f"User returned to tab at {timestamp_ms}"
-        case EventType.RESOURCE_FETCH:
-            timestamp_ms = timestamp * 1000
-            payload = event["data"]["payload"]
-            parsed_url = urlparse(payload["description"])
-
-            path = f"{parsed_url.path}?{parsed_url.query}"
-
-            # Safely get (request_size, response_size)
-            sizes_tuple = parse_network_content_lengths(event)
-            response_size = None
-
-            # Check if the tuple is valid and response size exists
-            if sizes_tuple and sizes_tuple[1] is not None:
-                response_size = str(sizes_tuple[1])
-
-            status_code = payload["data"]["statusCode"]
-            duration = payload["endTimestamp"] - payload["startTimestamp"]
-            method = payload["data"]["method"]
-
-            # if status code is successful, ignore it
-            if str(status_code).startswith("2"):
+    try:
+        match event_type:
+            case EventType.CLICK:
+                message = event["data"]["payload"]["message"]
+                return f"User clicked on {message} at {timestamp}"
+            case EventType.DEAD_CLICK:
+                message = event["data"]["payload"]["message"]
+                return f"User clicked on {message} but the triggered action was slow to complete at {timestamp}"
+            case EventType.RAGE_CLICK:
+                message = event["data"]["payload"]["message"]
+                return f"User rage clicked on {message} but the triggered action was slow to complete at {timestamp}"
+            case EventType.NAVIGATION:
+                to = event["data"]["payload"]["data"]["to"]
+                return f"User navigated to: {to} at {timestamp}"
+            case EventType.CONSOLE:
+                message = event["data"]["payload"]["message"]
+                return f"Logged: {message} at {timestamp}"
+            case EventType.UI_BLUR:
+                timestamp_ms = timestamp * 1000
+                return f"User looked away from the tab at {timestamp_ms}"
+            case EventType.UI_FOCUS:
+                timestamp_ms = timestamp * 1000
+                return f"User returned to tab at {timestamp_ms}"
+            case EventType.RESOURCE_FETCH:
+                timestamp_ms = timestamp * 1000
+                payload = event["data"]["payload"]
+                method = payload["data"]["method"]
+                status_code = payload["data"]["statusCode"]
+                description = payload["description"]
+                duration = payload["endTimestamp"] - payload["startTimestamp"]
+
+                # Parse URL path
+                parsed_url = urlparse(description)
+                path = f"{parsed_url.path}?{parsed_url.query}"
+
+                # Check if the tuple is valid and response size exists
+                sizes_tuple = parse_network_content_lengths(event)
+                response_size = None
+                if sizes_tuple and sizes_tuple[1] is not None:
+                    response_size = str(sizes_tuple[1])
+
+                # Skip successful requests
+                if status_code and str(status_code).startswith("2"):
+                    return None
+
+                if response_size is None:
+                    return f'Application initiated request: "{method} {path} HTTP/2.0" with status code {status_code}; took {duration} milliseconds at {timestamp_ms}'
+                else:
+                    return f'Application initiated request: "{method} {path} HTTP/2.0" with status code {status_code} and response size {response_size}; took {duration} milliseconds at {timestamp_ms}'
+            case EventType.LCP:
+                timestamp_ms = timestamp * 1000
+                duration = event["data"]["payload"]["data"]["size"]
+                rating = event["data"]["payload"]["data"]["rating"]
+                return f"Application largest contentful paint: {duration} ms and has a {rating} rating at {timestamp_ms}"
+            case EventType.FCP:
+                timestamp_ms = timestamp * 1000
+                duration = event["data"]["payload"]["data"]["size"]
+                rating = event["data"]["payload"]["data"]["rating"]
+                return f"Application first contentful paint: {duration} ms and has a {rating} rating at {timestamp_ms}"
+            case EventType.HYDRATION_ERROR:
+                return f"There was a hydration error on the page at {timestamp}"
+            case EventType.RESOURCE_XHR:
                 return None
-
-            if response_size is None:
-                return f'Application initiated request: "{method} {path} HTTP/2.0" with status code {status_code}; took {duration} milliseconds at {timestamp_ms}'
-            else:
-                return f'Application initiated request: "{method} {path} HTTP/2.0" with status code {status_code} and response size {response_size}; took {duration} milliseconds at {timestamp_ms}'
-        case EventType.RESOURCE_XHR:
-            return None
-        case EventType.LCP:
-            timestamp_ms = timestamp * 1000
-            duration = event["data"]["payload"]["data"]["size"]
-            rating = event["data"]["payload"]["data"]["rating"]
-            return f"Application largest contentful paint: {duration} ms and has a {rating} rating at {timestamp_ms}"
-        case EventType.FCP:
-            timestamp_ms = timestamp * 1000
-            duration = event["data"]["payload"]["data"]["size"]
-            rating = event["data"]["payload"]["data"]["rating"]
-            return f"Application first contentful paint: {duration} ms and has a {rating} rating at {timestamp_ms}"
-        case EventType.HYDRATION_ERROR:
-            return f"There was a hydration error on the page at {timestamp}"
-        case EventType.MUTATIONS:
-            return None
-        case EventType.UNKNOWN:
-            return None
-        case EventType.CANVAS:
-            return None
-        case EventType.OPTIONS:
-            return None
-        case EventType.FEEDBACK:
-            return None  # the log message is processed before this method is called
+            case EventType.MUTATIONS:
+                return None
+            case EventType.UNKNOWN:
+                return None
+            case EventType.CANVAS:
+                return None
+            case EventType.OPTIONS:
+                return None
+            case EventType.FEEDBACK:
+                return None  # the log message is processed before this method is called
+    except (KeyError, ValueError):
+        logger.exception(
+            "Error parsing event in replay AI summary",
+            extra={
+                "event": json.dumps(event),
+            },
+        )
+        return None
 
 
 def make_seer_request(request_data: str) -> bytes: