🔧 chore: use IntegrationProviderSlug.Slack instead of magic str (#95390)

Author: iamrajjoshi

src/sentry/identity/slack/provider.py

@@ -1,11 +1,12 @@
 from sentry import options
 from sentry.identity.oauth2 import OAuth2CallbackView, OAuth2LoginView, OAuth2Provider
 from sentry.identity.pipeline import IdentityPipeline
+from sentry.integrations.types import IntegrationProviderSlug
 from sentry.pipeline.views.base import PipelineView
 
 
 class SlackIdentityProvider(OAuth2Provider):
-    key = "slack"
+    key = IntegrationProviderSlug.SLACK.value
     name = "Slack"
 
     # This identity provider is used for authorizing the Slack application
@@ -61,7 +62,7 @@ def build_identity(self, data):
         data = data["data"]
 
         return {
-            "type": "slack",
+            "type": IntegrationProviderSlug.SLACK.value,
             # TODO(epurkhiser): See note above
             "id": data["user"]["id"],
             "email": data["user"]["email"],

src/sentry/integrations/messaging/linkage.py

@@ -20,7 +20,11 @@
 from sentry.integrations.models.external_actor import ExternalActor
 from sentry.integrations.models.integration import Integration
 from sentry.integrations.services.integration import RpcIntegration, integration_service
-from sentry.integrations.types import ExternalProviderEnum, ExternalProviders
+from sentry.integrations.types import (
+    ExternalProviderEnum,
+    ExternalProviders,
+    IntegrationProviderSlug,
+)
 from sentry.integrations.utils.identities import get_identity_or_404
 from sentry.models.organizationmember import OrganizationMember
 from sentry.models.team import Team
@@ -460,7 +464,8 @@ def execute(
         logger_params["team_id"] = team.id
 
         idp = identity_service.get_provider(
-            provider_type="slack", provider_ext_id=integration.external_id
+            provider_type=IntegrationProviderSlug.SLACK.value,
+            provider_ext_id=integration.external_id,
         )
         logger_params["provider_ext_id"] = integration.external_id
         if idp is None:

src/sentry/integrations/slack/actions/notification.py

@@ -32,6 +32,7 @@
 from sentry.integrations.slack.spec import SlackMessagingSpec
 from sentry.integrations.slack.utils.channel import SlackChannelIdData, get_channel_id
 from sentry.integrations.slack.utils.threads import NotificationActionThreadUtils
+from sentry.integrations.types import IntegrationProviderSlug
 from sentry.integrations.utils.metrics import EventLifecycle
 from sentry.issues.grouptype import GroupCategory
 from sentry.models.options.organization_option import OrganizationOption
@@ -51,7 +52,7 @@
 class SlackNotifyServiceAction(IntegrationEventAction):
     id = "sentry.integrations.slack.notify_action.SlackNotifyServiceAction"
     prompt = "Send a Slack notification"
-    provider = "slack"
+    provider = IntegrationProviderSlug.SLACK.value
     integration_key = "workspace"
     label = "Send a notification to the {workspace} Slack workspace to {channel} (optionally, an ID: {channel_id}) and show tags {tags} and notes {notes} in notification"
 

src/sentry/integrations/slack/integration.py

@@ -132,7 +132,7 @@ class SlackIntegrationProvider(IntegrationProvider):
     def _identity_pipeline_view(self) -> PipelineView[IntegrationPipeline]:
         return NestedPipelineView(
             bind_key="identity",
-            provider_key="slack",
+            provider_key=IntegrationProviderSlug.SLACK.value,
             pipeline_cls=IdentityPipeline,
             config={
                 "oauth_scopes": self.identity_oauth_scopes,
@@ -184,7 +184,7 @@ def build_integration(self, state: Mapping[str, Any]) -> IntegrationData:
             "external_id": team_id,
             "metadata": metadata,
             "user_identity": {
-                "type": "slack",
+                "type": IntegrationProviderSlug.SLACK.value,
                 "external_id": user_id_slack,
                 "scopes": [],
                 "data": {},

src/sentry/integrations/slack/requests/base.py

@@ -15,6 +15,7 @@
 from sentry.identity.services.identity.model import RpcIdentityProvider
 from sentry.integrations.messaging.commands import CommandInput
 from sentry.integrations.services.integration import RpcIntegration, integration_service
+from sentry.integrations.types import IntegrationProviderSlug
 from sentry.users.services.user import RpcUser
 from sentry.users.services.user.service import user_service
 from sentry.utils.safe import get_path
@@ -99,7 +100,7 @@ def _get_context(self):
         except Exception:
             pass
         context = integration_service.get_integration_identity_context(
-            integration_provider="slack",
+            integration_provider=IntegrationProviderSlug.SLACK.value,
             integration_external_id=team_id,
             identity_external_id=user_id,
             identity_provider_external_id=team_id,
@@ -162,7 +163,7 @@ def get_identity(self) -> RpcIdentity | None:
 
         if self._provider is None:
             self._provider = identity_service.get_provider(
-                provider_type="slack", provider_ext_id=self.team_id
+                provider_type=IntegrationProviderSlug.SLACK.value, provider_ext_id=self.team_id
             )
 
         if self._provider is not None:
@@ -225,7 +226,9 @@ def _check_verification_token(self, verification_token: str) -> bool:
     def validate_integration(self) -> None:
         if not self._integration:
             self._integration = integration_service.get_integration(
-                provider="slack", external_id=self.team_id, status=ObjectStatus.ACTIVE
+                provider=IntegrationProviderSlug.SLACK.value,
+                external_id=self.team_id,
+                status=ObjectStatus.ACTIVE,
             )
 
         if not self._integration:

src/sentry/integrations/slack/sdk_client.py

@@ -11,6 +11,7 @@
 from sentry.integrations.models import Integration
 from sentry.integrations.services.integration import integration_service
 from sentry.integrations.services.integration.model import RpcIntegration
+from sentry.integrations.types import IntegrationProviderSlug
 from sentry.silo.base import SiloMode
 from sentry.utils import metrics
 
@@ -32,7 +33,7 @@ def track_response_data(response: SlackResponse, method: str, error: str | None
     )
 
     extra = {
-        "integration": "slack",
+        "integration": IntegrationProviderSlug.SLACK.value,
         "status_string": str(code),
         "error": error,
         "method": method,

src/sentry/integrations/slack/spec.py

@@ -12,6 +12,7 @@
     MessagingIdentityLinkViewSet,
     MessagingIntegrationSpec,
 )
+from sentry.integrations.types import IntegrationProviderSlug
 from sentry.models.organization import Organization
 from sentry.notifications.models.notificationaction import ActionService
 from sentry.rules.actions import IntegrationEventAction
@@ -20,7 +21,7 @@
 class SlackMessagingSpec(MessagingIntegrationSpec):
     @property
     def provider_slug(self) -> str:
-        return "slack"
+        return IntegrationProviderSlug.SLACK.value
 
     @property
     def action_service(self) -> ActionService:

src/sentry/integrations/slack/tasks/find_channel_id_for_alert_rule.py

@@ -15,6 +15,7 @@
 from sentry.incidents.serializers import AlertRuleSerializer
 from sentry.integrations.slack.utils.constants import SLACK_RATE_LIMITED_MESSAGE
 from sentry.integrations.slack.utils.rule_status import RedisRuleStatus
+from sentry.integrations.types import IntegrationProviderSlug
 from sentry.models.organization import Organization
 from sentry.shared_integrations.exceptions import ApiRateLimitedError
 from sentry.silo.base import SiloMode
@@ -85,7 +86,7 @@ def find_channel_id_for_alert_rule(
 
     for trigger in data["triggers"]:
         for action in trigger["actions"]:
-            if action["type"] == "slack":
+            if action["type"] == IntegrationProviderSlug.SLACK.value:
                 if action["targetIdentifier"] in mapped_ids:
                     action["input_channel_id"] = mapped_ids[action["targetIdentifier"]]
                     # This will conflict within the CamelCaseSerializer below.

src/sentry/integrations/slack/tasks/find_channel_id_for_rule.py

@@ -10,6 +10,7 @@
 )
 from sentry.integrations.slack.utils.constants import SLACK_RATE_LIMITED_MESSAGE
 from sentry.integrations.slack.utils.rule_status import RedisRuleStatus
+from sentry.integrations.types import IntegrationProviderSlug
 from sentry.models.project import Project
 from sentry.models.rule import Rule, RuleActivity, RuleActivityType
 from sentry.projects.project_rules.creator import ProjectRuleCreator
@@ -60,7 +61,9 @@ def find_channel_id_for_rule(
             break
 
     integrations = integration_service.get_integrations(
-        organization_id=organization.id, providers=["slack"], integration_ids=[integration_id]
+        organization_id=organization.id,
+        providers=[IntegrationProviderSlug.SLACK.value],
+        integration_ids=[integration_id],
     )
     if not integrations:
         redis_rule_status.set_value("failed")

src/sentry/integrations/slack/webhooks/action.py

@@ -37,7 +37,7 @@
 from sentry.integrations.slack.sdk_client import SlackSdkClient
 from sentry.integrations.slack.spec import SlackMessagingSpec
 from sentry.integrations.slack.utils.errors import MODAL_NOT_FOUND, unpack_slack_api_error
-from sentry.integrations.types import ExternalProviderEnum
+from sentry.integrations.types import ExternalProviderEnum, IntegrationProviderSlug
 from sentry.integrations.utils.scope import bind_org_context_from_integration
 from sentry.models.activity import ActivityIntegration
 from sentry.models.group import Group
@@ -702,7 +702,9 @@ def handle_member_approval(self, slack_request: SlackActionRequest, action: str)
         original_status = InviteStatus(member.invite_status)
         try:
             if action == "approve_member":
-                member.approve_member_invitation(identity_user, referrer="slack")
+                member.approve_member_invitation(
+                    identity_user, referrer=IntegrationProviderSlug.SLACK.value
+                )
             else:
                 member.reject_member_invitation(identity_user)
         except Exception: