Skip to content

Commit 7a5e476

Browse files
ref(feedback): display name in list when no email (#59158)
- grab the name from the issues `metadata` object instead - when the user doesn't have an email, show the name instead in the list <img width="411" alt="SCR-20231031-npst" src="https://github.com/getsentry/sentry/assets/56095982/a9030c33-36fc-4387-9a9d-ae44711fe54a"> details view is still the same, showing "No Email" or "No Name" <img width="682" alt="SCR-20231031-nqja" src="https://github.com/getsentry/sentry/assets/56095982/fbc66e15-1fe9-4848-baf7-1c065c5a0133"> <img width="302" alt="SCR-20231031-nqpu" src="https://github.com/getsentry/sentry/assets/56095982/185d5c6c-c9da-43bf-b094-8f70b4f2bc42">
1 parent 39ed9f2 commit 7a5e476

File tree

2 files changed

+5
-14
lines changed

2 files changed

+5
-14
lines changed

static/app/components/feedback/feedbackItem/feedbackItem.tsx

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -66,11 +66,7 @@ export default function FeedbackItem({
6666
<Flex gap={space(2)} justify="space-between">
6767
<Flex column>
6868
<Flex align="center" gap={space(0.5)}>
69-
<FeedbackItemUsername
70-
feedbackIssue={feedbackItem}
71-
feedbackEvent={eventData}
72-
detailDisplay
73-
/>
69+
<FeedbackItemUsername feedbackIssue={feedbackItem} detailDisplay />
7470
{feedbackItem.metadata.contact_email ? (
7571
<CopyToClipboardButton
7672
size="xs"

static/app/components/feedback/feedbackItem/feedbackItemUsername.tsx

Lines changed: 4 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -2,20 +2,15 @@ import styled from '@emotion/styled';
22

33
import {t} from 'sentry/locale';
44
import {space} from 'sentry/styles/space';
5-
import type {FeedbackEvent, FeedbackIssue} from 'sentry/utils/feedback/types';
5+
import type {FeedbackIssue} from 'sentry/utils/feedback/types';
66

77
interface Props {
88
detailDisplay: boolean;
99
feedbackIssue: FeedbackIssue;
10-
feedbackEvent?: FeedbackEvent | undefined;
1110
}
1211

13-
export default function FeedbackItemUsername({
14-
feedbackIssue,
15-
feedbackEvent,
16-
detailDisplay,
17-
}: Props) {
18-
const name = feedbackEvent?.contexts?.feedback?.name;
12+
export default function FeedbackItemUsername({feedbackIssue, detailDisplay}: Props) {
13+
const name = feedbackIssue.metadata.name;
1914
const email = feedbackIssue.metadata.contact_email;
2015

2116
if (!email && !name) {
@@ -32,7 +27,7 @@ export default function FeedbackItemUsername({
3227
);
3328
}
3429

35-
return <strong>{email}</strong>;
30+
return <strong>{name ?? email}</strong>;
3631
}
3732

3833
const Purple = styled('span')`

0 commit comments

Comments
 (0)