Skip to content

Commit 77fb305

Browse files
authored
fix(issues): Remove stream_index analytic query param (#95722)
1 parent 33f4fdd commit 77fb305

File tree

8 files changed

+6
-21
lines changed

8 files changed

+6
-21
lines changed

static/app/components/eventOrGroupHeader.tsx

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,6 @@ interface EventOrGroupHeaderProps {
2626
eventId?: string;
2727
hideIcons?: boolean;
2828
hideLevel?: boolean;
29-
index?: number;
3029
/** Group link clicked */
3130
onClick?: () => void;
3231
query?: string;
@@ -76,7 +75,6 @@ function usePreloadGroupOnHover({
7675
*/
7776
function EventOrGroupHeader({
7877
data,
79-
index,
8078
query,
8179
onClick,
8280
hideIcons,
@@ -126,7 +124,6 @@ function EventOrGroupHeader({
126124
data,
127125
eventId,
128126
referrer: source,
129-
streamIndex: index,
130127
location,
131128
query,
132129
});

static/app/components/stream/group.spec.tsx

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -237,7 +237,6 @@ describe('StreamGroup', function () {
237237
project: '13',
238238
query: 'is:unresolved is:for_review assigned_or_suggested:[me, none]',
239239
referrer: 'issue-stream',
240-
stream_index: undefined,
241240
},
242241
});
243242
});

static/app/components/stream/group.tsx

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -71,7 +71,6 @@ type Props = {
7171
customStatsPeriod?: TimePeriodType;
7272
displayReprocessingLayout?: boolean;
7373
hasGuideAnchor?: boolean;
74-
index?: number;
7574
memberList?: User[];
7675
onPriorityChange?: (newPriority: PriorityLevel) => void;
7776
query?: string;
@@ -186,7 +185,6 @@ function StreamGroup({
186185
customStatsPeriod,
187186
displayReprocessingLayout,
188187
hasGuideAnchor,
189-
index,
190188
memberList,
191189
query,
192190
queryFilterDescription,
@@ -367,7 +365,6 @@ function StreamGroup({
367365
pathname: `/organizations/${organization.slug}/issues/${group.id}/events/`,
368366
query: {
369367
referrer,
370-
stream_index: index,
371368
...commonQuery,
372369
query: filteredQuery,
373370
},
@@ -559,7 +556,6 @@ function StreamGroup({
559556
data: group,
560557
organization,
561558
referrer,
562-
streamIndex: index,
563559
location,
564560
query,
565561
})
@@ -583,7 +579,7 @@ function StreamGroup({
583579
/>
584580
)}
585581
<GroupSummary canSelect={canSelect}>
586-
<EventOrGroupHeader index={index} data={group} query={query} source={referrer} />
582+
<EventOrGroupHeader data={group} query={query} source={referrer} />
587583
<EventOrGroupExtraDetails data={group} showLifetime={false} />
588584
</GroupSummary>
589585
{hasGuideAnchor && <GuideAnchor target="issue_stream" />}

static/app/views/alerts/rules/issue/previewTable.tsx

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -56,12 +56,11 @@ function PreviewTable({
5656
);
5757
}
5858
const memberList = indexMembersByProject(members);
59-
return previewGroups.map((id, index) => {
59+
return previewGroups.map(id => {
6060
const group = GroupStore.get(id) as Group | undefined;
6161

6262
return (
6363
<StreamGroup
64-
index={index}
6564
key={id}
6665
id={id}
6766
hasGuideAnchor={false}

static/app/views/insights/sessions/charts/chartWithIssues.tsx

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -101,9 +101,9 @@ export default function ChartWithIssues(props: Props) {
101101

102102
const footer = hasData && recentIssues && (
103103
<FooterIssues>
104-
{recentIssues.map((group, index) => (
104+
{recentIssues.map(group => (
105105
<GroupWrapper canSelect key={group.id}>
106-
<EventOrGroupHeader index={index} data={group} source={'session-health'} />
106+
<EventOrGroupHeader data={group} source={'session-health'} />
107107
<EventOrGroupExtraDetails data={group} showLifetime={false} />
108108
</GroupWrapper>
109109
))}

static/app/views/issueDetails/groupDetails.tsx

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -519,8 +519,7 @@ function useTrackView({
519519
project?: Project;
520520
}) {
521521
const location = useLocation();
522-
const {alert_date, alert_rule_id, alert_type, ref_fallback, stream_index, query} =
523-
location.query;
522+
const {alert_date, alert_rule_id, alert_type, ref_fallback, query} = location.query;
524523
const groupEventType = useLoadedEventType();
525524
const user = useUser();
526525
const hasStreamlinedUI = useHasStreamlinedUI();
@@ -531,7 +530,6 @@ function useTrackView({
531530
...getAnalyticsDataForEvent(event),
532531
...getAnalyicsDataForProject(project),
533532
tab,
534-
stream_index: typeof stream_index === 'string' ? Number(stream_index) : undefined,
535533
query: typeof query === 'string' ? query : undefined,
536534
// Alert properties track if the user came from email/slack alerts
537535
alert_date:

static/app/views/issueList/groupListBody.tsx

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -117,13 +117,12 @@ function GroupList({
117117

118118
return (
119119
<PanelBody>
120-
{groupIds.map((id, index) => {
120+
{groupIds.map(id => {
121121
const hasGuideAnchor = id === topIssue;
122122
const group = GroupStore.get(id) as Group | undefined;
123123

124124
return (
125125
<StreamGroup
126-
index={index}
127126
key={id}
128127
id={id}
129128
statsPeriod={groupStatsPeriod}

static/app/views/issueList/utils.tsx

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -233,7 +233,6 @@ export function createIssueLink({
233233
data,
234234
eventId,
235235
referrer,
236-
streamIndex,
237236
location,
238237
query,
239238
}: {
@@ -243,7 +242,6 @@ export function createIssueLink({
243242
eventId?: string;
244243
query?: string;
245244
referrer?: string;
246-
streamIndex?: number;
247245
}): LocationDescriptorObject {
248246
const {id, project} = data as Group;
249247
const {eventID: latestEventId, groupID} = data as Event;
@@ -257,7 +255,6 @@ export function createIssueLink({
257255
}/${finalEventId ? `events/${finalEventId}/` : ''}`,
258256
query: {
259257
referrer: referrer || 'event-or-group-header',
260-
stream_index: streamIndex,
261258
query,
262259
// Add environment to the query if it was selected
263260
...(location.query.environment === undefined

0 commit comments

Comments
 (0)