fix(billing): don't use seat category for usage stats link (#95675)

Fixes JAVASCRIPT-32AZ

Author: isabellaenriquez

static/gsApp/components/gsBanner.spec.tsx

@@ -2168,4 +2168,67 @@ describe('GSBanner Overage Alerts', function () {
       )
     ).toBe(false);
   });
+
+  it('shows see usage button for overages that are not strictly seat-based', async function () {
+    const organization = OrganizationFixture();
+    const subscription = SubscriptionFixture({
+      organization,
+      plan: 'am3_team',
+      categories: {
+        monitorSeats: MetricHistoryFixture({usageExceeded: true}),
+        profileDuration: MetricHistoryFixture({usageExceeded: true}),
+      },
+      onDemandPeriodStart: '2025-01-01',
+      onDemandPeriodEnd: '2025-01-31',
+    });
+    SubscriptionStore.set(organization.slug, subscription);
+
+    const {router} = render(<GSBanner organization={organization} />, {
+      organization,
+    });
+
+    expect(
+      await screen.findByTestId('overage-banner-monitorSeat-profileDuration')
+    ).toBeInTheDocument();
+
+    const seeUsageButton = await screen.findByRole('button', {name: 'See Usage'});
+    await userEvent.click(seeUsageButton);
+
+    expect(router.location).toEqual(
+      expect.objectContaining({
+        pathname: `/organizations/${organization.slug}/stats/`,
+        query: {
+          dataCategory: 'profileDuration', // doesn't use monitorSeat because it does not have a stats page
+          pageStart: '2025-01-01',
+          pageEnd: '2025-01-31',
+          pageUtc: 'true',
+        },
+      })
+    );
+  });
+
+  it('does not show see usage button for overages that are strictly seat-based', async function () {
+    const organization = OrganizationFixture();
+    const subscription = SubscriptionFixture({
+      organization,
+      plan: 'am3_team',
+      categories: {
+        monitorSeats: MetricHistoryFixture({usageExceeded: true}),
+        uptime: MetricHistoryFixture({usageExceeded: true}),
+      },
+      onDemandPeriodStart: '2025-01-01',
+      onDemandPeriodEnd: '2025-01-31',
+    });
+    SubscriptionStore.set(organization.slug, subscription);
+
+    render(<GSBanner organization={organization} />, {
+      organization,
+    });
+
+    expect(
+      await screen.findByTestId('overage-banner-monitorSeat-uptime')
+    ).toBeInTheDocument();
+
+    expect(screen.queryByRole('button', {name: 'See Usage'})).not.toBeInTheDocument();
+  });
 });

static/gsApp/components/gsBanner.tsx

@@ -902,14 +902,10 @@ class GSBanner extends Component<Props, State> {
         .map(([key, _]) => key as EventType);
 
       // Make an exception for when only seat-based categories have an overage to disable the See Usage button
-      strictlySeatOverage =
-        eventTypes.length <= 2 &&
-        every(eventTypes, eventType =>
-          [
-            DATA_CATEGORY_INFO.monitor_seat.singular as EventType,
-            DATA_CATEGORY_INFO.uptime.singular as EventType,
-          ].includes(eventType)
-        );
+      strictlySeatOverage = every(
+        eventTypes,
+        eventType => getCategoryInfoFromEventType(eventType)?.tallyType === 'seat'
+      );
 
       // Make an exception for when only crons has an overage to change the language to be more fitting and hide See Usage
       if (strictlySeatOverage) {
@@ -946,6 +942,15 @@ class GSBanner extends Component<Props, State> {
       return null;
     }
 
+    // we should only ever specify an event type that has an external stats page
+    // in the stats link
+    const eventTypeForStatsPage = strictlySeatOverage
+      ? null
+      : (eventTypes.find(
+          eventType =>
+            getCategoryInfoFromEventType(eventType)?.statsInfo.showExternalStats
+        ) ?? null);
+
     return (
       <Alert
         system
@@ -957,7 +962,7 @@ class GSBanner extends Component<Props, State> {
             {!strictlySeatOverage && (
               <LinkButton
                 size="xs"
-                to={`/organizations/${organization.slug}/stats/?dataCategory=${eventTypes[0]}s&pageStart=${subscription.onDemandPeriodStart}&pageEnd=${subscription.onDemandPeriodEnd}&pageUtc=true`}
+                to={`/organizations/${organization.slug}/stats/?${eventTypeForStatsPage ? `dataCategory=${eventTypeForStatsPage}&` : ''}pageStart=${subscription.onDemandPeriodStart}&pageEnd=${subscription.onDemandPeriodEnd}&pageUtc=true`}
                 onClick={() => {
                   trackGetsentryAnalytics('quota_alert.clicked_see_usage', {
                     organization,