Merge branch 'master' into tkdodo/ref/decouple-button-tracking

Author: TkDodo

src/sentry/autofix/utils.py

@@ -176,7 +176,7 @@ def is_seer_scanner_rate_limited(
     if features.has("organizations:unlimited-auto-triggered-autofix-runs", organization):
         return False, 0, 0
 
-    limit = options.get("seer.max_num_scanner_autotriggered_per_hour", 1000)
+    limit = options.get("seer.max_num_scanner_autotriggered_per_hour", 2500)
     is_rate_limited, current, _ = ratelimits.backend.is_limited_with_value(
         project=project,
         key="seer.scanner.auto_triggered",

src/sentry/grouping/parameterization.py

@@ -123,7 +123,7 @@ def compiled_pattern(self) -> re.Pattern[str]:
             (\d{4}-?[01]\d-?[0-3]\d\s[0-2]\d:[0-5]\d:[0-5]\d)(\.\d+)?
             |
             # Kitchen
-            (\d{1,2}:\d{2}(:\d{2})?(?: [aApP][Mm])?)
+            ([1-9]\d?:\d{2}(:\d{2})?(?: [aApP][Mm])?)
             |
             # Date
             (\d{4}-[01]\d-[0-3]\d)

src/sentry/options/defaults.py

@@ -603,7 +603,7 @@
 register("seer.max_num_autofix_autotriggered_per_hour", default=20, flags=FLAG_AUTOMATOR_MODIFIABLE)
 # Seer Scanner Auto-trigger rate (max number of scans auto-triggered per project per hour)
 register(
-    "seer.max_num_scanner_autotriggered_per_hour", default=1000, flags=FLAG_AUTOMATOR_MODIFIABLE
+    "seer.max_num_scanner_autotriggered_per_hour", default=2500, flags=FLAG_AUTOMATOR_MODIFIABLE
 )
 
 # Codecov Integration

src/sentry/profiles/task.py

@@ -1314,11 +1314,12 @@ def _process_vroomrs_chunk_profile(profile: Profile) -> bool:
                 functions = chunk.extract_functions_metrics(
                     min_depth=1, filter_system_frames=True, max_unique_functions=100
                 )
-                payload = build_chunk_functions_kafka_message(chunk, functions)
-                topic = ArroyoTopic(
-                    get_topic_definition(Topic.PROFILES_CALL_TREE)["real_topic_name"]
-                )
-                profile_functions_producer.produce(topic, payload)
+                if functions is not None and len(functions) > 0:
+                    payload = build_chunk_functions_kafka_message(chunk, functions)
+                    topic = ArroyoTopic(
+                        get_topic_definition(Topic.PROFILES_CALL_TREE)["real_topic_name"]
+                    )
+                    profile_functions_producer.produce(topic, payload)
             return True
         except Exception as e:
             sentry_sdk.capture_exception(e)

src/sentry/tasks/post_process.py

@@ -1600,6 +1600,15 @@ def kick_off_seer_automation(job: PostProcessJob) -> None:
     if not seer_enabled:
         return
 
+    from sentry import quotas
+    from sentry.constants import DataCategory
+
+    has_budget: bool = quotas.backend.has_available_reserved_budget(
+        org_id=group.organization.id, data_category=DataCategory.SEER_SCANNER
+    )
+    if not has_budget:
+        return
+
     from sentry.autofix.utils import is_seer_scanner_rate_limited
 
     is_rate_limited, current, limit = is_seer_scanner_rate_limited(project, group.organization)
@@ -1613,15 +1622,6 @@ def kick_off_seer_automation(job: PostProcessJob) -> None:
         logger.error("Seer scanner auto-trigger rate limit hit")
         return
 
-    from sentry import quotas
-    from sentry.constants import DataCategory
-
-    has_budget: bool = quotas.backend.has_available_reserved_budget(
-        org_id=group.organization.id, data_category=DataCategory.SEER_SCANNER
-    )
-    if not has_budget:
-        return
-
     start_seer_automation.delay(group.id)
 
 

src/sentry/tasks/statistical_detectors.py

@@ -430,6 +430,7 @@ def _detect_transaction_change_points(
     max_retries=0,
     taskworker_config=TaskworkerConfig(
         namespace=profiling_tasks,
+        processing_deadline_duration=30,
     ),
 )
 def detect_function_trends(project_ids: list[int], start: str, *args, **kwargs) -> None:

src/sentry/users/api/endpoints/user_details.py

@@ -82,6 +82,7 @@ class UserOptionsSerializer(serializers.Serializer[UserOption]):
     prefersNextjsInsightsOverview = serializers.BooleanField(required=False)
     prefersStackedNavigation = serializers.BooleanField(required=False)
     prefersChonkUI = serializers.BooleanField(required=False)
+    prefersAgentsInsightsModule = serializers.BooleanField(required=False)
 
     quickStartDisplay = serializers.JSONField(
         required=False,
@@ -260,6 +261,7 @@ def put(self, request: Request, user: User) -> Response:
             "prefersStackedNavigation": "prefers_stacked_navigation",
             "prefersNextjsInsightsOverview": "prefers_nextjs_insights_overview",
             "prefersChonkUI": "prefers_chonk_ui",
+            "prefersAgentsInsightsModule": "prefers_agents_insights_module",
             "quickStartDisplay": "quick_start_display",
         }
 

src/sentry/users/api/serializers/user.py

@@ -69,6 +69,7 @@ class _UserOptions(TypedDict):
     prefersStackedNavigation: bool | None
     prefersChonkUI: bool
     quickStartDisplay: dict[str, int]
+    prefersAgentsInsightsModule: bool
 
 
 class UserSerializerResponseOptional(TypedDict, total=False):
@@ -208,6 +209,7 @@ def serialize(
                 "prefersStackedNavigation": options.get("prefers_stacked_navigation"),
                 "prefersChonkUI": options.get("prefers_chonk_ui", False),
                 "quickStartDisplay": options.get("quick_start_display") or {},
+                "prefersAgentsInsightsModule": options.get("prefers_agents_insights_module", True),
             }
 
             d["flags"] = {"newsletter_consent_prompt": bool(obj.flags.newsletter_consent_prompt)}

src/sentry/users/models/user_option.py

@@ -169,6 +169,8 @@ class UserOption(Model):
         - Whether the user prefers the new stacked navigation experience (boolean)
     - prefers_nextjs_insights_overview
         - Whether the user prefers the new NextJS insights overview experience (boolean)
+    - prefers_agents_insights_module
+        - Whether the user prefers the new Agents insights module experience (boolean)
      - prefers_chonk_ui
         - Whether the user prefers the new Chonk UI experience (boolean)
      - quick_start_display

static/app/components/sidebar/index.tsx

@@ -52,7 +52,7 @@ import {useLocation} from 'sentry/utils/useLocation';
 import useMedia from 'sentry/utils/useMedia';
 import useOrganization from 'sentry/utils/useOrganization';
 import {makeAlertsPathname} from 'sentry/views/alerts/pathnames';
-import {AgentInsightsFeature} from 'sentry/views/insights/agentMonitoring/utils/features';
+import {AIInsightsFeature} from 'sentry/views/insights/agentMonitoring/utils/features';
 import {MODULE_BASE_URLS} from 'sentry/views/insights/common/utils/useModuleURL';
 import {
   AGENTS_LANDING_SUB_PATH,
@@ -373,7 +373,7 @@ function Sidebar() {
           id="performance-domains-mobile"
           icon={<SubitemDot collapsed />}
         />
-        <AgentInsightsFeature
+        <AIInsightsFeature
           organization={organization}
           renderDisabled={() => (
             <SidebarItem
@@ -392,7 +392,7 @@ function Sidebar() {
             id="performance-domains-agents"
             icon={<SubitemDot collapsed />}
           />
-        </AgentInsightsFeature>
+        </AIInsightsFeature>
         <SidebarItem
           {...sidebarItemProps}
           label={t('Crons')}