Skip to content

Commit 6d47287

Browse files
ref: add types-docker (#95245)
<!-- Describe your PR here. -->
1 parent 15ac892 commit 6d47287

File tree

4 files changed

+6
-5
lines changed

4 files changed

+6
-5
lines changed

pyproject.toml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -88,7 +88,6 @@ module = [
8888
"confluent_kafka.*",
8989
"cssselect.*",
9090
"django_zero_downtime_migrations.backends.postgres.schema.*",
91-
"docker.*",
9291
"fido2.*",
9392
"google.auth.*",
9493
"google.cloud.*",

requirements-dev-frozen.txt

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -217,6 +217,7 @@ trio==0.25.0
217217
trio-websocket==0.11.1
218218
types-beautifulsoup4==4.11.6
219219
types-cachetools==5.3.0.5
220+
types-docker==7.1.0.20250705
220221
types-jsonschema==4.16.1
221222
types-oauthlib==3.2.0.8
222223
types-parsimonious==0.10.0.8

requirements-dev.txt

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -46,6 +46,7 @@ msgpack-types>=0.2.0
4646
mypy>=1.15
4747
types-beautifulsoup4
4848
types-cachetools
49+
types-docker
4950
types-jsonschema
5051
types-oauthlib
5152
types-parsimonious

src/sentry/runner/commands/devservices.py

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -374,18 +374,18 @@ def up(
374374
# in case there are dependencies needed for the health
375375
# check (for example: kafka's healthcheck requires zookeeper)
376376
with ThreadPoolExecutor(max_workers=len(selected_services)) as executor:
377-
futures = []
377+
health_futures = []
378378
for name in selected_services:
379-
futures.append(
379+
health_futures.append(
380380
executor.submit(
381381
check_health,
382382
name,
383383
containers[name],
384384
)
385385
)
386-
for future in as_completed(futures):
386+
for health_future in as_completed(health_futures):
387387
try:
388-
future.result()
388+
health_future.result()
389389
except Exception as e:
390390
click.secho(f"> Failed to check health: {e}", err=True, fg="red")
391391
raise

0 commit comments

Comments
 (0)