Skip to content

Commit 6aaed5c

Browse files
roagaandrewshie-sentry
authored andcommitted
fix(autofix): Add feature flag check for starred view onboarding step (#95455)
We were missing the feature flag check for this onboarding step, causing an unusable step
1 parent 88519b0 commit 6aaed5c

File tree

2 files changed

+5
-3
lines changed

2 files changed

+5
-3
lines changed

static/app/views/issueDetails/streamline/sidebar/seerNotices.spec.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -127,7 +127,7 @@ describe('SeerNotices', function () {
127127
render(<SeerNotices groupId="123" hasGithubIntegration project={project} />, {
128128
organization: {
129129
...organization,
130-
features: ['trigger-autofix-on-issue-summary'],
130+
features: ['trigger-autofix-on-issue-summary', 'issue-views'],
131131
},
132132
});
133133
await waitFor(() => {

static/app/views/issueDetails/streamline/sidebar/seerNotices.tsx

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -23,6 +23,7 @@ import {FieldKey} from 'sentry/utils/fields';
2323
import {useDetailedProject} from 'sentry/utils/useDetailedProject';
2424
import {useLocalStorageState} from 'sentry/utils/useLocalStorageState';
2525
import useOrganization from 'sentry/utils/useOrganization';
26+
import {useHasIssueViews} from 'sentry/views/nav/secondary/sections/issues/issueViews/useHasIssueViews';
2627
import {useStarredIssueViews} from 'sentry/views/nav/secondary/sections/issues/issueViews/useStarredIssueViews';
2728
import {usePrefersStackedNav} from 'sentry/views/nav/usePrefersStackedNav';
2829

@@ -74,8 +75,9 @@ export function SeerNotices({groupId, hasGithubIntegration, project}: SeerNotice
7475
const isAutomationAllowed = organization.features.includes(
7576
'trigger-autofix-on-issue-summary'
7677
);
77-
const prefersStackedNav = usePrefersStackedNav();
78-
const isStarredViewAllowed = prefersStackedNav;
78+
const hasStackedNav = usePrefersStackedNav();
79+
const hasIssueViews = useHasIssueViews();
80+
const isStarredViewAllowed = hasStackedNav && hasIssueViews;
7981

8082
const unreadableRepos = repos.filter(repo => repo.is_readable === false);
8183
const githubRepos = unreadableRepos.filter(repo => repo.provider.includes('github'));

0 commit comments

Comments
 (0)