Skip to content

Commit 5c94383

Browse files
authored
fix(tasks): Deflake task parameter size test (#95736)
A float representation of the current time, rendered to JSON, isn't fixed size. It's usually sized by clock precision, but since we don't have trailing zeros, rounder numbers are smaller. Fixes #94920.
1 parent 915fc9c commit 5c94383

File tree

1 file changed

+3
-1
lines changed

1 file changed

+3
-1
lines changed

tests/sentry/tasks/test_base.py

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,7 @@
88
from sentry.tasks.base import instrumented_task, retry
99
from sentry.taskworker.config import TaskworkerConfig
1010
from sentry.taskworker.namespaces import test_tasks
11+
from sentry.testutils.helpers.datetime import freeze_time
1112
from sentry.testutils.helpers.options import override_options
1213

1314

@@ -125,12 +126,13 @@ def test_exclude_exception_retry(capture_exception):
125126
}
126127
)
127128
@patch("sentry.tasks.base.metrics.distribution")
129+
@freeze_time("2025-01-01 00:00:00") # so size of params isn't impacted by current time.
128130
def test_capture_payload_metrics(mock_distribution):
129131
region_task.apply_async(args=("bruh",))
130132

131133
mock_distribution.assert_called_once_with(
132134
"celery.task.parameter_bytes",
133-
71,
135+
66,
134136
tags={"taskname": "test.tasks.test_base.region_task"},
135137
sample_rate=1.0,
136138
)

0 commit comments

Comments
 (0)