update tests

Author: DominikB2014

static/app/views/insights/database/views/databaseSpanSummaryPage.spec.tsx

@@ -166,6 +166,12 @@ describe('DatabaseSpanSummaryPage', function () {
       },
     });
 
+    MockApiClient.addMockResponse({
+      url: `/projects/org-slug//releases/1.0.0/`,
+      method: 'GET',
+      body: [],
+    });
+
     const issuesRequestMock = MockApiClient.addMockResponse({
       url: `/organizations/${organization.slug}/issues/`,
       method: 'GET',
@@ -224,7 +230,6 @@ describe('DatabaseSpanSummaryPage', function () {
           environment: [],
           field: [
             'project_id',
-            'transaction.id',
             'span.description',
             'db.system',
             'code.filepath',
@@ -327,7 +332,7 @@ describe('DatabaseSpanSummaryPage', function () {
       })
     );
 
-    expect(spanDescriptionRequestMock).toHaveBeenCalledTimes(1);
+    expect(spanDescriptionRequestMock).toHaveBeenCalledTimes(2);
     expect(eventsRequestMock).toHaveBeenCalledTimes(1);
     expect(eventsStatsRequestMock).toHaveBeenCalledTimes(2);
     expect(transactionListMock).toHaveBeenCalledTimes(1);
@@ -351,26 +356,6 @@ describe('DatabaseSpanSummaryPage', function () {
       })
     );
 
-    // Span details for query source. This runs after the indexed span has loaded
-    expect(eventsRequestMock).toHaveBeenNthCalledWith(
-      2,
-      `/organizations/${organization.slug}/events/`,
-      expect.objectContaining({
-        method: 'GET',
-        query: {
-          dataset: 'spansIndexed',
-          environment: [],
-          field: ['timestamp', 'transaction.id', 'project', 'span_id', 'span.self_time'],
-          per_page: 1,
-          project: [],
-          query: 'span.group:1756baf8fd19c116',
-          sort: '-span.self_time',
-          referrer: 'api.starfish.full-span-from-trace',
-          statsPeriod: '10d',
-        },
-      })
-    );
-
     expect(screen.getByRole('table', {name: 'Transactions'})).toBeInTheDocument();
 
     expect(screen.getByRole('columnheader', {name: 'Found In'})).toBeInTheDocument();

static/app/views/insights/queues/components/messageSpanSamplesPanel.spec.tsx

@@ -16,7 +16,7 @@ describe('messageSpanSamplesPanel', () => {
   let eventsRequestMock: jest.Mock;
   let eventsStatsRequestMock: jest.Mock;
   let samplesRequestMock: jest.Mock;
-  let spanFieldTagsMock: jest.Mock;
+  let traceItemAttributesMock: jest.Mock;
 
   jest.mocked(usePageFilters).mockReturnValue(
     PageFilterStateFixture({
@@ -124,8 +124,8 @@ describe('messageSpanSamplesPanel', () => {
       },
     });
 
-    spanFieldTagsMock = MockApiClient.addMockResponse({
-      url: `/organizations/${organization.slug}/spans/fields/`,
+    traceItemAttributesMock = MockApiClient.addMockResponse({
+      url: `/organizations/${organization.slug}/trace-items/attributes/`,
       method: 'GET',
       body: [
         {
@@ -139,11 +139,6 @@ describe('messageSpanSamplesPanel', () => {
       ],
     });
 
-    MockApiClient.addMockResponse({
-      url: '/organizations/org-slug/trace-items/attributes/',
-      body: [],
-    });
-
     MockApiClient.addMockResponse({
       url: `/organizations/${organization.slug}/recent-searches/`,
       body: [],
@@ -230,15 +225,31 @@ describe('messageSpanSamplesPanel', () => {
         }),
       })
     );
-    expect(spanFieldTagsMock).toHaveBeenNthCalledWith(
+    expect(traceItemAttributesMock).toHaveBeenNthCalledWith(
       1,
-      `/organizations/${organization.slug}/spans/fields/`,
+      `/organizations/${organization.slug}/trace-items/attributes/`,
       expect.objectContaining({
         method: 'GET',
         query: {
+          attributeType: 'number',
+          itemType: 'spans',
           project: [],
-          environment: [],
-          statsPeriod: '1h',
+          statsPeriod: '10d',
+          substringMatch: undefined,
+        },
+      })
+    );
+    expect(traceItemAttributesMock).toHaveBeenNthCalledWith(
+      2,
+      `/organizations/${organization.slug}/trace-items/attributes/`,
+      expect.objectContaining({
+        method: 'GET',
+        query: {
+          attributeType: 'string',
+          itemType: 'spans',
+          project: [],
+          statsPeriod: '10d',
+          substringMatch: undefined,
         },
       })
     );
@@ -326,14 +337,31 @@ describe('messageSpanSamplesPanel', () => {
         }),
       })
     );
-    expect(spanFieldTagsMock).toHaveBeenCalledWith(
-      `/organizations/${organization.slug}/spans/fields/`,
+    expect(traceItemAttributesMock).toHaveBeenNthCalledWith(
+      1,
+      `/organizations/${organization.slug}/trace-items/attributes/`,
       expect.objectContaining({
         method: 'GET',
         query: {
+          attributeType: 'number',
+          itemType: 'spans',
           project: [],
-          environment: [],
-          statsPeriod: '1h',
+          statsPeriod: '10d',
+          substringMatch: undefined,
+        },
+      })
+    );
+    expect(traceItemAttributesMock).toHaveBeenNthCalledWith(
+      2,
+      `/organizations/${organization.slug}/trace-items/attributes/`,
+      expect.objectContaining({
+        method: 'GET',
+        query: {
+          attributeType: 'string',
+          itemType: 'spans',
+          project: [],
+          statsPeriod: '10d',
+          substringMatch: undefined,
         },
       })
     );