Skip to content

Commit 4d7fa3e

Browse files
authored
ref: remove deprecated opaque and transparent colors (#95326)
@Jesse-Box I had to change some uses in profiling from “transparent greay” to “normal” gray. I think they still look fine, but I could also inline the previous colors there if you prefer: | before | after | |--------|--------| | <img width="1463" height="167" alt="Screenshot 2025-07-11 at 13 56 41" src="https://github.com/user-attachments/assets/feec753b-8faa-4aab-b754-88bd8380d1cb" /> | <img width="1463" height="167" alt="Screenshot 2025-07-11 at 13 57 00" src="https://github.com/user-attachments/assets/f01ffd82-a7f0-49df-9502-1da7f7ef7364" /> | | <img width="1463" height="167" alt="Screenshot 2025-07-11 at 13 56 46" src="https://github.com/user-attachments/assets/a481b4de-9dab-4a17-a272-cfd5df7f6fca" /> | <img width="1463" height="167" alt="Screenshot 2025-07-11 at 13 56 56" src="https://github.com/user-attachments/assets/420639db-72bf-4d9a-8cdd-3b332e6d4484" /> |
1 parent 3b1bb7f commit 4d7fa3e

File tree

2 files changed

+6
-34
lines changed

2 files changed

+6
-34
lines changed

static/app/utils/profiling/flamegraph/flamegraphTheme.tsx

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -382,8 +382,8 @@ export const makeLightChonkFlamegraphTheme = (
382382
SEARCH_RESULT_SPAN_COLOR: '#fdb359',
383383

384384
// Patterns
385-
SPAN_FRAME_LINE_PATTERN_BACKGROUND: theme.colors.grayTransparent100,
386-
SPAN_FRAME_LINE_PATTERN: theme.colors.grayTransparent200,
385+
SPAN_FRAME_LINE_PATTERN_BACKGROUND: theme.colors.gray100,
386+
SPAN_FRAME_LINE_PATTERN: theme.colors.gray200,
387387

388388
// Fallbacks
389389
SPAN_FALLBACK_COLOR: [0, 0, 0, 0.1],
@@ -396,7 +396,7 @@ export const makeLightChonkFlamegraphTheme = (
396396
MINIMAP_POSITION_OVERLAY_BORDER_COLOR: theme.colors.gray300,
397397
MINIMAP_POSITION_OVERLAY_COLOR: theme.colors.gray200,
398398

399-
SPAN_FRAME_BORDER: theme.colors.grayTransparent300,
399+
SPAN_FRAME_BORDER: theme.colors.gray300,
400400
STACK_TO_COLOR: makeStackToColor([0, 0, 0, 0.035]),
401401
},
402402
};
@@ -475,8 +475,8 @@ export const makeDarkChonkFlamegraphTheme = (
475475
SEARCH_RESULT_SPAN_COLOR: '#fdb359',
476476

477477
// Patterns
478-
SPAN_FRAME_LINE_PATTERN: theme.colors.grayTransparent200,
479-
SPAN_FRAME_LINE_PATTERN_BACKGROUND: theme.colors.grayTransparent100,
478+
SPAN_FRAME_LINE_PATTERN: theme.colors.gray200,
479+
SPAN_FRAME_LINE_PATTERN_BACKGROUND: theme.colors.gray100,
480480

481481
// Fallbacks
482482
FRAME_FALLBACK_COLOR: [0.5, 0.5, 0.5, 0.4],
@@ -488,7 +488,7 @@ export const makeDarkChonkFlamegraphTheme = (
488488
MINIMAP_POSITION_OVERLAY_BORDER_COLOR: theme.colors.gray300,
489489
MINIMAP_POSITION_OVERLAY_COLOR: theme.colors.gray200,
490490

491-
SPAN_FRAME_BORDER: theme.colors.grayTransparent300,
491+
SPAN_FRAME_BORDER: theme.colors.gray300,
492492
STACK_TO_COLOR: makeStackToColor([1, 1, 1, 0.18]),
493493
},
494494
};

static/app/utils/theme/theme.chonk.tsx

Lines changed: 0 additions & 28 deletions
Original file line numberDiff line numberDiff line change
@@ -573,20 +573,6 @@ const lightColors = {
573573
surface200: '#EAE7F6', // border.muted
574574
surface100: '#DFDBEF', // border.primary
575575

576-
// ⚠ Deprecated
577-
grayOpaque500: '#181423',
578-
grayOpaque400: '#6D6B74',
579-
grayOpaque300: '#939198',
580-
grayOpaque200: '#E0DFE2',
581-
grayOpaque100: '#F3F3F4',
582-
583-
// ⚠ Deprecated
584-
grayTransparent500: 'rgba(24, 20, 35, 1.0)',
585-
grayTransparent400: 'rgba(24, 20, 35, 0.63)',
586-
grayTransparent300: 'rgba(24, 20, 35, 0.47)',
587-
grayTransparent200: 'rgba(24, 20, 35, 0.14)',
588-
grayTransparent100: 'rgba(24, 20, 35, 0.05)',
589-
590576
gray800: '#181423', // content.primary
591577
gray700: '#3B434E', // ⚠ link.muted.active only
592578
gray600: '#48515B', // ⚠ link.muted.hover only
@@ -656,20 +642,6 @@ const darkColors: typeof lightColors = {
656642
surface200: '#0D071A', // border.muted
657643
surface100: '#000000', // border.primary
658644

659-
// ⚠ Deprecated
660-
grayOpaque500: '#F6F5FA',
661-
grayOpaque400: '#A09DA8',
662-
grayOpaque300: '#767380',
663-
grayOpaque200: '#4D4A59',
664-
grayOpaque100: '#3D394A',
665-
666-
// ⚠ Deprecated
667-
grayTransparent500: 'rgba(246, 245, 250, 1.0)',
668-
grayTransparent400: 'rgba(246, 245, 250, 0.58)',
669-
grayTransparent300: 'rgba(246, 245, 250, 0.37)',
670-
grayTransparent200: 'rgba(246, 245, 250, 0.18)',
671-
grayTransparent100: 'rgba(246, 245, 250, 0.10)',
672-
673645
gray800: '#F6F5FA', // content.primary
674646
gray700: '#C6C0D6', // ⚠ link.muted.active only
675647
gray600: '#B3ADC3', // ⚠ link.muted.hover only

0 commit comments

Comments
 (0)