chore(billing): Add tally type info + checkout PAYG categories (#95461)

Closes
https://linear.app/getsentry/issue/BIL-951/dont-explicitly-define-payg-categories-for-checkout
Closes
https://linear.app/getsentry/issue/BIL-953/add-tally-type-information-to-the-frontend

Author: isabellaenriquez

static/gsApp/constants.tsx

@@ -59,6 +59,7 @@ Object.entries(DEFAULT_BILLED_DATA_CATEGORY_INFO).forEach(
       feature: null,
       hasSpikeProtection: false,
       reservedVolumeTooltip: null,
+      tallyType: 'usage',
     };
   }
 );
@@ -73,7 +74,6 @@ export const BILLED_DATA_CATEGORY_INFO = {
   [DataCategoryExact.ERROR]: {
     ...DEFAULT_BILLED_DATA_CATEGORY_INFO[DataCategoryExact.ERROR],
     canAllocate: true,
-    canProductTrial: false,
     maxAdminGift: 10_000_000,
     freeEventsMultiple: 1_000,
     hasSpikeProtection: true,
@@ -96,7 +96,6 @@ export const BILLED_DATA_CATEGORY_INFO = {
   [DataCategoryExact.ATTACHMENT]: {
     ...DEFAULT_BILLED_DATA_CATEGORY_INFO[DataCategoryExact.ATTACHMENT],
     canAllocate: true,
-    canProductTrial: false,
     maxAdminGift: 10_000,
     freeEventsMultiple: 1,
     feature: 'event-attachments',
@@ -107,7 +106,6 @@ export const BILLED_DATA_CATEGORY_INFO = {
   },
   [DataCategoryExact.REPLAY]: {
     ...DEFAULT_BILLED_DATA_CATEGORY_INFO[DataCategoryExact.REPLAY],
-    canAllocate: false,
     canProductTrial: true,
     maxAdminGift: 1_000_000,
     freeEventsMultiple: 1,
@@ -118,7 +116,6 @@ export const BILLED_DATA_CATEGORY_INFO = {
   },
   [DataCategoryExact.SPAN]: {
     ...DEFAULT_BILLED_DATA_CATEGORY_INFO[DataCategoryExact.SPAN],
-    canAllocate: false,
     canProductTrial: true,
     maxAdminGift: 1_000_000_000,
     freeEventsMultiple: 100_000,
@@ -130,58 +127,44 @@ export const BILLED_DATA_CATEGORY_INFO = {
   },
   [DataCategoryExact.SPAN_INDEXED]: {
     ...DEFAULT_BILLED_DATA_CATEGORY_INFO[DataCategoryExact.SPAN_INDEXED],
-    canAllocate: false,
     canProductTrial: true,
     maxAdminGift: 1_000_000_000,
     freeEventsMultiple: 100_000,
     feature: 'spans-usage-tracking',
   },
   [DataCategoryExact.MONITOR_SEAT]: {
     ...DEFAULT_BILLED_DATA_CATEGORY_INFO[DataCategoryExact.MONITOR_SEAT],
-    canAllocate: false,
-    canProductTrial: false,
     maxAdminGift: 10_000,
     freeEventsMultiple: 1,
     feature: 'monitor-seat-billing',
+    tallyType: 'seat',
   },
   [DataCategoryExact.UPTIME]: {
     ...DEFAULT_BILLED_DATA_CATEGORY_INFO[DataCategoryExact.UPTIME],
-    canAllocate: false,
-    canProductTrial: false,
     maxAdminGift: 10_000,
     freeEventsMultiple: 1,
     feature: 'uptime-billing',
+    tallyType: 'seat',
   },
   [DataCategoryExact.PROFILE_DURATION]: {
     ...DEFAULT_BILLED_DATA_CATEGORY_INFO[DataCategoryExact.PROFILE_DURATION],
-    canAllocate: false,
     canProductTrial: true,
     maxAdminGift: 10_000,
     freeEventsMultiple: 1, // in hours
-    feature: null,
   },
   [DataCategoryExact.PROFILE_DURATION_UI]: {
     ...DEFAULT_BILLED_DATA_CATEGORY_INFO[DataCategoryExact.PROFILE_DURATION_UI],
-    canAllocate: false,
     canProductTrial: true,
     maxAdminGift: 10_000,
     freeEventsMultiple: 1, // in hours
-    feature: null,
   },
+  // Seer categories have product trials through ReservedBudgetCategoryType.SEER, not as individual categories
   [DataCategoryExact.SEER_AUTOFIX]: {
     ...DEFAULT_BILLED_DATA_CATEGORY_INFO[DataCategoryExact.SEER_AUTOFIX],
-    canAllocate: false,
-    canProductTrial: false,
-    maxAdminGift: 0,
-    freeEventsMultiple: 0,
     feature: 'seer-billing',
   },
   [DataCategoryExact.SEER_SCANNER]: {
     ...DEFAULT_BILLED_DATA_CATEGORY_INFO[DataCategoryExact.SEER_SCANNER],
-    canAllocate: false,
-    canProductTrial: false,
-    maxAdminGift: 0,
-    freeEventsMultiple: 0,
     feature: 'seer-billing',
   },
 } as const satisfies Record<DataCategoryExact, BilledDataCategoryInfo>;

static/gsApp/types/index.tsx

@@ -1030,4 +1030,8 @@ export interface BilledDataCategoryInfo extends DataCategoryInfo {
    * The tooltip text for the checkout page
    */
   reservedVolumeTooltip: string | null;
+  /**
+   * How usage is tallied for the category
+   */
+  tallyType: 'usage' | 'seat';
 }

static/gsApp/views/amCheckout/checkoutOverviewV2.tsx

@@ -191,12 +191,9 @@ function CheckoutOverviewV2({activePlan, formData, onUpdate: _onUpdate}: Props)
   };
 
   const renderObservabilityProductBreakdown = () => {
-    const paygCategories = [
-      DataCategory.MONITOR_SEATS,
-      DataCategory.PROFILE_DURATION,
-      DataCategory.PROFILE_DURATION_UI,
-      DataCategory.UPTIME,
-    ];
+    const paygCategories = activePlan.onDemandCategories.filter(
+      category => activePlan.planCategories[category]?.length === 1
+    );
 
     const budgetCategories = Object.values(
       activePlan.availableReservedBudgetTypes

static/gsApp/views/subscriptionPage/overview.tsx

@@ -25,7 +25,11 @@ import type {
 } from 'getsentry/types';
 import {PlanTier} from 'getsentry/types';
 import {hasAccessToSubscriptionOverview} from 'getsentry/utils/billing';
-import {isPartOfReservedBudget, sortCategories} from 'getsentry/utils/dataCategory';
+import {
+  getCategoryInfoFromPlural,
+  isPartOfReservedBudget,
+  sortCategories,
+} from 'getsentry/utils/dataCategory';
 import withPromotions from 'getsentry/utils/withPromotions';
 import ContactBillingMembers from 'getsentry/views/contactBillingMembers';
 import {openOnDemandBudgetEditModal} from 'getsentry/views/onDemandBudgets/editOnDemandButton';
@@ -205,15 +209,12 @@ function Overview({location, subscription, promotionData}: Props) {
           )
           .map(categoryHistory => {
             const category = categoryHistory.category;
+            const categoryInfo = getCategoryInfoFromPlural(category);
 
-            // The usageData does not include details for seat-based categories.
-            // For now we will handle the monitor category specially
+            // The usageData does not include details for seat-based categories
             let monitor_usage: number | undefined = 0;
-            if (category === DataCategory.MONITOR_SEATS) {
-              monitor_usage = subscription.categories.monitorSeats?.usage;
-            }
-            if (category === DataCategory.UPTIME) {
-              monitor_usage = subscription.categories.uptime?.usage;
+            if (categoryInfo?.tallyType === 'seat') {
+              monitor_usage = subscription.categories[category]?.usage;
             }
 
             if (
@@ -224,7 +225,7 @@ function Overview({location, subscription, promotionData}: Props) {
             }
 
             const categoryTotals: BillingStatTotal =
-              category !== DataCategory.MONITOR_SEATS && category !== DataCategory.UPTIME
+              categoryInfo?.tallyType === 'usage'
                 ? usageData.totals[category]!
                 : {
                     accepted: monitor_usage ?? 0,
@@ -235,9 +236,8 @@ function Overview({location, subscription, promotionData}: Props) {
                     filtered: 0,
                     projected: 0,
                   };
-
             const eventTotals =
-              category !== DataCategory.MONITOR_SEATS && category !== DataCategory.UPTIME
+              categoryInfo?.tallyType === 'usage'
                 ? usageData.eventTotals?.[category]
                 : undefined;
 
@@ -259,9 +259,7 @@ function Overview({location, subscription, promotionData}: Props) {
                 trueForward={categoryHistory.trueForward}
                 softCapType={categoryHistory.softCapType}
                 disableTable={
-                  category === DataCategory.MONITOR_SEATS ||
-                  category === DataCategory.UPTIME ||
-                  displayMode === 'cost'
+                  categoryInfo?.tallyType === 'seat' || displayMode === 'cost'
                 }
                 subscription={subscription}
                 organization={organization}