chore(opsgenie): instrument opsgenie installation slos (#94587)

Author: Christinarlong

src/sentry/integrations/opsgenie/integration.py

@@ -14,6 +14,7 @@
 from sentry.integrations.base import (
     FeatureDescription,
     IntegrationData,
+    IntegrationDomain,
     IntegrationFeatures,
     IntegrationInstallation,
     IntegrationMetadata,
@@ -26,6 +27,10 @@
 from sentry.integrations.opsgenie.tasks import migrate_opsgenie_plugin
 from sentry.integrations.pipeline import IntegrationPipeline
 from sentry.integrations.types import IntegrationProviderSlug
+from sentry.integrations.utils.metrics import (
+    IntegrationPipelineViewEvent,
+    IntegrationPipelineViewType,
+)
 from sentry.organizations.services.organization.model import RpcOrganization
 from sentry.pipeline.views.base import PipelineView
 from sentry.shared_integrations.exceptions import (
@@ -105,24 +110,30 @@ class InstallationForm(forms.Form):
 
 
 class InstallationConfigView:
-    def dispatch(self, request: HttpRequest, pipeline: IntegrationPipeline) -> HttpResponseBase:
-        if request.method == "POST":
-            form = InstallationForm(request.POST)
-            if form.is_valid():
-                form_data = form.cleaned_data
-
-                pipeline.bind_state("installation_data", form_data)
-
-                return pipeline.next_step()
-        else:
-            form = InstallationForm()
-
-        return render_to_response(
-            template="sentry/integrations/opsgenie-config.html",
-            context={"form": form},
-            request=request,
+    def record_event(self, event: IntegrationPipelineViewType):
+        return IntegrationPipelineViewEvent(
+            event, IntegrationDomain.ON_CALL_SCHEDULING, OpsgenieIntegrationProvider.key
         )
 
+    def dispatch(self, request: HttpRequest, pipeline: IntegrationPipeline) -> HttpResponseBase:
+        with self.record_event(IntegrationPipelineViewType.INSTALLATION_CONFIGURATION).capture():
+            if request.method == "POST":
+                form = InstallationForm(request.POST)
+                if form.is_valid():
+                    form_data = form.cleaned_data
+
+                    pipeline.bind_state("installation_data", form_data)
+
+                    return pipeline.next_step()
+            else:
+                form = InstallationForm()
+
+            return render_to_response(
+                template="sentry/integrations/opsgenie-config.html",
+                context={"form": form},
+                request=request,
+            )
+
 
 class OpsgenieIntegration(IntegrationInstallation):
     def get_keyring_client(self, keyid: int | str) -> OpsgenieClient:

src/sentry/integrations/utils/metrics.py

@@ -355,6 +355,9 @@ class IntegrationPipelineViewType(StrEnum):
     # Jira Server
     WEBHOOK_CREATION = "webhook_creation"
 
+    # Opsgenie
+    INSTALLATION_CONFIGURATION = "installation_configuration"
+
 
 class IntegrationPipelineErrorReason(StrEnum):
     # OAuth identity

tests/sentry/integrations/opsgenie/test_integration.py

@@ -15,7 +15,7 @@
 from sentry.integrations.types import EventLifecycleOutcome
 from sentry.models.rule import Rule
 from sentry.shared_integrations.exceptions import ApiRateLimitedError, ApiUnauthorized
-from sentry.testutils.asserts import assert_slo_metric
+from sentry.testutils.asserts import assert_slo_metric, assert_success_metric
 from sentry.testutils.cases import APITestCase, IntegrationTestCase
 from sentry.testutils.helpers.features import with_feature
 from sentry.testutils.silo import assume_test_silo_mode_of, control_silo_test
@@ -64,9 +64,13 @@ def assert_setup_flow(self, config):
         resp = self.client.post(self.init_path, data=config)
         assert resp.status_code == 200
 
-    def test_installation_no_key(self):
+    @patch("sentry.integrations.utils.metrics.EventLifecycle.record_event")
+    def test_installation_no_key(self, mock_record):
         self.assert_setup_flow(self.config_no_key)
 
+        # SLO assertions
+        assert_success_metric(mock_record)
+
         integration = Integration.objects.get(provider=self.provider.key)
         org_integration = OrganizationIntegration.objects.get(integration_id=integration.id)