ref: extract defaultCreateButtonTracking

Author: TkDodo

static/app/components/core/button/useButtonFunctionality.tsx

@@ -6,23 +6,12 @@ import type {
   DO_NOT_USE_LinkButtonProps as LinkButtonProps,
 } from './types';
 
-export function useButtonFunctionality(props: ButtonProps | LinkButtonProps) {
-  // Fallbacking aria-label to string children is not necessary as screen
-  // readers natively understand that scenario. Leaving it here for a bunch of
-  // our tests that query by aria-label.
-  const accessibleLabel =
-    props['aria-label'] ??
-    (typeof props.children === 'string' ? props.children : undefined);
-
-  const useButtonTrackingLogger = () => {
-    const hasAnalyticsDebug = window.localStorage?.getItem('DEBUG_ANALYTICS') === '1';
+const defaultCreateButtonTracking = (props: ButtonProps) => {
+  const hasAnalyticsDebug = window.localStorage?.getItem('DEBUG_ANALYTICS') === '1';
+  return () => {
     const hasCustomAnalytics =
       props.analyticsEventName || props.analyticsEventKey || props.analyticsParams;
-    if (!hasCustomAnalytics || !hasAnalyticsDebug) {
-      return () => {};
-    }
-
-    return () => {
+    if (hasCustomAnalytics && hasAnalyticsDebug) {
       // eslint-disable-next-line no-console
       console.log('buttonAnalyticsEvent', {
         eventKey: props.analyticsEventKey,
@@ -31,13 +20,22 @@ export function useButtonFunctionality(props: ButtonProps | LinkButtonProps) {
         href: 'href' in props ? props.href : undefined,
         ...props.analyticsParams,
       });
-    };
+    }
   };
+};
+
+export function useButtonFunctionality(props: ButtonProps | LinkButtonProps) {
+  // Fallbacking aria-label to string children is not necessary as screen
+  // readers natively understand that scenario. Leaving it here for a bunch of
+  // our tests that query by aria-label.
+  const accessibleLabel =
+    props['aria-label'] ??
+    (typeof props.children === 'string' ? props.children : undefined);
 
-  const useButtonTracking =
-    HookStore.get('react-hook:use-button-tracking')[0] ?? useButtonTrackingLogger;
+  const createButtonTracking =
+    HookStore.get('react-hook:use-button-tracking')[0] ?? defaultCreateButtonTracking;
 
-  const buttonTracking = useButtonTracking({
+  const buttonTracking = createButtonTracking({
     analyticsEventName: props.analyticsEventName,
     analyticsEventKey: props.analyticsEventKey,
     analyticsParams: {